All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sunil V L <sunilvl@ventanamicro.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "Haibo Xu" <xiaobo55x@gmail.com>,
	"Xu, Haibo1" <haibo1.xu@intel.com>,
	"ajones@ventanamicro.com" <ajones@ventanamicro.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Len Brown" <lenb@kernel.org>,
	"Moore, Robert" <robert.moore@intel.com>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Guo Ren" <guoren@kernel.org>,
	"Alexandre Ghiti" <alexghiti@rivosinc.com>,
	"Greentime Hu" <greentime.hu@sifive.com>,
	"Charlie Jenkins" <charlie@rivosinc.com>,
	"Sami Tolvanen" <samitolvanen@google.com>,
	"Zong Li" <zong.li@sifive.com>,
	"Jisheng Zhang" <jszhang@kernel.org>,
	"Baoquan He" <bhe@redhat.com>,
	"Clément Léger" <cleger@rivosinc.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Chen Jiahao" <chenjiahao16@huawei.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"James Morse" <james.morse@arm.com>,
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
	"Evan Green" <evan@rivosinc.com>,
	"Samuel Holland" <samuel.holland@sifive.com>,
	"Marc Zyngier" <maz@kernel.org>,
	"Anup Patel" <apatel@ventanamicro.com>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	"Yuntao Wang" <ytcoode@gmail.com>,
	"Schofield, Alison" <alison.schofield@intel.com>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"acpica-devel@lists.linux.dev" <acpica-devel@lists.linux.dev>
Subject: Re: [PATCH v2 6/6] ACPI: RISCV: Enable ACPI based NUMA
Date: Wed, 3 Apr 2024 09:24:21 +0530	[thread overview]
Message-ID: <ZgzS7W83iWRII73G@sunil-laptop> (raw)
In-Reply-To: <SJ1PR11MB6083B43290D216B1568642B0FC3F2@SJ1PR11MB6083.namprd11.prod.outlook.com>

On Mon, Apr 01, 2024 at 04:57:30PM +0000, Luck, Tony wrote:
> >> If the firmware didn't provide the SRAT/SLIT on ACPI based systems, then
> >> there will be a message "Failed to initialise from firmware" from
> >> arch_acpi_numa_init(). This is not specific to RISC-V. But I am
> >> wondering why should it be pr_info instead of pr_debug.
> >>
> >
> > My understanding is maybe it just wants to expose explicit logs to
> > avoid any potential bugs from FW or Kernel.
> 
> There are lots of ACPI enabled systems that aren't NUMA (single
> socket servers, desktops, laptops). Making this "pr_info()" would just
> add noise to the boot on all of those.
> 
Exactly. But this is an existing pr_info message across architectures.
My suggestion is to add one more patch in this series to convert
this to pr_debug unless someone has strong reason to keep it pr_info.

Thanks,
Sunil

WARNING: multiple messages have this Message-ID (diff)
From: Sunil V L <sunilvl@ventanamicro.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "Haibo Xu" <xiaobo55x@gmail.com>,
	"Xu, Haibo1" <haibo1.xu@intel.com>,
	"ajones@ventanamicro.com" <ajones@ventanamicro.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Len Brown" <lenb@kernel.org>,
	"Moore, Robert" <robert.moore@intel.com>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Guo Ren" <guoren@kernel.org>,
	"Alexandre Ghiti" <alexghiti@rivosinc.com>,
	"Greentime Hu" <greentime.hu@sifive.com>,
	"Charlie Jenkins" <charlie@rivosinc.com>,
	"Sami Tolvanen" <samitolvanen@google.com>,
	"Zong Li" <zong.li@sifive.com>,
	"Jisheng Zhang" <jszhang@kernel.org>,
	"Baoquan He" <bhe@redhat.com>,
	"Clément Léger" <cleger@rivosinc.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Chen Jiahao" <chenjiahao16@huawei.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"James Morse" <james.morse@arm.com>,
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
	"Evan Green" <evan@rivosinc.com>,
	"Samuel Holland" <samuel.holland@sifive.com>,
	"Marc Zyngier" <maz@kernel.org>,
	"Anup Patel" <apatel@ventanamicro.com>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	"Yuntao Wang" <ytcoode@gmail.com>,
	"Schofield, Alison" <alison.schofield@intel.com>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"acpica-devel@lists.linux.dev" <acpica-devel@lists.linux.dev>
Subject: Re: [PATCH v2 6/6] ACPI: RISCV: Enable ACPI based NUMA
Date: Wed, 3 Apr 2024 09:24:21 +0530	[thread overview]
Message-ID: <ZgzS7W83iWRII73G@sunil-laptop> (raw)
In-Reply-To: <SJ1PR11MB6083B43290D216B1568642B0FC3F2@SJ1PR11MB6083.namprd11.prod.outlook.com>

On Mon, Apr 01, 2024 at 04:57:30PM +0000, Luck, Tony wrote:
> >> If the firmware didn't provide the SRAT/SLIT on ACPI based systems, then
> >> there will be a message "Failed to initialise from firmware" from
> >> arch_acpi_numa_init(). This is not specific to RISC-V. But I am
> >> wondering why should it be pr_info instead of pr_debug.
> >>
> >
> > My understanding is maybe it just wants to expose explicit logs to
> > avoid any potential bugs from FW or Kernel.
> 
> There are lots of ACPI enabled systems that aren't NUMA (single
> socket servers, desktops, laptops). Making this "pr_info()" would just
> add noise to the boot on all of those.
> 
Exactly. But this is an existing pr_info message across architectures.
My suggestion is to add one more patch in this series to convert
this to pr_debug unless someone has strong reason to keep it pr_info.

Thanks,
Sunil

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2024-04-03  3:54 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07  8:47 [PATCH v2 0/6] Add ACPI NUMA support for RISC-V Haibo Xu
2024-03-07  8:47 ` Haibo Xu
2024-03-07  8:47 ` [PATCH v2 1/6] ACPICA: SRAT: Add RISC-V RINTC affinity structure Haibo Xu
2024-03-07  8:47   ` Haibo Xu
2024-03-07  8:47 ` [PATCH v2 2/6] ACPI: RISCV: Add NUMA support based on SRAT and SLIT Haibo Xu
2024-03-07  8:47   ` Haibo Xu
2024-04-01  7:06   ` Sunil V L
2024-04-01  7:06     ` Sunil V L
2024-04-01  7:41     ` Haibo Xu
2024-04-01  7:41       ` Haibo Xu
2024-04-02  9:31   ` Alexandre Ghiti
2024-04-02  9:31     ` Alexandre Ghiti
2024-04-07  3:09     ` Haibo Xu
2024-04-07  3:09       ` Haibo Xu
2024-03-07  8:47 ` [PATCH v2 3/6] ACPI: NUMA: Add handler for SRAT RINTC affinity structure Haibo Xu
2024-03-07  8:47   ` Haibo Xu
2024-04-01  6:56   ` Sunil V L
2024-04-01  6:56     ` Sunil V L
2024-03-07  8:47 ` [PATCH v2 4/6] ACPI: NUMA: Make some NUMA related parse functions common Haibo Xu
2024-03-07  8:47   ` Haibo Xu
2024-04-01  7:00   ` Sunil V L
2024-04-01  7:00     ` Sunil V L
2024-03-07  8:47 ` [PATCH v2 5/6] ACPI: NUMA: Remove ARCH depends option in ACPI_NUMA Kconfig Haibo Xu
2024-03-07  8:47   ` Haibo Xu
2024-03-07  8:44   ` Arnd Bergmann
2024-03-07  8:44     ` Arnd Bergmann
2024-03-07  9:19     ` Haibo Xu
2024-03-07  9:19       ` Haibo Xu
2024-03-07  9:22       ` Arnd Bergmann
2024-03-07  9:22         ` Arnd Bergmann
2024-03-07  9:28         ` Haibo Xu
2024-03-07  9:28           ` Haibo Xu
2024-03-07  8:47 ` [PATCH v2 6/6] ACPI: RISCV: Enable ACPI based NUMA Haibo Xu
2024-03-07  8:47   ` Haibo Xu
2024-04-01  7:18   ` Sunil V L
2024-04-01  7:18     ` Sunil V L
2024-04-01  8:04     ` Haibo Xu
2024-04-01  8:04       ` Haibo Xu
2024-04-01 16:57       ` Luck, Tony
2024-04-01 16:57         ` Luck, Tony
2024-04-03  3:54         ` Sunil V L [this message]
2024-04-03  3:54           ` Sunil V L
2024-04-07  2:53           ` Haibo Xu
2024-04-07  2:53             ` Haibo Xu
2024-03-27 12:37 ` [PATCH v2 0/6] Add ACPI NUMA support for RISC-V Haibo Xu
2024-03-27 12:37   ` Haibo Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZgzS7W83iWRII73G@sunil-laptop \
    --to=sunilvl@ventanamicro.com \
    --cc=acpica-devel@lists.linux.dev \
    --cc=ajones@ventanamicro.com \
    --cc=alexghiti@rivosinc.com \
    --cc=alison.schofield@intel.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=apatel@ventanamicro.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bhe@redhat.com \
    --cc=charlie@rivosinc.com \
    --cc=chenjiahao16@huawei.com \
    --cc=cleger@rivosinc.com \
    --cc=conor.dooley@microchip.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=evan@rivosinc.com \
    --cc=greentime.hu@sifive.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=guoren@kernel.org \
    --cc=haibo1.xu@intel.com \
    --cc=james.morse@arm.com \
    --cc=jszhang@kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=rafael@kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=robert.moore@intel.com \
    --cc=samitolvanen@google.com \
    --cc=samuel.holland@sifive.com \
    --cc=tony.luck@intel.com \
    --cc=xiaobo55x@gmail.com \
    --cc=ytcoode@gmail.com \
    --cc=zong.li@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.