[pdx86-platform-drivers-x86:review-hans 40/59] drivers/platform/x86/amd/pmc/mp2_stb.c:94:9: error: implicit declaration of function 'writeq'; did you mean 'writel'?

[pdx86-platform-drivers-x86:review-hans 40/59] drivers/platform/x86/amd/pmc/mp2_stb.c:94:9: error: implicit declaration of function 'writeq'; did you mean 'writel'?

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
head:   0aae4c44b032b5ede39405dfc62900adc467f362
commit: 2dc77993cb5eb311d6bb5584d30c3d1d42d9fa4a [40/59] platform/x86/amd/pmc: Add AMD MP2 STB functionality
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240416/202404160320.QAHyZ0c3-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240416/202404160320.QAHyZ0c3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404160320.QAHyZ0c3-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/platform/x86/amd/pmc/mp2_stb.c: In function 'amd_mp2_stb_send_cmd':
>> drivers/platform/x86/amd/pmc/mp2_stb.c:94:9: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration]
      94 |         writeq(mp2->dma_addr, mp2->mmio + AMD_C2P_MSG1);
         |         ^~~~~~
         |         writel
   cc1: some warnings being treated as errors


vim +94 drivers/platform/x86/amd/pmc/mp2_stb.c

    84	
    85	static void amd_mp2_stb_send_cmd(struct amd_mp2_dev *mp2, u8 cmd_id, bool is_dma_used)
    86	{
    87		struct mp2_cmd_base cmd_base;
    88	
    89		cmd_base.ul = 0;
    90		cmd_base.field.cmd_id = cmd_id;
    91		cmd_base.field.intr_disable = 1;
    92		cmd_base.field.is_dma_used = is_dma_used;
    93	
  > 94		writeq(mp2->dma_addr, mp2->mmio + AMD_C2P_MSG1);
    95		writel(cmd_base.ul, mp2->mmio + AMD_C2P_MSG0);
    96	}
    97	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [pdx86-platform-drivers-x86:review-hans 40/59] drivers/platform/x86/amd/pmc/mp2_stb.c:94:9: error: implicit declaration of function 'writeq'; did you mean 'writel'?

[Andy Shevchenko]

On Tue, Apr 16, 2024 at 03:54:35AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
> head:   0aae4c44b032b5ede39405dfc62900adc467f362
> commit: 2dc77993cb5eb311d6bb5584d30c3d1d42d9fa4a [40/59] platform/x86/amd/pmc: Add AMD MP2 STB functionality
> config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240416/202404160320.QAHyZ0c3-lkp@intel.com/config)
> compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240416/202404160320.QAHyZ0c3-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202404160320.QAHyZ0c3-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/platform/x86/amd/pmc/mp2_stb.c: In function 'amd_mp2_stb_send_cmd':
> >> drivers/platform/x86/amd/pmc/mp2_stb.c:94:9: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration]
>       94 |         writeq(mp2->dma_addr, mp2->mmio + AMD_C2P_MSG1);
>          |         ^~~~~~
>          |         writel
>    cc1: some warnings being treated as errors

Either depend on X86_64 or include one of io-64-nonatomic-hi-lo.h,
io-64-nonatomic-lo-hi.h to fix.

-- 
With Best Regards,
Andy Shevchenko