All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: Breno Leitao <leitao@debian.org>
Cc: aleksander.lobakin@intel.com, kuba@kernel.org,
	davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
	elder@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, nbd@nbd.name,
	sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com,
	lorenzo@kernel.org, taras.chornyi@plvision.eu,
	ath11k@lists.infradead.org, ath10k@lists.infradead.org,
	linux-wireless@vger.kernel.org, geomatsi@gmail.com,
	kvalo@kernel.org, quic_jjohnson@quicinc.com, leon@kernel.org,
	dennis.dalessandro@cornelisnetworks.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	bpf@vger.kernel.org, Jiri Pirko <jiri@resnulli.us>,
	Simon Horman <horms@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH net-next v5 02/10] net: free_netdev: exit earlier if dummy
Date: Wed, 10 Apr 2024 18:05:47 +0300	[thread overview]
Message-ID: <Zhaqyyk9CUaUvMDy@shredder> (raw)
In-Reply-To: <20240410131407.3897251-3-leitao@debian.org>

On Wed, Apr 10, 2024 at 06:13:43AM -0700, Breno Leitao wrote:
> For dummy devices, exit earlier at free_netdev() instead of executing
> the whole function. This is necessary, because dummy devices are
> special, and shouldn't have the second part of the function executed.
> 
> Otherwise reg_state, which is NETREG_DUMMY, will be overwritten and
> there will be no way to identify that this is a dummy device. Also, this
> device do not need the final put_device(), since dummy devices are not
> registered (through register_netdevice()), where the device reference is
> increased (at netdev_register_kobject()/device_add()).
> 
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@idosch.org>
To: Breno Leitao <leitao@debian.org>
Cc: aleksander.lobakin@intel.com, kuba@kernel.org,
	davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
	elder@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, nbd@nbd.name,
	sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com,
	lorenzo@kernel.org, taras.chornyi@plvision.eu,
	ath11k@lists.infradead.org, ath10k@lists.infradead.org,
	linux-wireless@vger.kernel.org, geomatsi@gmail.com,
	kvalo@kernel.org, quic_jjohnson@quicinc.com, leon@kernel.org,
	dennis.dalessandro@cornelisnetworks.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	bpf@vger.kernel.org, Jiri Pirko <jiri@resnulli.us>,
	Simon Horman <horms@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH net-next v5 02/10] net: free_netdev: exit earlier if dummy
Date: Wed, 10 Apr 2024 18:05:47 +0300	[thread overview]
Message-ID: <Zhaqyyk9CUaUvMDy@shredder> (raw)
In-Reply-To: <20240410131407.3897251-3-leitao@debian.org>

On Wed, Apr 10, 2024 at 06:13:43AM -0700, Breno Leitao wrote:
> For dummy devices, exit earlier at free_netdev() instead of executing
> the whole function. This is necessary, because dummy devices are
> special, and shouldn't have the second part of the function executed.
> 
> Otherwise reg_state, which is NETREG_DUMMY, will be overwritten and
> there will be no way to identify that this is a dummy device. Also, this
> device do not need the final put_device(), since dummy devices are not
> registered (through register_netdevice()), where the device reference is
> increased (at netdev_register_kobject()/device_add()).
> 
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-04-10 15:05 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10 13:13 [PATCH net-next v5 00/10] allocate dummy device dynamically Breno Leitao
2024-04-10 13:13 ` Breno Leitao
2024-04-10 13:13 ` [PATCH net-next v5 01/10] net: core: Fix documentation Breno Leitao
2024-04-10 13:13   ` Breno Leitao
2024-04-10 15:03   ` Ido Schimmel
2024-04-10 15:03     ` Ido Schimmel
2024-04-10 13:13 ` [PATCH net-next v5 02/10] net: free_netdev: exit earlier if dummy Breno Leitao
2024-04-10 13:13   ` Breno Leitao
2024-04-10 15:05   ` Ido Schimmel [this message]
2024-04-10 15:05     ` Ido Schimmel
2024-04-10 13:13 ` [PATCH net-next v5 03/10] net: create a dummy net_device allocator Breno Leitao
2024-04-10 13:13   ` Breno Leitao
2024-04-10 13:13 ` [PATCH net-next v5 04/10] net: marvell: prestera: allocate dummy net_device dynamically Breno Leitao
2024-04-10 13:13   ` Breno Leitao
2024-04-10 13:13 ` [PATCH net-next v5 05/10] net: mediatek: mtk_eth_sock: " Breno Leitao
2024-04-10 13:13   ` Breno Leitao
2024-04-10 13:13 ` [PATCH net-next v5 06/10] net: ipa: " Breno Leitao
2024-04-10 13:13   ` Breno Leitao
2024-04-10 13:13 ` [PATCH net-next v5 07/10] net: ibm/emac: " Breno Leitao
2024-04-10 13:13   ` Breno Leitao
2024-04-10 13:13 ` [PATCH net-next v5 08/10] wifi: qtnfmac: Use netdev dummy allocator helper Breno Leitao
2024-04-10 13:13   ` Breno Leitao
2024-04-10 13:13 ` [PATCH net-next v5 09/10] wifi: ath10k: allocate dummy net_device dynamically Breno Leitao
2024-04-10 13:13   ` Breno Leitao
2024-04-11  8:38 ` [PATCH net-next v5 00/10] allocate dummy device dynamically Kalle Valo
2024-04-11  8:38   ` Kalle Valo
2024-04-11 13:09 ` Jakub Kicinski
2024-04-11 13:09   ` Jakub Kicinski
2024-04-11 13:41   ` Breno Leitao
2024-04-11 13:41     ` Breno Leitao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zhaqyyk9CUaUvMDy@shredder \
    --to=idosch@idosch.org \
    --cc=Mark-MC.Lee@mediatek.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=ath10k@lists.infradead.org \
    --cc=ath11k@lists.infradead.org \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dennis.dalessandro@cornelisnetworks.com \
    --cc=edumazet@google.com \
    --cc=elder@kernel.org \
    --cc=geomatsi@gmail.com \
    --cc=horms@kernel.org \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=leitao@debian.org \
    --cc=leon@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=quic_jjohnson@quicinc.com \
    --cc=sean.wang@mediatek.com \
    --cc=taras.chornyi@plvision.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.