Re: [PATCH 1/3] dt-bindings: spi: airoha: Add YAML schema for SNFI controller

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]

> On 11/04/2024 13:08, Lorenzo Bianconi wrote:
> > Introduce Airoha EN7581 SPI NAND controller binding
> > 
> > Tested-by: Rajeev Kumar <Rajeev.Kumar@airoha.com>
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >  .../bindings/spi/airoha,spi-airoha-snfi.yaml  | 56 +++++++++++++++++++
> >  1 file changed, 56 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/spi/airoha,spi-airoha-snfi.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/spi/airoha,spi-airoha-snfi.yaml b/Documentation/devicetree/bindings/spi/airoha,spi-airoha-snfi.yaml
> > new file mode 100644
> > index 000000000000..0244f242eff1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spi/airoha,spi-airoha-snfi.yaml
> 
> Use compatible as filename.

ack, I will fix it.

> 
> > @@ -0,0 +1,56 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/spi/airoha,spi-airoha-snfi.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: SPI-NAND flash controller for Airoha ARM SoCs
> > +
> > +maintainers:
> > +  - Lorenzo Bianconi <lorenzo@kernel.org>
> > +
> > +allOf:
> > +  - $ref: spi-controller.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: airoha,en7581-snand
> > +
> > +  reg:
> > +    maxItems: 2
> 
> Instead list and describe items.

ack, I will fix it.

> 
> > +
> > +  interrupts:
> > +    maxItems: 1
> 
> This looks incomplete. No clocks? No other resources?

actually spi-snand relies on a fixed-rate clock. I will fix it.

Regards,
Lorenzo

> 
> Best regards,
> Krzysztof
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]