[palmer:for-next 27/30] arch/riscv/mm/cacheflush.c:168:37: error: 'mm_context_t' has no member named 'icache_stale_mask'

[palmer:for-next 27/30] arch/riscv/mm/cacheflush.c:168:37: error: 'mm_context_t' has no member named 'icache_stale_mask'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git for-next
head:   a76716f0ec75b9e7ac62d30854d690044c857684
commit: 383289e4b071ca4c8c42e34567f3f267766f093c [27/30] riscv: Include riscv_set_icache_flush_ctx prctl
config: riscv-allnoconfig (https://download.01.org/0day-ci/archive/20240418/202404180621.qG7A9Tk0-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240418/202404180621.qG7A9Tk0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404180621.qG7A9Tk0-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   arch/riscv/mm/cacheflush.c: In function 'set_icache_stale_mask':
>> arch/riscv/mm/cacheflush.c:168:37: error: 'mm_context_t' has no member named 'icache_stale_mask'
     168 |         mask = &current->mm->context.icache_stale_mask;
         |                                     ^
   arch/riscv/mm/cacheflush.c: At top level:
>> arch/riscv/mm/cacheflush.c:157:13: warning: 'set_icache_stale_mask' defined but not used [-Wunused-function]
     157 | static void set_icache_stale_mask(void)
         |             ^~~~~~~~~~~~~~~~~~~~~


vim +168 arch/riscv/mm/cacheflush.c

   156	
 > 157	static void set_icache_stale_mask(void)
   158	{
   159		cpumask_t *mask;
   160		bool stale_cpu;
   161	
   162		/*
   163		 * Mark every other hart's icache as needing a flush for
   164		 * this MM. Maintain the previous value of the current
   165		 * cpu to handle the case when this function is called
   166		 * concurrently on different harts.
   167		 */
 > 168		mask = &current->mm->context.icache_stale_mask;
   169		stale_cpu = cpumask_test_cpu(smp_processor_id(), mask);
   170	
   171		cpumask_setall(mask);
   172		assign_bit(cpumask_check(smp_processor_id()), cpumask_bits(mask), stale_cpu);
   173	}
   174	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [palmer:for-next 27/30] arch/riscv/mm/cacheflush.c:168:37: error: 'mm_context_t' has no member named 'icache_stale_mask'

[Charlie Jenkins]

On Thu, Apr 18, 2024 at 06:14:34AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git for-next
> head:   a76716f0ec75b9e7ac62d30854d690044c857684
> commit: 383289e4b071ca4c8c42e34567f3f267766f093c [27/30] riscv: Include riscv_set_icache_flush_ctx prctl
> config: riscv-allnoconfig (https://download.01.org/0day-ci/archive/20240418/202404180621.qG7A9Tk0-lkp@intel.com/config)
> compiler: riscv64-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240418/202404180621.qG7A9Tk0-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202404180621.qG7A9Tk0-lkp@intel.com/
> 
> All error/warnings (new ones prefixed by >>):
> 
>    arch/riscv/mm/cacheflush.c: In function 'set_icache_stale_mask':
> >> arch/riscv/mm/cacheflush.c:168:37: error: 'mm_context_t' has no member named 'icache_stale_mask'
>      168 |         mask = &current->mm->context.icache_stale_mask;
>          |                                     ^
>    arch/riscv/mm/cacheflush.c: At top level:
> >> arch/riscv/mm/cacheflush.c:157:13: warning: 'set_icache_stale_mask' defined but not used [-Wunused-function]
>      157 | static void set_icache_stale_mask(void)
>          |             ^~~~~~~~~~~~~~~~~~~~~
> 
> 
> vim +168 arch/riscv/mm/cacheflush.c
> 
>    156	
>  > 157	static void set_icache_stale_mask(void)
>    158	{
>    159		cpumask_t *mask;
>    160		bool stale_cpu;
>    161	
>    162		/*
>    163		 * Mark every other hart's icache as needing a flush for
>    164		 * this MM. Maintain the previous value of the current
>    165		 * cpu to handle the case when this function is called
>    166		 * concurrently on different harts.
>    167		 */
>  > 168		mask = &current->mm->context.icache_stale_mask;
>    169		stale_cpu = cpumask_test_cpu(smp_processor_id(), mask);
>    170	
>    171		cpumask_setall(mask);
>    172		assign_bit(cpumask_check(smp_processor_id()), cpumask_bits(mask), stale_cpu);
>    173	}
>    174	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

I thought I tested this... Simple fix though, just need to guard this
function with CONFIG_SMP
https://lore.kernel.org/lkml/20240417-fix_nosmp_icache-v1-1-921a3c07d4ce@rivosinc.com/T/#u.

- Charlie

Re: [palmer:for-next 27/30] arch/riscv/mm/cacheflush.c:168:37: error: 'mm_context_t' has no member named 'icache_stale_mask'

[Palmer Dabbelt]

On Wed, 17 Apr 2024 16:51:22 PDT (-0700), Charlie Jenkins wrote:
> On Thu, Apr 18, 2024 at 06:14:34AM +0800, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git for-next
>> head:   a76716f0ec75b9e7ac62d30854d690044c857684
>> commit: 383289e4b071ca4c8c42e34567f3f267766f093c [27/30] riscv: Include riscv_set_icache_flush_ctx prctl
>> config: riscv-allnoconfig (https://download.01.org/0day-ci/archive/20240418/202404180621.qG7A9Tk0-lkp@intel.com/config)
>> compiler: riscv64-linux-gcc (GCC) 13.2.0
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240418/202404180621.qG7A9Tk0-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202404180621.qG7A9Tk0-lkp@intel.com/
>>
>> All error/warnings (new ones prefixed by >>):
>>
>>    arch/riscv/mm/cacheflush.c: In function 'set_icache_stale_mask':
>> >> arch/riscv/mm/cacheflush.c:168:37: error: 'mm_context_t' has no member named 'icache_stale_mask'
>>      168 |         mask = &current->mm->context.icache_stale_mask;
>>          |                                     ^
>>    arch/riscv/mm/cacheflush.c: At top level:
>> >> arch/riscv/mm/cacheflush.c:157:13: warning: 'set_icache_stale_mask' defined but not used [-Wunused-function]
>>      157 | static void set_icache_stale_mask(void)
>>          |             ^~~~~~~~~~~~~~~~~~~~~
>>
>>
>> vim +168 arch/riscv/mm/cacheflush.c
>>
>>    156
>>  > 157	static void set_icache_stale_mask(void)
>>    158	{
>>    159		cpumask_t *mask;
>>    160		bool stale_cpu;
>>    161
>>    162		/*
>>    163		 * Mark every other hart's icache as needing a flush for
>>    164		 * this MM. Maintain the previous value of the current
>>    165		 * cpu to handle the case when this function is called
>>    166		 * concurrently on different harts.
>>    167		 */
>>  > 168		mask = &current->mm->context.icache_stale_mask;
>>    169		stale_cpu = cpumask_test_cpu(smp_processor_id(), mask);
>>    170
>>    171		cpumask_setall(mask);
>>    172		assign_bit(cpumask_check(smp_processor_id()), cpumask_bits(mask), stale_cpu);
>>    173	}
>>    174
>>
>> --
>> 0-DAY CI Kernel Test Service
>> https://github.com/intel/lkp-tests/wiki
>
> I thought I tested this... Simple fix though, just need to guard this
> function with CONFIG_SMP
> https://lore.kernel.org/lkml/20240417-fix_nosmp_icache-v1-1-921a3c07d4ce@rivosinc.com/T/#u.

Thanks.  This hasn't landed in for-next yet, so I'm just going to squash 
it into the offending patch.

>
> - Charlie