All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH 3/4] x86/paging: vCPU host mode is always set
Date: Wed, 24 Apr 2024 11:34:15 +0200	[thread overview]
Message-ID: <ZijSFzOAeo1SfSrb@macbook> (raw)
In-Reply-To: <67805c1f-7187-446c-a5c4-14be8f170f11@suse.com>

On Tue, Apr 23, 2024 at 04:32:32PM +0200, Jan Beulich wrote:
> ... thanks to paging_vcpu_init() being part of vCPU creation. Further
> if paging is enabled on a domain, it's also guaranteed to be either HAP
> or shadow. Drop respective unnecessary (parts of) conditionals.

Is there some commit that changed when arch.paging.mode gets set, so
that this is actually safe to do now, but not when the code in
paging_dump_vcpu_info() was introduced?

I get the feeling we want to reference some change here in order to
explain why is now always guaranteed to be set.

> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


  reply	other threads:[~2024-04-24  9:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23 14:30 [PATCH 0/4] x86/mm: assorted adjustments Jan Beulich
2024-04-23 14:31 ` [PATCH 1/4] x86/P2M: write_p2m_entry() is HVM-only anyway Jan Beulich
2024-04-23 19:29   ` Andrew Cooper
2024-04-24  6:36     ` Jan Beulich
2024-04-24  8:49       ` Jan Beulich
2024-04-23 14:32 ` [PATCH 2/4] x86/P2M: un-indent write_p2m_entry() Jan Beulich
2024-04-24  9:16   ` Roger Pau Monné
2024-04-24 11:39     ` Jan Beulich
2024-04-23 14:32 ` [PATCH 3/4] x86/paging: vCPU host mode is always set Jan Beulich
2024-04-24  9:34   ` Roger Pau Monné [this message]
2024-04-24 11:41     ` Jan Beulich
2024-04-24 13:01       ` Roger Pau Monné
2024-04-23 14:33 ` [PATCH 4/4] x86/shadow: correct shadow_vcpu_init()'s comment Jan Beulich
2024-04-24 10:06   ` Roger Pau Monné
2024-04-24 11:44     ` Jan Beulich
2024-04-24 12:58       ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZijSFzOAeo1SfSrb@macbook \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.