From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-fscrypt@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
David Hildenbrand <david@redhat.com>
Subject: Re: [f2fs-dev] [PATCH 6/6] mm: Remove page_mapping()
Date: Thu, 25 Apr 2024 00:59:02 +0100 [thread overview]
Message-ID: <ZimcxvN1fyYfpRVl@casper.infradead.org> (raw)
In-Reply-To: <20240424163423.ad6e23a984deb731e2de497c@linux-foundation.org>
On Wed, Apr 24, 2024 at 04:34:23PM -0700, Andrew Morton wrote:
> For some reason,
>
> mm/hugetlb.c: In function 'hugetlb_page_mapping_lock_write':
> mm/hugetlb.c:2164:41: error: implicit declaration of function 'page_mapping'; did you mean 'page_mapped'? [-Werror=implicit-function-declaration]
> 2164 | struct address_space *mapping = page_mapping(hpage);
> | ^~~~~~~~~~~~
> | page_mapped
> mm/hugetlb.c:2164:41: error: initialization of 'struct address_space *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
>
>
> I'll disable "mm: Remove page_mapping()" pending review of the below,
> please.
Looks pretty similar to
https://lore.kernel.org/linux-mm/20240412193510.2356957-7-willy@infradead.org/
Sorry, I thought you'd picked up that series; I think it's fully
reviewed by now?
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-fscrypt@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 6/6] mm: Remove page_mapping()
Date: Thu, 25 Apr 2024 00:59:02 +0100 [thread overview]
Message-ID: <ZimcxvN1fyYfpRVl@casper.infradead.org> (raw)
In-Reply-To: <20240424163423.ad6e23a984deb731e2de497c@linux-foundation.org>
On Wed, Apr 24, 2024 at 04:34:23PM -0700, Andrew Morton wrote:
> For some reason,
>
> mm/hugetlb.c: In function 'hugetlb_page_mapping_lock_write':
> mm/hugetlb.c:2164:41: error: implicit declaration of function 'page_mapping'; did you mean 'page_mapped'? [-Werror=implicit-function-declaration]
> 2164 | struct address_space *mapping = page_mapping(hpage);
> | ^~~~~~~~~~~~
> | page_mapped
> mm/hugetlb.c:2164:41: error: initialization of 'struct address_space *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
>
>
> I'll disable "mm: Remove page_mapping()" pending review of the below,
> please.
Looks pretty similar to
https://lore.kernel.org/linux-mm/20240412193510.2356957-7-willy@infradead.org/
Sorry, I thought you'd picked up that series; I think it's fully
reviewed by now?
next prev parent reply other threads:[~2024-04-24 23:59 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 22:55 [f2fs-dev] [PATCH 0/6] Remove page_mapping() Matthew Wilcox (Oracle)
2024-04-23 22:55 ` Matthew Wilcox (Oracle)
2024-04-23 22:55 ` [f2fs-dev] [PATCH 1/6] fscrypt: Convert bh_get_inode_and_lblk_num to use a folio Matthew Wilcox (Oracle)
2024-04-23 22:55 ` Matthew Wilcox (Oracle)
2024-04-23 23:34 ` [f2fs-dev] " Eric Biggers
2024-04-23 23:34 ` Eric Biggers
2024-04-24 11:53 ` [f2fs-dev] " David Hildenbrand
2024-04-24 11:53 ` David Hildenbrand
2024-04-23 22:55 ` [f2fs-dev] [PATCH 2/6] f2fs: Convert f2fs_clear_page_cache_dirty_tag " Matthew Wilcox (Oracle)
2024-04-23 22:55 ` Matthew Wilcox (Oracle)
2024-04-24 11:53 ` [f2fs-dev] " David Hildenbrand
2024-04-24 11:53 ` David Hildenbrand
2024-04-23 22:55 ` [f2fs-dev] [PATCH 3/6] memory-failure: Remove calls to page_mapping() Matthew Wilcox (Oracle)
2024-04-23 22:55 ` Matthew Wilcox (Oracle)
2024-04-23 23:52 ` [f2fs-dev] " Sidhartha Kumar via Linux-f2fs-devel
2024-04-23 23:52 ` Sidhartha Kumar
2024-04-24 11:54 ` [f2fs-dev] " David Hildenbrand
2024-04-24 11:54 ` David Hildenbrand
2024-04-25 6:21 ` [f2fs-dev] " Miaohe Lin via Linux-f2fs-devel
2024-04-25 6:21 ` Miaohe Lin
2024-04-23 22:55 ` [f2fs-dev] [PATCH 4/6] migrate: Expand the use of folio in __migrate_device_pages() Matthew Wilcox (Oracle)
2024-04-23 22:55 ` Matthew Wilcox (Oracle)
2024-04-24 11:54 ` [f2fs-dev] " David Hildenbrand
2024-04-24 11:54 ` David Hildenbrand
2024-04-23 22:55 ` [f2fs-dev] [PATCH 5/6] userfault; Expand folio use in mfill_atomic_install_pte() Matthew Wilcox (Oracle)
2024-04-23 22:55 ` Matthew Wilcox (Oracle)
2024-04-24 11:55 ` [f2fs-dev] " David Hildenbrand
2024-04-24 11:55 ` David Hildenbrand
2024-04-23 22:55 ` [f2fs-dev] [PATCH 6/6] mm: Remove page_mapping() Matthew Wilcox (Oracle)
2024-04-23 22:55 ` Matthew Wilcox (Oracle)
2024-04-24 11:55 ` [f2fs-dev] " David Hildenbrand
2024-04-24 11:55 ` David Hildenbrand
2024-04-24 23:34 ` [f2fs-dev] " Andrew Morton
2024-04-24 23:34 ` Andrew Morton
2024-04-24 23:59 ` Matthew Wilcox [this message]
2024-04-24 23:59 ` Matthew Wilcox
2024-05-20 21:16 ` [f2fs-dev] [PATCH 0/6] " patchwork-bot+f2fs
2024-05-20 21:16 ` patchwork-bot+f2fs
2024-07-24 2:16 ` patchwork-bot+f2fs
2024-07-24 2:16 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZimcxvN1fyYfpRVl@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.