* [PATCH] xen-livepatch: fix --force option comparison
@ 2024-04-26 7:21 Roger Pau Monne
2024-04-26 8:29 ` Anthony PERARD
2024-04-26 9:42 ` Ross Lagerwall
0 siblings, 2 replies; 3+ messages in thread
From: Roger Pau Monne @ 2024-04-26 7:21 UTC (permalink / raw)
To: xen-devel; +Cc: Roger Pau Monne, Ross Lagerwall, Anthony PERARD, Jan Beulich
The check for --force option shouldn't be against 0.
Reported-by: Jan Beulich <jbeulich@suse.com>
Fixes: 62a72092a517 ('livepatch: introduce --force option')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
tools/misc/xen-livepatch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/misc/xen-livepatch.c b/tools/misc/xen-livepatch.c
index c16fb6862d6c..f406ea1373ae 100644
--- a/tools/misc/xen-livepatch.c
+++ b/tools/misc/xen-livepatch.c
@@ -576,7 +576,7 @@ int main(int argc, char *argv[])
return 0;
}
- if ( strcmp("--force", argv[1]) )
+ if ( !strcmp("--force", argv[1]) )
{
if ( argc <= 2 )
{
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] xen-livepatch: fix --force option comparison
2024-04-26 7:21 [PATCH] xen-livepatch: fix --force option comparison Roger Pau Monne
@ 2024-04-26 8:29 ` Anthony PERARD
2024-04-26 9:42 ` Ross Lagerwall
1 sibling, 0 replies; 3+ messages in thread
From: Anthony PERARD @ 2024-04-26 8:29 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: xen-devel, Ross Lagerwall, Jan Beulich
On Fri, Apr 26, 2024 at 09:21:44AM +0200, Roger Pau Monne wrote:
> The check for --force option shouldn't be against 0.
>
> Reported-by: Jan Beulich <jbeulich@suse.com>
> Fixes: 62a72092a517 ('livepatch: introduce --force option')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xen-livepatch: fix --force option comparison
2024-04-26 7:21 [PATCH] xen-livepatch: fix --force option comparison Roger Pau Monne
2024-04-26 8:29 ` Anthony PERARD
@ 2024-04-26 9:42 ` Ross Lagerwall
1 sibling, 0 replies; 3+ messages in thread
From: Ross Lagerwall @ 2024-04-26 9:42 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: xen-devel, Anthony PERARD, Jan Beulich
On Fri, Apr 26, 2024 at 8:21 AM Roger Pau Monne <roger.pau@citrix.com> wrote:
>
> The check for --force option shouldn't be against 0.
>
> Reported-by: Jan Beulich <jbeulich@suse.com>
> Fixes: 62a72092a517 ('livepatch: introduce --force option')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-26 9:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-26 7:21 [PATCH] xen-livepatch: fix --force option comparison Roger Pau Monne
2024-04-26 8:29 ` Anthony PERARD
2024-04-26 9:42 ` Ross Lagerwall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.