From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>,
Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 6/8] drm/i915/pciids: remove 11 from INTEL_ICL_IDS()
Date: Fri, 10 May 2024 09:32:56 -0400 [thread overview]
Message-ID: <Zj4iCCV_yD7qhx5E@intel.com> (raw)
In-Reply-To: <36973674bf333dfdd7cd32ae656754bfa150022b.1715340032.git.jani.nikula@intel.com>
On Fri, May 10, 2024 at 02:22:19PM +0300, Jani Nikula wrote:
> Most other PCI ID macros do not encode the gen in the name. Follow suit
> for ICL.
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> arch/x86/kernel/early-quirks.c | 2 +-
> drivers/gpu/drm/i915/display/intel_display_device.c | 2 +-
> drivers/gpu/drm/i915/i915_pci.c | 2 +-
> include/drm/i915_pciids.h | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 2b698a3f56ef..c150bb6f1a39 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -547,7 +547,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> INTEL_CML_IDS(&gen9_early_ops),
> INTEL_GLK_IDS(&gen9_early_ops),
> INTEL_CNL_IDS(&gen9_early_ops),
> - INTEL_ICL_11_IDS(&gen11_early_ops),
> + INTEL_ICL_IDS(&gen11_early_ops),
> INTEL_EHL_IDS(&gen11_early_ops),
> INTEL_JSL_IDS(&gen11_early_ops),
> INTEL_TGL_12_IDS(&gen11_early_ops),
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
> index 23909a8e2dc8..e47896002c13 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -831,7 +831,7 @@ static const struct {
> INTEL_CFL_IDS(&skl_display),
> INTEL_WHL_IDS(&skl_display),
> INTEL_CML_IDS(&skl_display),
> - INTEL_ICL_11_IDS(&icl_display),
> + INTEL_ICL_IDS(&icl_display),
> INTEL_EHL_IDS(&jsl_ehl_display),
> INTEL_JSL_IDS(&jsl_ehl_display),
> INTEL_TGL_12_IDS(&tgl_display),
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index d85f023afebe..06b1d50ae47c 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -857,7 +857,7 @@ static const struct pci_device_id pciidlist[] = {
> INTEL_CML_GT2_IDS(&cml_gt2_info),
> INTEL_CML_U_GT1_IDS(&cml_gt1_info),
> INTEL_CML_U_GT2_IDS(&cml_gt2_info),
> - INTEL_ICL_11_IDS(&icl_info),
> + INTEL_ICL_IDS(&icl_info),
> INTEL_EHL_IDS(&ehl_info),
> INTEL_JSL_IDS(&jsl_info),
> INTEL_TGL_12_IDS(&tgl_info),
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 0c5a20d59801..ecfd7f71e2e7 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -597,7 +597,7 @@
> INTEL_VGA_DEVICE(0x8A70, info), \
> INTEL_VGA_DEVICE(0x8A71, info)
>
> -#define INTEL_ICL_11_IDS(info) \
> +#define INTEL_ICL_IDS(info) \
> INTEL_ICL_PORT_F_IDS(info), \
> INTEL_VGA_DEVICE(0x8A51, info), \
> INTEL_VGA_DEVICE(0x8A5D, info)
> --
> 2.39.2
>
next prev parent reply other threads:[~2024-05-10 13:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 11:22 [PATCH 0/8] drm/i915/pciids: PCI ID macro cleanups Jani Nikula
2024-05-10 11:22 ` [PATCH 1/8] drm/i915/pciids: add INTEL_PNV_IDS(), use acronym Jani Nikula
2024-05-10 13:31 ` Rodrigo Vivi
2024-05-10 11:22 ` [PATCH 2/8] drm/i915/pciids: add INTEL_ILK_IDS(), " Jani Nikula
2024-05-10 13:31 ` Rodrigo Vivi
2024-05-10 11:22 ` [PATCH 3/8] drm/i915/pciids: add INTEL_SNB_IDS() Jani Nikula
2024-05-10 13:31 ` Rodrigo Vivi
2024-05-10 11:22 ` [PATCH 4/8] drm/i915/pciids: add INTEL_IVB_IDS() Jani Nikula
2024-05-10 13:31 ` Rodrigo Vivi
2024-05-10 11:22 ` [PATCH 5/8] drm/i915/pciids: don't include WHL/CML PCI IDs in CFL Jani Nikula
2024-05-10 13:32 ` Rodrigo Vivi
2024-05-10 11:22 ` [PATCH 6/8] drm/i915/pciids: remove 11 from INTEL_ICL_IDS() Jani Nikula
2024-05-10 13:32 ` Rodrigo Vivi [this message]
2024-05-10 11:22 ` [PATCH 7/8] drm/i915/pciids: remove 12 from INTEL_TGL_IDS() Jani Nikula
2024-05-10 13:33 ` Rodrigo Vivi
2024-05-10 11:22 ` [PATCH 8/8] drm/i915/pciids: don't include RPL-U PCI IDs in RPL-P Jani Nikula
2024-05-10 13:09 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pciids: PCI ID macro cleanups Patchwork
2024-05-10 13:15 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-10 13:55 ` [PATCH 0/8] " Jani Nikula
2024-05-15 14:25 ` Jani Nikula
2024-05-15 22:13 ` Dave Hansen
2024-05-16 8:20 ` Jani Nikula
2024-05-15 15:45 ` Bjorn Helgaas
2024-05-15 16:32 ` Jani Nikula
2024-05-11 5:11 ` ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj4iCCV_yD7qhx5E@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=bhelgaas@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.