From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>,
Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 7/8] drm/i915/pciids: remove 12 from INTEL_TGL_IDS()
Date: Fri, 10 May 2024 09:33:08 -0400 [thread overview]
Message-ID: <Zj4iFDXSriO9HaxI@intel.com> (raw)
In-Reply-To: <044a5c553dc4564431bbef197d5e2dd085624fc2.1715340032.git.jani.nikula@intel.com>
On Fri, May 10, 2024 at 02:22:20PM +0300, Jani Nikula wrote:
> Most other PCI ID macros do not encode the gen in the name. Follow suit
> for TGL.
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> arch/x86/kernel/early-quirks.c | 2 +-
> drivers/gpu/drm/i915/display/intel_display_device.c | 2 +-
> drivers/gpu/drm/i915/i915_pci.c | 2 +-
> drivers/gpu/drm/i915/intel_device_info.c | 2 +-
> include/drm/i915_pciids.h | 10 +++++-----
> 5 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index c150bb6f1a39..b2b9cc3b9545 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -550,7 +550,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> INTEL_ICL_IDS(&gen11_early_ops),
> INTEL_EHL_IDS(&gen11_early_ops),
> INTEL_JSL_IDS(&gen11_early_ops),
> - INTEL_TGL_12_IDS(&gen11_early_ops),
> + INTEL_TGL_IDS(&gen11_early_ops),
> INTEL_RKL_IDS(&gen11_early_ops),
> INTEL_ADLS_IDS(&gen11_early_ops),
> INTEL_ADLP_IDS(&gen11_early_ops),
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
> index e47896002c13..fb4c4054207e 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -834,7 +834,7 @@ static const struct {
> INTEL_ICL_IDS(&icl_display),
> INTEL_EHL_IDS(&jsl_ehl_display),
> INTEL_JSL_IDS(&jsl_ehl_display),
> - INTEL_TGL_12_IDS(&tgl_display),
> + INTEL_TGL_IDS(&tgl_display),
> INTEL_DG1_IDS(&dg1_display),
> INTEL_RKL_IDS(&rkl_display),
> INTEL_ADLS_IDS(&adl_s_display),
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 06b1d50ae47c..fa56113ed1ce 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -860,7 +860,7 @@ static const struct pci_device_id pciidlist[] = {
> INTEL_ICL_IDS(&icl_info),
> INTEL_EHL_IDS(&ehl_info),
> INTEL_JSL_IDS(&jsl_info),
> - INTEL_TGL_12_IDS(&tgl_info),
> + INTEL_TGL_IDS(&tgl_info),
> INTEL_RKL_IDS(&rkl_info),
> INTEL_ADLS_IDS(&adl_s_info),
> INTEL_ADLP_IDS(&adl_p_info),
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index a0a43ea07f11..64651a54a245 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -173,7 +173,7 @@ static const u16 subplatform_portf_ids[] = {
> };
>
> static const u16 subplatform_uy_ids[] = {
> - INTEL_TGL_12_GT2_IDS(0),
> + INTEL_TGL_GT2_IDS(0),
> };
>
> static const u16 subplatform_n_ids[] = {
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index ecfd7f71e2e7..42913d2eb655 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -620,12 +620,12 @@
> INTEL_VGA_DEVICE(0x4E71, info)
>
> /* TGL */
> -#define INTEL_TGL_12_GT1_IDS(info) \
> +#define INTEL_TGL_GT1_IDS(info) \
> INTEL_VGA_DEVICE(0x9A60, info), \
> INTEL_VGA_DEVICE(0x9A68, info), \
> INTEL_VGA_DEVICE(0x9A70, info)
>
> -#define INTEL_TGL_12_GT2_IDS(info) \
> +#define INTEL_TGL_GT2_IDS(info) \
> INTEL_VGA_DEVICE(0x9A40, info), \
> INTEL_VGA_DEVICE(0x9A49, info), \
> INTEL_VGA_DEVICE(0x9A59, info), \
> @@ -635,9 +635,9 @@
> INTEL_VGA_DEVICE(0x9AD9, info), \
> INTEL_VGA_DEVICE(0x9AF8, info)
>
> -#define INTEL_TGL_12_IDS(info) \
> - INTEL_TGL_12_GT1_IDS(info), \
> - INTEL_TGL_12_GT2_IDS(info)
> +#define INTEL_TGL_IDS(info) \
> + INTEL_TGL_GT1_IDS(info), \
> + INTEL_TGL_GT2_IDS(info)
>
> /* RKL */
> #define INTEL_RKL_IDS(info) \
> --
> 2.39.2
>
next prev parent reply other threads:[~2024-05-10 13:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 11:22 [PATCH 0/8] drm/i915/pciids: PCI ID macro cleanups Jani Nikula
2024-05-10 11:22 ` [PATCH 1/8] drm/i915/pciids: add INTEL_PNV_IDS(), use acronym Jani Nikula
2024-05-10 13:31 ` Rodrigo Vivi
2024-05-10 11:22 ` [PATCH 2/8] drm/i915/pciids: add INTEL_ILK_IDS(), " Jani Nikula
2024-05-10 13:31 ` Rodrigo Vivi
2024-05-10 11:22 ` [PATCH 3/8] drm/i915/pciids: add INTEL_SNB_IDS() Jani Nikula
2024-05-10 13:31 ` Rodrigo Vivi
2024-05-10 11:22 ` [PATCH 4/8] drm/i915/pciids: add INTEL_IVB_IDS() Jani Nikula
2024-05-10 13:31 ` Rodrigo Vivi
2024-05-10 11:22 ` [PATCH 5/8] drm/i915/pciids: don't include WHL/CML PCI IDs in CFL Jani Nikula
2024-05-10 13:32 ` Rodrigo Vivi
2024-05-10 11:22 ` [PATCH 6/8] drm/i915/pciids: remove 11 from INTEL_ICL_IDS() Jani Nikula
2024-05-10 13:32 ` Rodrigo Vivi
2024-05-10 11:22 ` [PATCH 7/8] drm/i915/pciids: remove 12 from INTEL_TGL_IDS() Jani Nikula
2024-05-10 13:33 ` Rodrigo Vivi [this message]
2024-05-10 11:22 ` [PATCH 8/8] drm/i915/pciids: don't include RPL-U PCI IDs in RPL-P Jani Nikula
2024-05-10 13:09 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pciids: PCI ID macro cleanups Patchwork
2024-05-10 13:15 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-10 13:55 ` [PATCH 0/8] " Jani Nikula
2024-05-15 14:25 ` Jani Nikula
2024-05-15 22:13 ` Dave Hansen
2024-05-16 8:20 ` Jani Nikula
2024-05-15 15:45 ` Bjorn Helgaas
2024-05-15 16:32 ` Jani Nikula
2024-05-11 5:11 ` ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj4iFDXSriO9HaxI@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=bhelgaas@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.