* [PATCH 1/2] xfs: Remove duplicate xfs_da_format.h header
@ 2024-04-30 3:47 Jiapeng Chong
2024-04-30 3:47 ` [PATCH 2/2] xfs: Remove duplicate xfs_da_btree.h header Jiapeng Chong
2024-04-30 4:04 ` [PATCH 1/2] xfs: Remove duplicate xfs_da_format.h header Christoph Hellwig
0 siblings, 2 replies; 4+ messages in thread
From: Jiapeng Chong @ 2024-04-30 3:47 UTC (permalink / raw)
To: chandan.babu; +Cc: djwong, linux-xfs, linux-kernel, Jiapeng Chong, Abaci Robot
./fs/xfs/libxfs/xfs_trans_resv.c: xfs_da_format.h is included more than once.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8931
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/xfs/libxfs/xfs_trans_resv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_trans_resv.c b/fs/xfs/libxfs/xfs_trans_resv.c
index 6dbe6e7251e7..3dc8f785bf29 100644
--- a/fs/xfs/libxfs/xfs_trans_resv.c
+++ b/fs/xfs/libxfs/xfs_trans_resv.c
@@ -22,7 +22,6 @@
#include "xfs_rtbitmap.h"
#include "xfs_attr_item.h"
#include "xfs_log.h"
-#include "xfs_da_format.h"
#define _ALLOC true
#define _FREE false
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] xfs: Remove duplicate xfs_da_btree.h header
2024-04-30 3:47 [PATCH 1/2] xfs: Remove duplicate xfs_da_format.h header Jiapeng Chong
@ 2024-04-30 3:47 ` Jiapeng Chong
2024-04-30 4:04 ` Christoph Hellwig
2024-04-30 4:04 ` [PATCH 1/2] xfs: Remove duplicate xfs_da_format.h header Christoph Hellwig
1 sibling, 1 reply; 4+ messages in thread
From: Jiapeng Chong @ 2024-04-30 3:47 UTC (permalink / raw)
To: chandan.babu; +Cc: djwong, linux-xfs, linux-kernel, Jiapeng Chong, Abaci Robot
./fs/xfs/xfs_handle.c: xfs_da_btree.h is included more than once.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8930
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/xfs/xfs_handle.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/xfs_handle.c b/fs/xfs/xfs_handle.c
index c8785ed59543..234b2c965fb6 100644
--- a/fs/xfs/xfs_handle.c
+++ b/fs/xfs/xfs_handle.c
@@ -21,7 +21,6 @@
#include "xfs_attr.h"
#include "xfs_ioctl.h"
#include "xfs_parent.h"
-#include "xfs_da_btree.h"
#include "xfs_handle.h"
#include "xfs_health.h"
#include "xfs_icache.h"
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] xfs: Remove duplicate xfs_da_format.h header
2024-04-30 3:47 [PATCH 1/2] xfs: Remove duplicate xfs_da_format.h header Jiapeng Chong
2024-04-30 3:47 ` [PATCH 2/2] xfs: Remove duplicate xfs_da_btree.h header Jiapeng Chong
@ 2024-04-30 4:04 ` Christoph Hellwig
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2024-04-30 4:04 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: chandan.babu, djwong, linux-xfs, linux-kernel, Abaci Robot
On Tue, Apr 30, 2024 at 11:47:27AM +0800, Jiapeng Chong wrote:
> ./fs/xfs/libxfs/xfs_trans_resv.c: xfs_da_format.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8931
I don't think we do Closes for random bugzilla, never mind for trivial
cleanups.
The changes itself looks fine, though:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-30 4:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-30 3:47 [PATCH 1/2] xfs: Remove duplicate xfs_da_format.h header Jiapeng Chong
2024-04-30 3:47 ` [PATCH 2/2] xfs: Remove duplicate xfs_da_btree.h header Jiapeng Chong
2024-04-30 4:04 ` Christoph Hellwig
2024-04-30 4:04 ` [PATCH 1/2] xfs: Remove duplicate xfs_da_format.h header Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.