From: Drew Fustini <dfustini@tenstorrent.com>
To: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
Cc: Jisheng Zhang <jszhang@kernel.org>, Guo Ren <guoren@kernel.org>,
Fu Wei <wefu@redhat.com>, Yangtao Li <frank.li@vivo.com>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH RFC v2 4/4] riscv: dts: thead: Add clock to TH1520 mmc controllers
Date: Thu, 2 May 2024 08:53:05 -0700 [thread overview]
Message-ID: <ZjO24XikkqNAnbti@x1> (raw)
In-Reply-To: <1444dac5-c725-4bf7-8843-469a62c3abf1@bootlin.com>
On Thu, May 02, 2024 at 09:47:43AM +0200, Thomas Bonnefille wrote:
>
>
> On 4/27/24 2:10 AM, Drew Fustini wrote:
> > Change the clock property in the T-Head TH1520 mmc controller nodes to a
> > real clock provided by the AP_SUBSYS clock driver.
> >
> > Signed-off-by: Drew Fustini <dfustini@tenstorrent.com>
>
> I experienced that, when the I2C clocks were correctly configured, the UART
> stopped working, likely due to their dependence on FOUTPOSTDIV.
> Setting up the UART correctly, for instance:
>
> uartx: serial@xxxxxxxxxx {
> ...
> clocks = <&clk CLK_UART_SCLK>, <&clk
> CLK_UARTX_PCLK>;
> clock-names = "baudclk", "apb_pclk";
> ...
> status = "disabled";
> };
> resolved the issue.
> As this would be mandatory in the future, I suggest that you configure all
> the nodes currently set to a fixed clock, not just the MMC controller.
Thank you for testing and discovering this issue.
Could you post your device tree so I can be sure I'm testing the same as
what you have?
Drew
WARNING: multiple messages have this Message-ID (diff)
From: Drew Fustini <dfustini@tenstorrent.com>
To: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
Cc: Jisheng Zhang <jszhang@kernel.org>, Guo Ren <guoren@kernel.org>,
Fu Wei <wefu@redhat.com>, Yangtao Li <frank.li@vivo.com>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH RFC v2 4/4] riscv: dts: thead: Add clock to TH1520 mmc controllers
Date: Thu, 2 May 2024 08:53:05 -0700 [thread overview]
Message-ID: <ZjO24XikkqNAnbti@x1> (raw)
In-Reply-To: <1444dac5-c725-4bf7-8843-469a62c3abf1@bootlin.com>
On Thu, May 02, 2024 at 09:47:43AM +0200, Thomas Bonnefille wrote:
>
>
> On 4/27/24 2:10 AM, Drew Fustini wrote:
> > Change the clock property in the T-Head TH1520 mmc controller nodes to a
> > real clock provided by the AP_SUBSYS clock driver.
> >
> > Signed-off-by: Drew Fustini <dfustini@tenstorrent.com>
>
> I experienced that, when the I2C clocks were correctly configured, the UART
> stopped working, likely due to their dependence on FOUTPOSTDIV.
> Setting up the UART correctly, for instance:
>
> uartx: serial@xxxxxxxxxx {
> ...
> clocks = <&clk CLK_UART_SCLK>, <&clk
> CLK_UARTX_PCLK>;
> clock-names = "baudclk", "apb_pclk";
> ...
> status = "disabled";
> };
> resolved the issue.
> As this would be mandatory in the future, I suggest that you configure all
> the nodes currently set to a fixed clock, not just the MMC controller.
Thank you for testing and discovering this issue.
Could you post your device tree so I can be sure I'm testing the same as
what you have?
Drew
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-05-02 15:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 0:10 [PATCH RFC v2 0/4] clk: thead: Add support for TH1520 AP_SUBSYS clock controller Drew Fustini
2024-04-27 0:10 ` Drew Fustini
2024-04-27 0:10 ` [PATCH RFC v2 1/4] dt-bindings: clock: Document T-Head TH1520 AP_SUBSYS controller Drew Fustini
2024-04-27 0:10 ` Drew Fustini
2024-04-29 5:10 ` Krzysztof Kozlowski
2024-04-29 5:10 ` Krzysztof Kozlowski
2024-04-27 0:10 ` [PATCH RFC v2 2/4] clk: thead: Add support for T-Head TH1520 AP_SUBSYS clocks Drew Fustini
2024-04-27 0:10 ` Drew Fustini
2024-05-02 7:47 ` Thomas Bonnefille
2024-05-02 7:47 ` Thomas Bonnefille
2024-04-27 0:10 ` [PATCH RFC v2 3/4] riscv: dts: thead: Add TH1520 AP_SUBSYS clock controller Drew Fustini
2024-04-27 0:10 ` Drew Fustini
2024-04-27 0:10 ` [PATCH RFC v2 4/4] riscv: dts: thead: Add clock to TH1520 mmc controllers Drew Fustini
2024-04-27 0:10 ` Drew Fustini
2024-05-02 7:47 ` Thomas Bonnefille
2024-05-02 7:47 ` Thomas Bonnefille
2024-05-02 15:53 ` Drew Fustini [this message]
2024-05-02 15:53 ` Drew Fustini
2024-05-03 6:58 ` Thomas Bonnefille
2024-05-03 6:58 ` Thomas Bonnefille
2024-05-02 7:47 ` [PATCH RFC v2 0/4] clk: thead: Add support for TH1520 AP_SUBSYS clock controller Thomas Bonnefille
2024-05-02 7:47 ` Thomas Bonnefille
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjO24XikkqNAnbti@x1 \
--to=dfustini@tenstorrent.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=frank.li@vivo.com \
--cc=guoren@kernel.org \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=thomas.bonnefille@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.