From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 2/3] drm/xe: Don't rely on xe_force_wake.h to be included elsewhere
Date: Tue, 7 May 2024 08:30:56 -0400 [thread overview]
Message-ID: <ZjofAG_98Vjv1mqZ@intel.com> (raw)
In-Reply-To: <20240507110959.2747-3-michal.wajdeczko@intel.com>
On Tue, May 07, 2024 at 01:09:58PM +0200, Michal Wajdeczko wrote:
> While xe_force_wake.h is now included from the xe_device.h, we
> want to drop that include as we don't need it there. Explicitly
> include xe_force_wake.h where needed.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 1 +
> drivers/gpu/drm/xe/xe_debugfs.c | 1 +
> drivers/gpu/drm/xe/xe_gsc.c | 1 +
> drivers/gpu/drm/xe/xe_gsc_proxy.c | 1 +
> drivers/gpu/drm/xe/xe_gt_idle.c | 1 +
> drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 1 +
> drivers/gpu/drm/xe/xe_guc_pc.c | 1 +
> drivers/gpu/drm/xe/xe_mmio.c | 1 +
> drivers/gpu/drm/xe/xe_mocs.c | 1 +
> drivers/gpu/drm/xe/xe_pat.c | 1 +
> drivers/gpu/drm/xe/xe_query.c | 1 +
> 11 files changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
> index d46f87a039f2..eb67ecf08db2 100644
> --- a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
> +++ b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
> @@ -13,6 +13,7 @@
> #include "xe_bo.h"
> #include "xe_device.h"
> #include "xe_device_types.h"
> +#include "xe_force_wake.h"
> #include "xe_gsc_proxy.h"
> #include "xe_gsc_submit.h"
> #include "xe_gt.h"
> diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c
> index 2c060a0d6251..1011e5d281fa 100644
> --- a/drivers/gpu/drm/xe/xe_debugfs.c
> +++ b/drivers/gpu/drm/xe/xe_debugfs.c
> @@ -12,6 +12,7 @@
>
> #include "xe_bo.h"
> #include "xe_device.h"
> +#include "xe_force_wake.h"
> #include "xe_gt_debugfs.h"
> #include "xe_gt_printk.h"
> #include "xe_guc_ads.h"
> diff --git a/drivers/gpu/drm/xe/xe_gsc.c b/drivers/gpu/drm/xe/xe_gsc.c
> index 60202b903687..8cc6420a9e7f 100644
> --- a/drivers/gpu/drm/xe/xe_gsc.c
> +++ b/drivers/gpu/drm/xe/xe_gsc.c
> @@ -14,6 +14,7 @@
> #include "xe_bo.h"
> #include "xe_device.h"
> #include "xe_exec_queue.h"
> +#include "xe_force_wake.h"
> #include "xe_gsc_proxy.h"
> #include "xe_gsc_submit.h"
> #include "xe_gt.h"
> diff --git a/drivers/gpu/drm/xe/xe_gsc_proxy.c b/drivers/gpu/drm/xe/xe_gsc_proxy.c
> index 1b908d238bd1..6d6d1068cf23 100644
> --- a/drivers/gpu/drm/xe/xe_gsc_proxy.c
> +++ b/drivers/gpu/drm/xe/xe_gsc_proxy.c
> @@ -15,6 +15,7 @@
> #include "abi/gsc_proxy_commands_abi.h"
> #include "regs/xe_gsc_regs.h"
> #include "xe_bo.h"
> +#include "xe_force_wake.h"
> #include "xe_gsc.h"
> #include "xe_gsc_submit.h"
> #include "xe_gt.h"
> diff --git a/drivers/gpu/drm/xe/xe_gt_idle.c b/drivers/gpu/drm/xe/xe_gt_idle.c
> index 8fc0f3f6ecc5..a4f6f0a96d05 100644
> --- a/drivers/gpu/drm/xe/xe_gt_idle.c
> +++ b/drivers/gpu/drm/xe/xe_gt_idle.c
> @@ -5,6 +5,7 @@
>
> #include <drm/drm_managed.h>
>
> +#include "xe_force_wake.h"
> #include "xe_device.h"
> #include "xe_gt.h"
> #include "xe_gt_idle.h"
> diff --git a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> index c3d015a7ac33..105797776a6c 100644
> --- a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> +++ b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> @@ -7,6 +7,7 @@
>
> #include "abi/guc_actions_abi.h"
> #include "xe_device.h"
> +#include "xe_force_wake.h"
> #include "xe_gt.h"
> #include "xe_gt_printk.h"
> #include "xe_guc.h"
> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
> index 8fc757900ed1..d10aab29651e 100644
> --- a/drivers/gpu/drm/xe/xe_guc_pc.c
> +++ b/drivers/gpu/drm/xe/xe_guc_pc.c
> @@ -15,6 +15,7 @@
> #include "regs/xe_regs.h"
> #include "xe_bo.h"
> #include "xe_device.h"
> +#include "xe_force_wake.h"
> #include "xe_gt.h"
> #include "xe_gt_idle.h"
> #include "xe_gt_sysfs.h"
> diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/drivers/gpu/drm/xe/xe_mmio.c
> index 2b18e8149ec3..05edab0e085d 100644
> --- a/drivers/gpu/drm/xe/xe_mmio.c
> +++ b/drivers/gpu/drm/xe/xe_mmio.c
> @@ -15,6 +15,7 @@
> #include "regs/xe_regs.h"
> #include "xe_bo.h"
> #include "xe_device.h"
> +#include "xe_force_wake.h"
> #include "xe_ggtt.h"
> #include "xe_gt.h"
> #include "xe_gt_mcr.h"
> diff --git a/drivers/gpu/drm/xe/xe_mocs.c b/drivers/gpu/drm/xe/xe_mocs.c
> index 4780708e5fae..f04754ad911b 100644
> --- a/drivers/gpu/drm/xe/xe_mocs.c
> +++ b/drivers/gpu/drm/xe/xe_mocs.c
> @@ -9,6 +9,7 @@
> #include "xe_bo.h"
> #include "xe_device.h"
> #include "xe_exec_queue.h"
> +#include "xe_force_wake.h"
> #include "xe_gt.h"
> #include "xe_gt_mcr.h"
> #include "xe_mmio.h"
> diff --git a/drivers/gpu/drm/xe/xe_pat.c b/drivers/gpu/drm/xe/xe_pat.c
> index d5b516f115ad..4ee32ee1cc88 100644
> --- a/drivers/gpu/drm/xe/xe_pat.c
> +++ b/drivers/gpu/drm/xe/xe_pat.c
> @@ -10,6 +10,7 @@
> #include "regs/xe_reg_defs.h"
> #include "xe_assert.h"
> #include "xe_device.h"
> +#include "xe_force_wake.h"
> #include "xe_gt.h"
> #include "xe_gt_mcr.h"
> #include "xe_mmio.h"
> diff --git a/drivers/gpu/drm/xe/xe_query.c b/drivers/gpu/drm/xe/xe_query.c
> index df407d73e5f5..29f847debb5c 100644
> --- a/drivers/gpu/drm/xe/xe_query.c
> +++ b/drivers/gpu/drm/xe/xe_query.c
> @@ -16,6 +16,7 @@
> #include "xe_bo.h"
> #include "xe_device.h"
> #include "xe_exec_queue.h"
> +#include "xe_force_wake.h"
> #include "xe_ggtt.h"
> #include "xe_gt.h"
> #include "xe_guc_hwconfig.h"
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-05-07 12:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 11:09 [PATCH 0/3] Fix xe_device.h Michal Wajdeczko
2024-05-07 11:09 ` [PATCH 1/3] drm/xe: Don't rely on xe_assert.h to be included elsewhere Michal Wajdeczko
2024-05-07 12:30 ` Rodrigo Vivi
2024-05-07 11:09 ` [PATCH 2/3] drm/xe: Don't rely on xe_force_wake.h " Michal Wajdeczko
2024-05-07 12:30 ` Rodrigo Vivi [this message]
2024-05-07 11:09 ` [PATCH 3/3] drm/xe: Fix xe_device.h Michal Wajdeczko
2024-05-07 12:31 ` Rodrigo Vivi
2024-05-07 11:46 ` ✓ CI.Patch_applied: success for " Patchwork
2024-05-07 11:46 ` ✓ CI.checkpatch: " Patchwork
2024-05-07 11:48 ` ✓ CI.KUnit: " Patchwork
2024-05-07 12:11 ` ✓ CI.Build: " Patchwork
2024-05-07 12:16 ` ✓ CI.Hooks: " Patchwork
2024-05-07 12:19 ` ✓ CI.checksparse: " Patchwork
2024-05-07 12:53 ` ✓ CI.BAT: " Patchwork
2024-05-07 17:12 ` ✗ CI.FULL: failure " Patchwork
2024-05-07 21:13 ` Michal Wajdeczko
2024-05-09 6:09 ` Balne, VinayX Kumar Goud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjofAG_98Vjv1mqZ@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.