Re: [PATCH 3/3] drm/xe: Fix xe_device.h

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, May 07, 2024 at 01:09:59PM +0200, Michal Wajdeczko wrote:
> Some explicit includes are needed only from the xe_device.c.
> And there is no need for redundant forward declarations.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_device.c | 2 ++
>  drivers/gpu/drm/xe/xe_device.h | 6 ------
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 05c28314b748..b63d98872a41 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -17,6 +17,7 @@
>  #include <drm/xe_drm.h>
>  
>  #include "display/xe_display.h"
> +#include "regs/xe_gpu_commands.h"
>  #include "regs/xe_gt_regs.h"
>  #include "regs/xe_regs.h"
>  #include "xe_bo.h"
> @@ -27,6 +28,7 @@
>  #include "xe_drv.h"
>  #include "xe_exec.h"
>  #include "xe_exec_queue.h"
> +#include "xe_force_wake.h"
>  #include "xe_ggtt.h"
>  #include "xe_gsc_proxy.h"
>  #include "xe_gt.h"
> diff --git a/drivers/gpu/drm/xe/xe_device.h b/drivers/gpu/drm/xe/xe_device.h
> index 0940ade6a352..bb07f5669dbb 100644
> --- a/drivers/gpu/drm/xe/xe_device.h
> +++ b/drivers/gpu/drm/xe/xe_device.h
> @@ -6,15 +6,9 @@
>  #ifndef _XE_DEVICE_H_
>  #define _XE_DEVICE_H_
>  
> -struct xe_exec_queue;
> -struct xe_file;
> -
>  #include <drm/drm_util.h>
>  
> -#include "regs/xe_gpu_commands.h"
>  #include "xe_device_types.h"
> -#include "xe_force_wake.h"
> -#include "xe_macros.h"
>  
>  static inline struct xe_device *to_xe_device(const struct drm_device *dev)
>  {
> -- 
> 2.43.0
>