From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
jolsa@kernel.org, adrian.hunter@intel.com, irogers@google.com,
segher@kernel.crashing.org, christophe.leroy@csgroup.eu,
linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
maddy@linux.ibm.com, kjain@linux.ibm.com,
disgoel@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
akanksha@linux.ibm.com
Subject: Re: [PATCH V2 3/9] tools/perf: Fix a comment about multi_regs in extract_reg_offset function
Date: Tue, 7 May 2024 11:52:57 -0300 [thread overview]
Message-ID: <ZjpASVk1GezAzDAG@x1> (raw)
In-Reply-To: <CAM9d7ciKUQErzu1Y7FnWCryW15xUkyJLSt-Jez9h8TYgp-tLjw@mail.gmail.com>
On Mon, May 06, 2024 at 09:40:15PM -0700, Namhyung Kim wrote:
> On Mon, May 6, 2024 at 5:19 AM Athira Rajeev
> <atrajeev@linux.vnet.ibm.com> wrote:
> >
> > Fix a comment in function which explains how multi_regs field gets set
> > for an instruction. In the example, "mov %rsi, 8(%rbx,%rcx,4)", the
> > comment mistakenly referred to "dst_multi_regs = 0". Correct it to use
> > "src_multi_regs = 0"
> >
> > Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
Cherry picked this one into perf-tools-next.
Thanks,
- Arnaldo
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: irogers@google.com, Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
kjain@linux.ibm.com, adrian.hunter@intel.com,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
maddy@linux.ibm.com, jolsa@kernel.org, akanksha@linux.ibm.com,
disgoel@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V2 3/9] tools/perf: Fix a comment about multi_regs in extract_reg_offset function
Date: Tue, 7 May 2024 11:52:57 -0300 [thread overview]
Message-ID: <ZjpASVk1GezAzDAG@x1> (raw)
In-Reply-To: <CAM9d7ciKUQErzu1Y7FnWCryW15xUkyJLSt-Jez9h8TYgp-tLjw@mail.gmail.com>
On Mon, May 06, 2024 at 09:40:15PM -0700, Namhyung Kim wrote:
> On Mon, May 6, 2024 at 5:19 AM Athira Rajeev
> <atrajeev@linux.vnet.ibm.com> wrote:
> >
> > Fix a comment in function which explains how multi_regs field gets set
> > for an instruction. In the example, "mov %rsi, 8(%rbx,%rcx,4)", the
> > comment mistakenly referred to "dst_multi_regs = 0". Correct it to use
> > "src_multi_regs = 0"
> >
> > Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
Cherry picked this one into perf-tools-next.
Thanks,
- Arnaldo
next prev parent reply other threads:[~2024-05-07 14:53 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 12:18 [PATCH V2 0/9] Add data type profiling support for powerpc Athira Rajeev
2024-05-06 12:18 ` Athira Rajeev
2024-05-06 12:18 ` [PATCH V2 1/9] tools/perf: Move the data structures related to register type to header file Athira Rajeev
2024-05-06 12:18 ` Athira Rajeev
2024-05-06 12:18 ` [PATCH V2 2/9] tools/perf: Add "update_insn_state" callback function to handle arch specific instruction tracking Athira Rajeev
2024-05-06 12:18 ` Athira Rajeev
2024-05-06 12:19 ` [PATCH V2 3/9] tools/perf: Fix a comment about multi_regs in extract_reg_offset function Athira Rajeev
2024-05-06 12:19 ` Athira Rajeev
2024-05-07 4:40 ` Namhyung Kim
2024-05-07 4:40 ` Namhyung Kim
2024-05-07 14:52 ` Arnaldo Carvalho de Melo [this message]
2024-05-07 14:52 ` Arnaldo Carvalho de Melo
2024-05-06 12:19 ` [PATCH V2 4/9] tools/perf: Add support to capture and parse raw instruction in objdump Athira Rajeev
2024-05-06 12:19 ` Athira Rajeev
2024-05-07 4:57 ` Namhyung Kim
2024-05-07 4:57 ` Namhyung Kim
2024-05-07 9:35 ` Christophe Leroy
2024-05-07 9:35 ` Christophe Leroy
2024-05-09 17:26 ` Athira Rajeev
2024-05-09 17:26 ` Athira Rajeev
2024-05-09 20:55 ` Namhyung Kim
2024-05-09 20:55 ` Namhyung Kim
2024-05-10 14:26 ` Arnaldo Carvalho de Melo
2024-05-10 14:26 ` Arnaldo Carvalho de Melo
2024-05-22 13:58 ` Athira Rajeev
2024-05-22 13:58 ` Athira Rajeev
2024-05-06 12:19 ` [PATCH V2 5/9] tools/perf: Update parameters for reg extract functions to use raw instruction on powerpc Athira Rajeev
2024-05-06 12:19 ` Athira Rajeev
2024-05-07 9:48 ` Christophe Leroy
2024-05-07 9:48 ` Christophe Leroy
2024-05-22 14:06 ` Athira Rajeev
2024-05-22 14:06 ` Athira Rajeev
2024-05-06 12:19 ` [PATCH V2 6/9] tools/perf: Update instruction tracking for powerpc Athira Rajeev
2024-05-06 12:19 ` Athira Rajeev
2024-05-07 9:52 ` Christophe Leroy
2024-05-07 9:52 ` Christophe Leroy
2024-05-23 13:58 ` Athira Rajeev
2024-05-23 13:58 ` Athira Rajeev
2024-05-06 12:19 ` [PATCH V2 7/9] tools/perf: Update instruction tracking with add instruction Athira Rajeev
2024-05-06 12:19 ` Athira Rajeev
2024-05-07 9:58 ` Christophe Leroy
2024-05-07 9:58 ` Christophe Leroy
2024-05-23 13:55 ` Athira Rajeev
2024-05-23 13:55 ` Athira Rajeev
2024-05-06 12:19 ` [PATCH V2 8/9] tools/perf: Add support to find global register variables using find_data_type_global_reg Athira Rajeev
2024-05-06 12:19 ` Athira Rajeev
2024-05-07 10:03 ` Christophe Leroy
2024-05-07 10:03 ` Christophe Leroy
2024-05-24 12:17 ` Athira Rajeev
2024-05-24 12:17 ` Athira Rajeev
2024-05-24 12:47 ` Christophe Leroy
2024-05-24 12:47 ` Christophe Leroy
2024-05-06 12:19 ` [PATCH V2 9/9] tools/perf: Add support for global_die to capture name of variable in case of register defined variable Athira Rajeev
2024-05-06 12:19 ` Athira Rajeev
2024-05-07 4:39 ` [PATCH V2 0/9] Add data type profiling support for powerpc Namhyung Kim
2024-05-07 4:39 ` Namhyung Kim
2024-05-13 7:32 ` Athira Rajeev
2024-05-13 7:32 ` Athira Rajeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjpASVk1GezAzDAG@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=akanksha@linux.ibm.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=disgoel@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=namhyung@kernel.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.