Re: [PATCH] clkdev: fix potential NULL pointer dereference

From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "André Draszik" <andre.draszik@linaro.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH] clkdev: fix potential NULL pointer dereference
Date: Tue, 7 May 2024 18:58:16 +0100	[thread overview]
Message-ID: <ZjpruBO7iwcrz5ru@shell.armlinux.org.uk> (raw)
In-Reply-To: <e4ad92b88556f0de05b6b7ae03da1e581d688ce5.camel@linaro.org>

On Tue, May 07, 2024 at 05:42:45PM +0100, André Draszik wrote:
> Hi Marek,
> 
> On Tue, 2024-05-07 at 08:44 +0200, Marek Szyprowski wrote:
> > diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
> > index ddacab7863d0..d2801ae70e34 100644
> > --- a/drivers/clk/clkdev.c
> > +++ b/drivers/clk/clkdev.c
> > @@ -194,10 +194,12 @@ vclkdev_alloc(struct clk_hw *hw, const char *con_id, const char *dev_fmt,
> >  	return &cla->cl;
> >  
> >  fail:
> > -	fmt.fmt = dev_fmt;
> > -	fmt.va = &ap_copy;
> > -	pr_err("%pV:%s: %s ID is greater than %zu\n",
> > -	       &fmt, con_id, failure, max_size);
> > +	if (dev_fmt) {
> > +		fmt.fmt = dev_fmt;
> > +		fmt.va = &ap_copy;
> > +		pr_err("%pV:%s: %s ID is greater than %zu\n",
> > +		       &fmt, con_id, failure, max_size);
> > +	}
> 
> It might be nice to still print the rest of the error, so it's easier to see which
> clock is causing trouble.

Good point. I'll fix the patch myself, merging the fix in.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!