All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Cristian Marussi <cristian.marussi@arm.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Aisheng Dong <aisheng.dong@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v5 0/3] pinctrl: scmi: support i.MX95 OEM extensions
Date: Wed, 8 May 2024 13:22:12 +0100	[thread overview]
Message-ID: <ZjtudPS1CUqCJU5v@bogus> (raw)
In-Reply-To: <DU0PR04MB94170BB9A2C41DE40C8F575288E52@DU0PR04MB9417.eurprd04.prod.outlook.com>

On Wed, May 08, 2024 at 09:41:24AM +0000, Peng Fan wrote:
> Hi Sudeep,
>
> > Subject: Re: [PATCH v5 0/3] pinctrl: scmi: support i.MX95 OEM extensions
> >
> > On Wed, May 08, 2024 at 11:32:01AM +0800, Peng Fan (OSS) wrote:
> > > ARM SCMI v3.2 Table 24 Pin Configuration Type and Enumerations:
> > > '192 -255 OEM specific units'.
> > >
> > > i.MX95 System Manager FW supports SCMI PINCTRL protocol, but it has
> > > zero functions, groups. So pinctrl-scmi.c could not be reused for i.MX95.
> > > Because nxp,pin-func, nxp,pin-conf properties are rejected by dt
> > > maintainers, so use generic property 'pinmux' which requires a new
> > > driver pinctrl-imx-scmi.c
> > >
> >
> > Not a review in particular, but if we decide to merge this deviation, it must be
> > under the condition that it can be deleted anytime in the future if this
> > becomes annoyance(like other vendors using this as a way to deviate from
> > the specification). If we can't agree with that, then we better not merge this
> > at all.
>
> It is ok for me. I agree.
> But actually this driver still follows Spec by using OEM extensions.
>

Agreed, but that's what I call as deviations. When such extensions are
used as baseline implementation, it becomes deviations.

--
Regards,
Sudeep

WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Cristian Marussi <cristian.marussi@arm.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Aisheng Dong <aisheng.dong@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v5 0/3] pinctrl: scmi: support i.MX95 OEM extensions
Date: Wed, 8 May 2024 13:22:12 +0100	[thread overview]
Message-ID: <ZjtudPS1CUqCJU5v@bogus> (raw)
In-Reply-To: <DU0PR04MB94170BB9A2C41DE40C8F575288E52@DU0PR04MB9417.eurprd04.prod.outlook.com>

On Wed, May 08, 2024 at 09:41:24AM +0000, Peng Fan wrote:
> Hi Sudeep,
>
> > Subject: Re: [PATCH v5 0/3] pinctrl: scmi: support i.MX95 OEM extensions
> >
> > On Wed, May 08, 2024 at 11:32:01AM +0800, Peng Fan (OSS) wrote:
> > > ARM SCMI v3.2 Table 24 Pin Configuration Type and Enumerations:
> > > '192 -255 OEM specific units'.
> > >
> > > i.MX95 System Manager FW supports SCMI PINCTRL protocol, but it has
> > > zero functions, groups. So pinctrl-scmi.c could not be reused for i.MX95.
> > > Because nxp,pin-func, nxp,pin-conf properties are rejected by dt
> > > maintainers, so use generic property 'pinmux' which requires a new
> > > driver pinctrl-imx-scmi.c
> > >
> >
> > Not a review in particular, but if we decide to merge this deviation, it must be
> > under the condition that it can be deleted anytime in the future if this
> > becomes annoyance(like other vendors using this as a way to deviate from
> > the specification). If we can't agree with that, then we better not merge this
> > at all.
>
> It is ok for me. I agree.
> But actually this driver still follows Spec by using OEM extensions.
>

Agreed, but that's what I call as deviations. When such extensions are
used as baseline implementation, it becomes deviations.

--
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-05-08 12:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08  3:32 [PATCH v5 0/3] pinctrl: scmi: support i.MX95 OEM extensions Peng Fan (OSS)
2024-05-08  3:32 ` Peng Fan (OSS)
2024-05-08  3:32 ` [PATCH v5 1/3] dt-bindings: firmware: arm,scmi: Add properties for i.MX95 Pinctrl " Peng Fan (OSS)
2024-05-08  3:32   ` Peng Fan (OSS)
2024-05-08  3:32 ` [PATCH v5 2/3] pinctrl: scmi: add blocklist Peng Fan (OSS)
2024-05-08  3:32   ` Peng Fan (OSS)
2024-05-08  3:32 ` [PATCH v5 3/3] pinctrl: imx: support SCMI pinctrl protocol for i.MX95 Peng Fan (OSS)
2024-05-08  3:32   ` Peng Fan (OSS)
2024-05-08  9:12 ` [PATCH v5 0/3] pinctrl: scmi: support i.MX95 OEM extensions Sudeep Holla
2024-05-08  9:12   ` Sudeep Holla
2024-05-08  9:41   ` Peng Fan
2024-05-08  9:41     ` Peng Fan
2024-05-08 12:22     ` Sudeep Holla [this message]
2024-05-08 12:22       ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZjtudPS1CUqCJU5v@bogus \
    --to=sudeep.holla@arm.com \
    --cc=aisheng.dong@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=cristian.marussi@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.