All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicolinc@nvidia.com>
To: <joro@8bytes.org>, Robin Murphy <robin.murphy@arm.com>
Cc: <will@kernel.org>, <catalin.marinas@arm.com>,
	<linux-arm-kernel@lists.infradead.org>, <iommu@lists.linux.dev>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH] arm64: Properly clean up iommu-dma remnants
Date: Thu, 9 May 2024 02:04:18 -0700	[thread overview]
Message-ID: <ZjyRks2BPeGg0wMD@nvidia.com> (raw)
In-Reply-To: <d4cc20cbb0c45175e98dd76bf187e2ad6421296d.1714472573.git.robin.murphy@arm.com>

On Tue, Apr 30, 2024 at 11:22:53AM +0100, Robin Murphy wrote:
> Thanks to the somewhat asymmetrical nature, while removing
> iommu_setup_dma_ops() from the arch_setup_dma_ops() flow, I managed to
> forget that arm64's teardown path was also specific to iommu-dma. Clean
> that up to match, otherwise probe deferral will lead to the arch code
> erroneously removing DMA ops set elsewhere.
> 
> Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Link: https://lore.kernel.org/linux-iommu/Zi_LV28TR-P-PzXi@eriador.lumag.spb.ru/
> Fixes: b67483b3c44e ("iommu/dma: Centralise iommu_setup_dma_ops()")
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>

This fixes the breakage occurring to my system too. Thanks!

Tested-by: Nicolin Chen <nicolinc@nvidia.com>

WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicolinc@nvidia.com>
To: <joro@8bytes.org>, Robin Murphy <robin.murphy@arm.com>
Cc: <will@kernel.org>, <catalin.marinas@arm.com>,
	<linux-arm-kernel@lists.infradead.org>, <iommu@lists.linux.dev>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH] arm64: Properly clean up iommu-dma remnants
Date: Thu, 9 May 2024 02:04:18 -0700	[thread overview]
Message-ID: <ZjyRks2BPeGg0wMD@nvidia.com> (raw)
In-Reply-To: <d4cc20cbb0c45175e98dd76bf187e2ad6421296d.1714472573.git.robin.murphy@arm.com>

On Tue, Apr 30, 2024 at 11:22:53AM +0100, Robin Murphy wrote:
> Thanks to the somewhat asymmetrical nature, while removing
> iommu_setup_dma_ops() from the arch_setup_dma_ops() flow, I managed to
> forget that arm64's teardown path was also specific to iommu-dma. Clean
> that up to match, otherwise probe deferral will lead to the arch code
> erroneously removing DMA ops set elsewhere.
> 
> Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Link: https://lore.kernel.org/linux-iommu/Zi_LV28TR-P-PzXi@eriador.lumag.spb.ru/
> Fixes: b67483b3c44e ("iommu/dma: Centralise iommu_setup_dma_ops()")
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>

This fixes the breakage occurring to my system too. Thanks!

Tested-by: Nicolin Chen <nicolinc@nvidia.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-05-09  9:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 10:22 [PATCH] arm64: Properly clean up iommu-dma remnants Robin Murphy
2024-04-30 10:22 ` Robin Murphy
2024-04-30 10:32 ` Dmitry Baryshkov
2024-04-30 10:32   ` Dmitry Baryshkov
2024-04-30 11:00   ` Robin Murphy
2024-04-30 11:00     ` Robin Murphy
2024-04-30 11:22 ` Catalin Marinas
2024-04-30 11:22   ` Catalin Marinas
2024-04-30 12:51 ` Konrad Dybcio
2024-04-30 12:51   ` Konrad Dybcio
2024-05-04 14:21 ` Dmitry Baryshkov
2024-05-04 14:21   ` Dmitry Baryshkov
2024-05-07  9:50   ` Will Deacon
2024-05-07  9:50     ` Will Deacon
2024-05-09  9:04 ` Nicolin Chen [this message]
2024-05-09  9:04   ` Nicolin Chen
2024-05-10  7:04 ` Joerg Roedel
2024-05-10  7:04   ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZjyRks2BPeGg0wMD@nvidia.com \
    --to=nicolinc@nvidia.com \
    --cc=catalin.marinas@arm.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.