* [PATCH] Input: chipone_icn8505 - remove an unused field in struct icn8505_data
@ 2024-05-12 8:25 Christophe JAILLET
2024-05-12 13:55 ` Hans de Goede
2024-05-13 21:24 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2024-05-12 8:25 UTC (permalink / raw)
To: Hans de Goede, Dmitry Torokhov
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-input
In "struct icn8505_data", the 'wake_gpio' field is unused.
There is also nothing about gpio neither in this driver nor in the
data-sheet.
So, remove it.
Found with cppcheck, unusedStructMember.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only.
It was added in the initial commit e7330fa032bb ("Input: add support for
ChipOne icn8505 based touchscreens") but was never used.
---
drivers/input/touchscreen/chipone_icn8505.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/touchscreen/chipone_icn8505.c b/drivers/input/touchscreen/chipone_icn8505.c
index b56954830b33..c1b4fc28fa8d 100644
--- a/drivers/input/touchscreen/chipone_icn8505.c
+++ b/drivers/input/touchscreen/chipone_icn8505.c
@@ -68,7 +68,6 @@ struct icn8505_touch_data {
struct icn8505_data {
struct i2c_client *client;
struct input_dev *input;
- struct gpio_desc *wake_gpio;
struct touchscreen_properties prop;
char firmware_name[32];
};
--
2.45.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Input: chipone_icn8505 - remove an unused field in struct icn8505_data
2024-05-12 8:25 [PATCH] Input: chipone_icn8505 - remove an unused field in struct icn8505_data Christophe JAILLET
@ 2024-05-12 13:55 ` Hans de Goede
2024-05-13 21:24 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2024-05-12 13:55 UTC (permalink / raw)
To: Christophe JAILLET, Dmitry Torokhov
Cc: linux-kernel, kernel-janitors, linux-input
Hi,
On 5/12/24 10:25 AM, Christophe JAILLET wrote:
> In "struct icn8505_data", the 'wake_gpio' field is unused.
> There is also nothing about gpio neither in this driver nor in the
> data-sheet.
>
> So, remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> Compile tested only.
>
> It was added in the initial commit e7330fa032bb ("Input: add support for
> ChipOne icn8505 based touchscreens") but was never used.
> ---
> drivers/input/touchscreen/chipone_icn8505.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/chipone_icn8505.c b/drivers/input/touchscreen/chipone_icn8505.c
> index b56954830b33..c1b4fc28fa8d 100644
> --- a/drivers/input/touchscreen/chipone_icn8505.c
> +++ b/drivers/input/touchscreen/chipone_icn8505.c
> @@ -68,7 +68,6 @@ struct icn8505_touch_data {
> struct icn8505_data {
> struct i2c_client *client;
> struct input_dev *input;
> - struct gpio_desc *wake_gpio;
> struct touchscreen_properties prop;
> char firmware_name[32];
> };
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Input: chipone_icn8505 - remove an unused field in struct icn8505_data
2024-05-12 8:25 [PATCH] Input: chipone_icn8505 - remove an unused field in struct icn8505_data Christophe JAILLET
2024-05-12 13:55 ` Hans de Goede
@ 2024-05-13 21:24 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2024-05-13 21:24 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Hans de Goede, linux-kernel, kernel-janitors, linux-input
On Sun, May 12, 2024 at 10:25:17AM +0200, Christophe JAILLET wrote:
> In "struct icn8505_data", the 'wake_gpio' field is unused.
> There is also nothing about gpio neither in this driver nor in the
> data-sheet.
>
> So, remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-13 21:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-12 8:25 [PATCH] Input: chipone_icn8505 - remove an unused field in struct icn8505_data Christophe JAILLET
2024-05-12 13:55 ` Hans de Goede
2024-05-13 21:24 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.