Re: [PATCH net-next v2 5/5] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988

From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "SkyLake Huang (黃啟澤)" <SkyLake.Huang@mediatek.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"edumazet@google.com" <edumazet@google.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"dqfext@gmail.com" <dqfext@gmail.com>,
	"Steven Liu (劉人豪)" <steven.liu@mediatek.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
	"daniel@makrotopia.org" <daniel@makrotopia.org>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH net-next v2 5/5] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988
Date: Mon, 20 May 2024 18:48:36 +0100	[thread overview]
Message-ID: <ZkuM9C0Yd/uwwzUA@shell.armlinux.org.uk> (raw)
In-Reply-To: <8a5f14f4-4cd9-48b5-a62c-711800cee942@lunn.ch>

On Mon, May 20, 2024 at 03:02:21PM +0200, Andrew Lunn wrote:
> > Actually this phy is strictly binded to (XFI)MAC on this platform.
> > So I directly disable HDX feature of PHY.
> 
> Sorry, i don't follow your answer:
> 
> Can the PHY do half duplex?
> Can the MAC do half duplex?
> 
> The part which cannot do half-duplex should be the part which disables
> half-duplex.

Note that if the PHY is doing rate adaption (preferably in a form that
it can control the MAC transmission rate), then even if the MAC can't
do half-duplex, the PHY can still do half-duplex.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!