Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()

From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Corey Minyard" <minyard@acm.org>,
	"Allen Pais" <apais@linux.microsoft.com>,
	"Sebastian Reichel" <sebastian.reichel@collabora.com>,
	"Perry Yuan" <perry.yuan@amd.com>,
	"Giovanni Cabiddu" <giovanni.cabiddu@intel.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Nuno Sa" <nuno.sa@analog.com>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Andi Shyti" <andi.shyti@kernel.org>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Lee Jones" <lee@kernel.org>,
	"Samuel Holland" <samuel@sholland.org>,
	"Elad Nachman" <enachman@marvell.com>,
	"Arseniy Krasnov" <AVKrasnov@sberdevices.ru>,
	"Johannes Berg" <johannes.berg@intel.com>,
	"Gregory Greenman" <gregory.greenman@intel.com>,
	"Benjamin Berg" <benjamin.berg@intel.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Robert Richter" <rrichter@amd.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Chunfeng Yun" <chunfeng.yun@mediatek.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Nikita Kravets" <teackot@gmail.com>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
	"Stanley Chang" <stanley_chang@realtek.com>,
	"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
	"Abdel Alkuor" <abdelalkuor@geotab.com>,
	"Kent Overstreet" <kent.overstreet@linux.dev>,
	"Eric Biggers" <ebiggers@google.com>,
	"Kees Cook" <keescook@chromium.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Steven Rostedt (Google)" <rostedt@goodmis.org>,
	"Daniel Bristot de Oliveira" <bristot@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Hugh Dickins" <hughd@google.com>,
	"Abel Wu" <wuyun.abel@bytedance.com>,
	"John Johansen" <john.johansen@canonical.com>,
	"Mimi Zohar" <zohar@linux.ibm.com>,
	"Stefan Berger" <stefanb@linux.ibm.com>,
	"Roberto Sassu" <roberto.sassu@huawei.com>,
	"Eric Snowberg" <eric.snowberg@oracle.com>,
	"Takashi Iwai" <tiwai@suse.de>,
	"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
	"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-acpi@vger.kernel.org, linux-ide@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org, qat-linux@intel.com,
	dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	linux-hwmon@vger.kernel.org, linux-i2c@vger.kernel.org,
	linux-leds@vger.kernel.org, linux-sunxi@lists.linux.dev,
	linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-usb@vger.kernel.org,
	linux-fbdev@vger.kernel.org, linux-bcachefs@vger.kernel.org,
	linux-hardening@vger.kernel.org, cgroups@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org,
	apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org,
	linux-integrity@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-sound@vger.kernel.org,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Christophe Leroy" <christophe.leroy@csgroup.eu>,
	"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	"David Howells" <dhowells@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Len Brown" <lenb@kernel.org>,
	"Sergey Shtylyov" <s.shtylyov@omp.ru>,
	"Damien Le Moal" <dlemoal@kernel.org>,
	"Niklas Cassel" <cassel@kernel.org>,
	"Daniel Scally" <djrscally@gmail.com>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Ray Jui" <rjui@broadcom.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Peter De Schrijver" <pdeschrijver@nvidia.com>,
	"Prashant Gaikwad" <pgaikwad@nvidia.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Huang Rui" <ray.huang@amd.com>,
	"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Tvrtko Ursulin" <tursulin@ursulin.net>,
	"Karol Herbst" <kherbst@redhat.com>,
	"Lyude Paul" <lyude@redhat.com>,
	"Danilo Krummrich" <dakr@redhat.com>,
	"Jean Delvare" <jdelvare@suse.com>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	"Pavel Machek" <pavel@ucw.cz>, "Chen-Yu Tsai" <wens@csie.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	"Hu Ziji" <huziji@marvell.com>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Potnuri Bharat Teja" <bharat@chelsio.com>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Miri Korenblit" <miriam.rachel.korenblit@intel.com>,
	"Kalle Valo" <kvalo@kernel.org>,
	"Mahesh J Salgaonkar" <mahesh@linux.ibm.com>,
	"Oliver O'Halloran" <oohall@gmail.com>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"JC Kuo" <jckuo@nvidia.com>, "Andrew Lunn" <andrew@lunn.ch>,
	"Gregory Clement" <gregory.clement@bootlin.com>,
	"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Zhang Rui" <rui.zhang@intel.com>,
	"Lukasz Luba" <lukasz.luba@arm.com>,
	"Thinh Nguyen" <Thinh.Nguyen@synopsys.com>,
	"Helge Deller" <deller@gmx.de>,
	"Brian Foster" <bfoster@redhat.com>,
	"Zhihao Cheng" <chengzhihao1@huawei.com>,
	"Tejun Heo" <tj@kernel.org>, "Zefan Li" <lizefan.x@bytedance.com>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Juri Lelli" <juri.lelli@redhat.com>,
	"Vincent Guittot" <vincent.guittot@linaro.org>,
	"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
	"Ben Segall" <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
	"Daniel Bristot de Oliveira" <bristot@redhat.com>,
	"Valentin Schneider" <vschneid@redhat.com>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
	"Jason Baron" <jbaron@akamai.com>,
	"Jim Cromie" <jim.cromie@gmail.com>,
	"Paul Moore" <paul@paul-moore.com>,
	"James Morris" <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	"Dmitry Kasatkin" <dmitry.kasatkin@gmail.com>,
	"Clemens Ladisch" <clemens@ladisch.de>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()
Date: Tue, 4 Jun 2024 08:23:48 +0000	[thread overview]
Message-ID: <Zl7PFGprypdZi6ql@kekkonen.localdomain> (raw)
In-Reply-To: <20240603211538.289765-1-andriy.shevchenko@linux.intel.com>

Hi Andy,

On Sun, Jun 02, 2024 at 06:57:12PM +0300, Andy Shevchenko wrote:
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index 503773707e01..9cb350de30f0 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -798,7 +798,7 @@ static bool acpi_info_matches_ids(struct acpi_device_info *info,
>  	if (!(info->valid & ACPI_VALID_HID))
>  		return false;
>  
> -	index = match_string(ids, -1, info->hardware_id.string);
> +	index = __match_string(ids, -1, info->hardware_id.string);
>  	if (index >= 0)
>  		return true;
>  
> @@ -809,7 +809,7 @@ static bool acpi_info_matches_ids(struct acpi_device_info *info,
>  		return false;
>  
>  	for (i = 0; i < cid_list->count; i++) {
> -		index = match_string(ids, -1, cid_list->ids[i].string);
> +		index = __match_string(ids, -1, cid_list->ids[i].string);
>  		if (index >= 0)
>  			return true;
>  	}

Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com> # drivers/acpi

-- 
Sakari Ailus