[PATCH 0/2] Fix alignment in comment blocks

[PATCH 0/2] Fix alignment in comment blocks

[Bruno Rocha Levi]

Hi!

This patchset fixes two alignment issues in comment blocks throughout
the codebase. These changes fix codestyle warnings reported from
checkpatch and are intended to improve code readability.

Thanks,

Bruno Rocha Levi (2):
  drm/vkms: Fix misalignment in comment block
  drivers/gpu: Fix misalignment in comment block

 drivers/gpu/drm/amd/acp/include/acp_gfx_if.h | 2 +-
 drivers/gpu/drm/vkms/vkms_drv.c              | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

-- 
2.45.1

[PATCH 1/2] drm/vkms: Fix misalignment in comment block

[Bruno Rocha Levi]

From: Bruno Rocha Levi <brunolevilevi@gmail.com>

This change fixes a warning from checkpatch, it improves readability of a
comment that was previously misaligned, by ensuring the trailing */ is on
the same line as the opening /*.

Co-developed-by: Lucas Antonio <lucasantonio.santos@usp.br>
Signed-off-by: Lucas Antonio <lucasantonio.santos@usp.br>
Signed-off-by: Bruno Rocha Levi <brunolevilevi@usp.br>
---
 drivers/gpu/drm/vkms/vkms_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index dd0af086e..e8612759a 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -166,7 +166,8 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
 	dev->mode_config.cursor_height = 512;
 	/* FIXME: There's a confusion between bpp and depth between this and
 	 * fbdev helpers. We have to go with 0, meaning "pick the default",
-	 * which ix XRGB8888 in all cases. */
+	 * which ix XRGB8888 in all cases.
+	 */
 	dev->mode_config.preferred_depth = 0;
 	dev->mode_config.helper_private = &vkms_mode_config_helpers;
 
-- 
2.45.1

Re: [PATCH 1/2] drm/vkms: Fix misalignment in comment block

[Louis Chauvet]

Le 28/05/24 - 10:08, Bruno Rocha Levi a écrit :
> From: Bruno Rocha Levi <brunolevilevi@gmail.com>
> 
> This change fixes a warning from checkpatch, it improves readability of a
> comment that was previously misaligned, by ensuring the trailing */ is on
> the same line as the opening /*.

Hi,

Do you mean same column?

Maybe in the same patch, also add the missing first empty line in the 
comment [1]:

	/*
	 * FIXME: [...]
	 */

https://www.kernel.org/doc/html/latest/process/coding-style.html#commenting

Thanks,
Louis Chauvet
 
> Co-developed-by: Lucas Antonio <lucasantonio.santos@usp.br>
> Signed-off-by: Lucas Antonio <lucasantonio.santos@usp.br>
> Signed-off-by: Bruno Rocha Levi <brunolevilevi@usp.br>
> ---
>  drivers/gpu/drm/vkms/vkms_drv.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index dd0af086e..e8612759a 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -166,7 +166,8 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
>  	dev->mode_config.cursor_height = 512;
>  	/* FIXME: There's a confusion between bpp and depth between this and
>  	 * fbdev helpers. We have to go with 0, meaning "pick the default",
> -	 * which ix XRGB8888 in all cases. */
> +	 * which ix XRGB8888 in all cases.
> +	 */
>  	dev->mode_config.preferred_depth = 0;
>  	dev->mode_config.helper_private = &vkms_mode_config_helpers;
>  
> -- 
> 2.45.1
> 

-- 
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[PATCH 2/2] drivers/gpu: Fix misalignment in comment block

[Bruno Rocha Levi]

This patch fixes a warning from checkpatch by ensuring the trailing */ is
aligned with the rest of the *, improving readability.

Co-developed-by: Lucas Antonio <lucasantonio.santos@usp.br>
Signed-off-by: Lucas Antonio <lucasantonio.santos@usp.br>
Signed-off-by: Bruno Rocha Levi <brunolevilevi@usp.br>
---
 drivers/gpu/drm/amd/acp/include/acp_gfx_if.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/acp/include/acp_gfx_if.h b/drivers/gpu/drm/amd/acp/include/acp_gfx_if.h
index feab8eb7f..b26710cae 100644
--- a/drivers/gpu/drm/amd/acp/include/acp_gfx_if.h
+++ b/drivers/gpu/drm/amd/acp/include/acp_gfx_if.h
@@ -19,7 +19,7 @@
  * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
  * OTHER DEALINGS IN THE SOFTWARE.
  *
-*/
+ */
 
 #ifndef _ACP_GFX_IF_H
 #define _ACP_GFX_IF_H
-- 
2.45.1

Re: [PATCH 2/2] drivers/gpu: Fix misalignment in comment block

[Alex Deucher]

Applied.  Thanks!

Alex

On Tue, May 28, 2024 at 10:47 AM Bruno Rocha Levi <brunolevilevi@usp.br> wrote:
>
> This patch fixes a warning from checkpatch by ensuring the trailing */ is
> aligned with the rest of the *, improving readability.
>
> Co-developed-by: Lucas Antonio <lucasantonio.santos@usp.br>
> Signed-off-by: Lucas Antonio <lucasantonio.santos@usp.br>
> Signed-off-by: Bruno Rocha Levi <brunolevilevi@usp.br>
> ---
>  drivers/gpu/drm/amd/acp/include/acp_gfx_if.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/acp/include/acp_gfx_if.h b/drivers/gpu/drm/amd/acp/include/acp_gfx_if.h
> index feab8eb7f..b26710cae 100644
> --- a/drivers/gpu/drm/amd/acp/include/acp_gfx_if.h
> +++ b/drivers/gpu/drm/amd/acp/include/acp_gfx_if.h
> @@ -19,7 +19,7 @@
>   * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>   * OTHER DEALINGS IN THE SOFTWARE.
>   *
> -*/
> + */
>
>  #ifndef _ACP_GFX_IF_H
>  #define _ACP_GFX_IF_H
> --
> 2.45.1
>