From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: xiaolei wang <xiaolei.wang@windriver.com>
Cc: alexandre.torgue@foss.st.com, joabreu@synopsys.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, mcoquelin.stm32@gmail.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [net PATCH] net: stmmac: update priv->speed to SPEED_UNKNOWN when link down
Date: Wed, 29 May 2024 12:45:38 +0100 [thread overview]
Message-ID: <ZlcVYjOEBGm79Yc9@shell.armlinux.org.uk> (raw)
In-Reply-To: <d857ff81-a49c-4dd2-b07d-f17f9019bed1@windriver.com>
On Wed, May 29, 2024 at 06:55:21PM +0800, xiaolei wang wrote:
> On 5/29/24 16:46, Russell King (Oracle) wrote:
> > To me, commit 1f705bc61aee ("net: stmmac: Add support for CBS QDISC")
> > just looks very buggy.
>
> This makes sense. I think it is necessary to update the parameters after
> linking up.
>
> Does anyone have a better suggestion?
Any setup that a phylink-based MAC driver does which is dependent on
the negotiated media parameters (e.g. speed, duplex etc) _should_
always be done from the .mac_link_up method.
So, from a phylink perspective, what you propose is the correct and
only way.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: xiaolei wang <xiaolei.wang@windriver.com>
Cc: alexandre.torgue@foss.st.com, joabreu@synopsys.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, mcoquelin.stm32@gmail.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [net PATCH] net: stmmac: update priv->speed to SPEED_UNKNOWN when link down
Date: Wed, 29 May 2024 12:45:38 +0100 [thread overview]
Message-ID: <ZlcVYjOEBGm79Yc9@shell.armlinux.org.uk> (raw)
In-Reply-To: <d857ff81-a49c-4dd2-b07d-f17f9019bed1@windriver.com>
On Wed, May 29, 2024 at 06:55:21PM +0800, xiaolei wang wrote:
> On 5/29/24 16:46, Russell King (Oracle) wrote:
> > To me, commit 1f705bc61aee ("net: stmmac: Add support for CBS QDISC")
> > just looks very buggy.
>
> This makes sense. I think it is necessary to update the parameters after
> linking up.
>
> Does anyone have a better suggestion?
Any setup that a phylink-based MAC driver does which is dependent on
the negotiated media parameters (e.g. speed, duplex etc) _should_
always be done from the .mac_link_up method.
So, from a phylink perspective, what you propose is the correct and
only way.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-05-29 11:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 9:20 [net PATCH] net: stmmac: update priv->speed to SPEED_UNKNOWN when link down Xiaolei Wang
2024-05-28 9:20 ` Xiaolei Wang
2024-05-28 13:20 ` Andrew Lunn
2024-05-28 13:20 ` Andrew Lunn
2024-05-29 0:22 ` xiaolei wang
2024-05-29 0:22 ` xiaolei wang
2024-05-29 0:57 ` Andrew Lunn
2024-05-29 0:57 ` Andrew Lunn
2024-05-29 8:48 ` Russell King (Oracle)
2024-05-29 8:48 ` Russell King (Oracle)
2024-05-29 8:46 ` Russell King (Oracle)
2024-05-29 8:46 ` Russell King (Oracle)
2024-05-29 10:55 ` xiaolei wang
2024-05-29 10:55 ` xiaolei wang
2024-05-29 11:45 ` Russell King (Oracle) [this message]
2024-05-29 11:45 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlcVYjOEBGm79Yc9@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiaolei.wang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.