All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-phy@lists.infradead.org, vkoul@kernel.org,
	kishon@kernel.org, lorenzo.bianconi83@gmail.com,
	conor@kernel.org, linux-arm-kernel@lists.infradead.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org, nbd@nbd.name,
	john@phrozen.org, dd@embedd.com, catalin.marinas@arm.com,
	will@kernel.org, upstream@airoha.com,
	angelogioacchino.delregno@collabora.com, amitsinght@marvell.com
Subject: Re: [PATCH v3 1/4] dt-bindings: phy: airoha: Add binding doc for PCIe PHY driver
Date: Wed, 29 May 2024 15:11:33 +0200	[thread overview]
Message-ID: <Zlcphf1jWYnQQlIZ@lore-desk> (raw)
In-Reply-To: <6f5b26d6-c452-4490-9d34-d0a4207139ba@linaro.org>


[-- Attachment #1.1: Type: text/plain, Size: 921 bytes --]

> On 18/05/2024 13:31, Lorenzo Bianconi wrote:
> > Introduce device-tree binding documentation for Airoha EN7581 PCIe PHY
> > driver.
> > 
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > Tested-by: Zhengping Zhang <zhengping.zhang@airoha.com>
> 
> How the binding was tested?
> 
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> 
> A nit, subject: drop second/last, redundant "bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> 
> Subject: drop driver. This is for hardware, not drivers.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Do I need to repost it or is it ok to address it applying the patches?

Regards,
Lorenzo

> 
> Best regards,
> Krzysztof
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 112 bytes --]

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-phy@lists.infradead.org, vkoul@kernel.org,
	kishon@kernel.org, lorenzo.bianconi83@gmail.com,
	conor@kernel.org, linux-arm-kernel@lists.infradead.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org, nbd@nbd.name,
	john@phrozen.org, dd@embedd.com, catalin.marinas@arm.com,
	will@kernel.org, upstream@airoha.com,
	angelogioacchino.delregno@collabora.com, amitsinght@marvell.com
Subject: Re: [PATCH v3 1/4] dt-bindings: phy: airoha: Add binding doc for PCIe PHY driver
Date: Wed, 29 May 2024 15:11:33 +0200	[thread overview]
Message-ID: <Zlcphf1jWYnQQlIZ@lore-desk> (raw)
In-Reply-To: <6f5b26d6-c452-4490-9d34-d0a4207139ba@linaro.org>


[-- Attachment #1.1: Type: text/plain, Size: 921 bytes --]

> On 18/05/2024 13:31, Lorenzo Bianconi wrote:
> > Introduce device-tree binding documentation for Airoha EN7581 PCIe PHY
> > driver.
> > 
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > Tested-by: Zhengping Zhang <zhengping.zhang@airoha.com>
> 
> How the binding was tested?
> 
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> 
> A nit, subject: drop second/last, redundant "bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> 
> Subject: drop driver. This is for hardware, not drivers.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Do I need to repost it or is it ok to address it applying the patches?

Regards,
Lorenzo

> 
> Best regards,
> Krzysztof
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-phy@lists.infradead.org, vkoul@kernel.org,
	kishon@kernel.org, lorenzo.bianconi83@gmail.com,
	conor@kernel.org, linux-arm-kernel@lists.infradead.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org, nbd@nbd.name,
	john@phrozen.org, dd@embedd.com, catalin.marinas@arm.com,
	will@kernel.org, upstream@airoha.com,
	angelogioacchino.delregno@collabora.com, amitsinght@marvell.com
Subject: Re: [PATCH v3 1/4] dt-bindings: phy: airoha: Add binding doc for PCIe PHY driver
Date: Wed, 29 May 2024 15:11:33 +0200	[thread overview]
Message-ID: <Zlcphf1jWYnQQlIZ@lore-desk> (raw)
In-Reply-To: <6f5b26d6-c452-4490-9d34-d0a4207139ba@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]

> On 18/05/2024 13:31, Lorenzo Bianconi wrote:
> > Introduce device-tree binding documentation for Airoha EN7581 PCIe PHY
> > driver.
> > 
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > Tested-by: Zhengping Zhang <zhengping.zhang@airoha.com>
> 
> How the binding was tested?
> 
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> 
> A nit, subject: drop second/last, redundant "bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> 
> Subject: drop driver. This is for hardware, not drivers.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Do I need to repost it or is it ok to address it applying the patches?

Regards,
Lorenzo

> 
> Best regards,
> Krzysztof
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-05-29 13:11 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-18 11:31 [PATCH v3 0/4] Introduce PCIe PHY driver for EN7581 SoC Lorenzo Bianconi
2024-05-18 11:31 ` Lorenzo Bianconi
2024-05-18 11:31 ` Lorenzo Bianconi
2024-05-18 11:31 ` [PATCH v3 1/4] dt-bindings: phy: airoha: Add binding doc for PCIe PHY driver Lorenzo Bianconi
2024-05-18 11:31   ` Lorenzo Bianconi
2024-05-18 11:31   ` Lorenzo Bianconi
2024-05-20  7:05   ` Krzysztof Kozlowski
2024-05-20  7:05     ` Krzysztof Kozlowski
2024-05-20  7:05     ` Krzysztof Kozlowski
2024-05-29 13:11     ` Lorenzo Bianconi [this message]
2024-05-29 13:11       ` Lorenzo Bianconi
2024-05-29 13:11       ` Lorenzo Bianconi
2024-05-18 11:31 ` [PATCH v3 2/4] arm64: dts: airoha: Add EN7581 pcie-phy node Lorenzo Bianconi
2024-05-18 11:31   ` Lorenzo Bianconi
2024-05-18 11:31   ` Lorenzo Bianconi
2024-05-18 11:31 ` [PATCH v3 3/4] phy: airoha: Add PCIe PHY driver for EN7581 SoC Lorenzo Bianconi
2024-05-18 11:31   ` Lorenzo Bianconi
2024-05-18 11:31   ` Lorenzo Bianconi
2024-05-18 11:31 ` [PATCH v3 4/4] arm64: defconfig: Enable Airoha pcie phy driver Lorenzo Bianconi
2024-05-18 11:31   ` Lorenzo Bianconi
2024-05-18 11:31   ` Lorenzo Bianconi
2024-05-20  9:49   ` AngeloGioacchino Del Regno
2024-05-20  9:49     ` AngeloGioacchino Del Regno
2024-05-20  9:49     ` AngeloGioacchino Del Regno
2024-06-15 18:49 ` [PATCH v3 0/4] Introduce PCIe PHY driver for EN7581 SoC Vinod Koul
2024-06-15 18:49   ` Vinod Koul
2024-06-20 16:38 ` (subset) " Vinod Koul
2024-06-20 16:38   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zlcphf1jWYnQQlIZ@lore-desk \
    --to=lorenzo@kernel.org \
    --cc=amitsinght@marvell.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=dd@embedd.com \
    --cc=devicetree@vger.kernel.org \
    --cc=john@phrozen.org \
    --cc=kishon@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=lorenzo.bianconi83@gmail.com \
    --cc=nbd@nbd.name \
    --cc=robh+dt@kernel.org \
    --cc=upstream@airoha.com \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.