From: Joe Damato <jdamato@fastly.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, donald.hunter@gmail.com, sdf@google.com,
amritha.nambiar@intel.com, hawk@kernel.org,
sridhar.samudrala@intel.com
Subject: Re: [PATCH net] netdev: add qstat for csum complete
Date: Wed, 29 May 2024 12:07:37 -0700 [thread overview]
Message-ID: <Zld8-aZ5JOMVTKY3@LQ3V64L9R2> (raw)
In-Reply-To: <20240529115736.7b83c0f3@kernel.org>
On Wed, May 29, 2024 at 11:57:36AM -0700, Jakub Kicinski wrote:
> On Wed, 29 May 2024 11:23:49 -0700 Joe Damato wrote:
> > Are you planning to submit a separate change to add csum_complete to
> > struct netdev_queue_stats_rx, as well? Just wanted to double check,
> > but I assume that is a net-next thing.
>
> I figured we can add the handling with the first user. I can, unless
> you're already planning to add more counters yourself once the base
> set is merged.
Sure, adding with the first user makes sense to me.
On my side: I honestly have no idea how close or far away I am from
landing the mlx5 qstats stuff, but if I do somehow get that in, I
would be fine adding the extra stats at that point.
Hoping the RFCv3 I have out now is closer/almost there.
next prev parent reply other threads:[~2024-05-29 19:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 16:35 [PATCH net] netdev: add qstat for csum complete Jakub Kicinski
2024-05-29 18:23 ` Joe Damato
2024-05-29 18:57 ` Jakub Kicinski
2024-05-29 19:07 ` Joe Damato [this message]
2024-05-30 10:15 ` Paolo Abeni
2024-05-30 10:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zld8-aZ5JOMVTKY3@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=amritha.nambiar@intel.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.