From: Paolo Abeni <pabeni@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com,
donald.hunter@gmail.com, sdf@google.com,
amritha.nambiar@intel.com, hawk@kernel.org,
sridhar.samudrala@intel.com, jdamato@fastly.com
Subject: Re: [PATCH net] netdev: add qstat for csum complete
Date: Thu, 30 May 2024 12:15:12 +0200 [thread overview]
Message-ID: <fc71647cbb44b37bc4a6d5ce85529039744da87b.camel@redhat.com> (raw)
In-Reply-To: <20240529163547.3693194-1-kuba@kernel.org>
On Wed, 2024-05-29 at 09:35 -0700, Jakub Kicinski wrote:
> Recent commit 0cfe71f45f42 ("netdev: add queue stats") added
> a lot of useful stats, but only those immediately needed by virtio.
> Presumably virtio does not support CHECKSUM_COMPLETE,
> so statistic for that form of checksumming wasn't included.
> Other drivers will definitely need it, in fact we expect it
> to be needed in net-next soon (mlx5). So let's add the definition
> of the counter for CHECKSUM_COMPLETE to uAPI in net already,
> so that the counters are in a more natural order (all subsequent
> counters have not been present in any released kernel, yet).
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Given the uAPI implication I believe its better to let this land into
today PR. Also adding
Fixes: 0cfe71f45f42 ("netdev: add queue stats")
To try to reduce the chance that backports will end-up with
inconsistent uAPI.
Cheers,
Paolo
next prev parent reply other threads:[~2024-05-30 10:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 16:35 [PATCH net] netdev: add qstat for csum complete Jakub Kicinski
2024-05-29 18:23 ` Joe Damato
2024-05-29 18:57 ` Jakub Kicinski
2024-05-29 19:07 ` Joe Damato
2024-05-30 10:15 ` Paolo Abeni [this message]
2024-05-30 10:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc71647cbb44b37bc4a6d5ce85529039744da87b.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=amritha.nambiar@intel.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.