All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, nbd@nbd.name,
	lorenzo.bianconi83@gmail.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	conor@kernel.org, linux-arm-kernel@lists.infradead.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com,
	angelogioacchino.delregno@collabora.com,
	benjamin.larsson@genexis.eu
Subject: Re: [PATCH net-next 3/3] net: airoha: Introduce ethernet support for EN7581 SoC
Date: Sun, 2 Jun 2024 20:10:06 +0200	[thread overview]
Message-ID: <Zly1fi5kr9YNo2yN@lore-desk> (raw)
In-Reply-To: <9efb0c64-d3b2-478b-953e-94ef8be3ddec@lunn.ch>


[-- Attachment #1.1: Type: text/plain, Size: 818 bytes --]

> > +static void airoha_remove(struct platform_device *pdev)
> > +{
> > +	struct airoha_eth *eth = platform_get_drvdata(pdev);
> > +	int i;
> > +
> > +	debugfs_remove(eth->debugfs_dir);
> > +
> > +	airoha_qdma_for_each_q_rx(eth, i) {
> > +		struct airoha_queue *q = &eth->q_rx[i];
> > +
> > +		netif_napi_del(&q->napi);
> > +		airoha_qdma_clenaup_rx_queue(q);
> > +		page_pool_destroy(q->page_pool);
> > +	}
> > +
> > +	for (i = 0; i < ARRAY_SIZE(eth->q_tx_irq); i++)
> > +		netif_napi_del(&eth->q_tx_irq[i].napi);
> > +	for (i = 0; i < ARRAY_SIZE(eth->q_tx); i++)
> > +		airoha_qdma_clenaup_tx_queue(&eth->q_tx[i]);
> > +}
> 
> You don't appear to unregister the netdev. remove() should basically
> be the reverse of probe().
> 
>     Andrew

ack, I will fix it in v2.

Regards,
Lorenzo

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, nbd@nbd.name,
	lorenzo.bianconi83@gmail.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	conor@kernel.org, linux-arm-kernel@lists.infradead.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com,
	angelogioacchino.delregno@collabora.com,
	benjamin.larsson@genexis.eu
Subject: Re: [PATCH net-next 3/3] net: airoha: Introduce ethernet support for EN7581 SoC
Date: Sun, 2 Jun 2024 20:10:06 +0200	[thread overview]
Message-ID: <Zly1fi5kr9YNo2yN@lore-desk> (raw)
In-Reply-To: <9efb0c64-d3b2-478b-953e-94ef8be3ddec@lunn.ch>

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

> > +static void airoha_remove(struct platform_device *pdev)
> > +{
> > +	struct airoha_eth *eth = platform_get_drvdata(pdev);
> > +	int i;
> > +
> > +	debugfs_remove(eth->debugfs_dir);
> > +
> > +	airoha_qdma_for_each_q_rx(eth, i) {
> > +		struct airoha_queue *q = &eth->q_rx[i];
> > +
> > +		netif_napi_del(&q->napi);
> > +		airoha_qdma_clenaup_rx_queue(q);
> > +		page_pool_destroy(q->page_pool);
> > +	}
> > +
> > +	for (i = 0; i < ARRAY_SIZE(eth->q_tx_irq); i++)
> > +		netif_napi_del(&eth->q_tx_irq[i].napi);
> > +	for (i = 0; i < ARRAY_SIZE(eth->q_tx); i++)
> > +		airoha_qdma_clenaup_tx_queue(&eth->q_tx[i]);
> > +}
> 
> You don't appear to unregister the netdev. remove() should basically
> be the reverse of probe().
> 
>     Andrew

ack, I will fix it in v2.

Regards,
Lorenzo

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-06-02 18:10 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31 10:22 [PATCH net-next 0/3] Introduce EN7581 ethernet support Lorenzo Bianconi
2024-05-31 10:22 ` Lorenzo Bianconi
2024-05-31 10:22 ` [PATCH net-next 1/3] dt-bindings: net: airoha: Add EN7581 ethernet controller Lorenzo Bianconi
2024-05-31 10:22   ` Lorenzo Bianconi
2024-05-31 11:33   ` Rob Herring (Arm)
2024-05-31 11:33     ` Rob Herring (Arm)
2024-06-01  8:46     ` Lorenzo Bianconi
2024-06-01  8:46       ` Lorenzo Bianconi
2024-05-31 10:22 ` [PATCH net-next 2/3] arm64: dts: airoha: Add EN7581 ethernet node Lorenzo Bianconi
2024-05-31 10:22   ` Lorenzo Bianconi
2024-06-02 17:05   ` Andrew Lunn
2024-06-02 17:05     ` Andrew Lunn
2024-06-02 17:38     ` Lorenzo Bianconi
2024-06-02 17:38       ` Lorenzo Bianconi
2024-06-02 17:49       ` Andrew Lunn
2024-06-02 17:49         ` Andrew Lunn
2024-06-02 18:00         ` Lorenzo Bianconi
2024-06-02 18:00           ` Lorenzo Bianconi
2024-05-31 10:22 ` [PATCH net-next 3/3] net: airoha: Introduce ethernet support for EN7581 SoC Lorenzo Bianconi
2024-05-31 10:22   ` Lorenzo Bianconi
2024-05-31 11:59   ` [EXTERNAL] " Subbaraya Sundeep Bhatta
2024-05-31 11:59     ` Subbaraya Sundeep Bhatta
2024-06-01  9:04     ` Lorenzo Bianconi
2024-06-01  9:04       ` Lorenzo Bianconi
2024-06-02 17:56     ` Andrew Lunn
2024-06-02 17:56       ` Andrew Lunn
2024-06-02 17:38   ` Andrew Lunn
2024-06-02 17:38     ` Andrew Lunn
2024-06-02 21:15     ` Lorenzo Bianconi
2024-06-02 21:15       ` Lorenzo Bianconi
2024-06-02 17:40   ` Andrew Lunn
2024-06-02 17:40     ` Andrew Lunn
2024-06-02 18:10     ` Lorenzo Bianconi [this message]
2024-06-02 18:10       ` Lorenzo Bianconi
2024-06-03  5:19   ` [EXTERNAL] " Sunil Kovvuri Goutham
2024-06-03  5:19     ` Sunil Kovvuri Goutham
2024-06-03  7:53     ` Lorenzo Bianconi
2024-06-03  7:53       ` Lorenzo Bianconi
2024-06-03  9:04       ` Sunil Kovvuri Goutham
2024-06-03  9:04         ` Sunil Kovvuri Goutham
2024-06-03  6:27   ` Ratheesh Kannoth
2024-06-03  6:27     ` Ratheesh Kannoth
2024-06-03  9:37     ` Lorenzo Bianconi
2024-06-03  9:37       ` Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zly1fi5kr9YNo2yN@lore-desk \
    --to=lorenzo@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=benjamin.larsson@genexis.eu \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lorenzo.bianconi83@gmail.com \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    --cc=upstream@airoha.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.