All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: Sebastian Chlad <schlad@suse.de>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] Fix unlink09 test
Date: Wed, 5 Jun 2024 10:04:57 +0200	[thread overview]
Message-ID: <ZmAcKW42Hsi2Xnsm@rei> (raw)
In-Reply-To: <20240605073806.GA355314@pevik>

Hi!
> > https://patchwork.ozlabs.org/project/ltp/patch/20240603124653.31967-1-akumar@suse.de/
> 
> OK, I got hint from Andrea, that this is inspired by statx04.c:86, which is
> filtering vfat and exfat. Here the problem was on system which has tmpfs, but
> just more strict default setup (likely umask). Therefore I still think that
> approach from Avinesh is correct.
> 
> BTW shouldn't this test use .all_filesystems = 1 ? Or is it unlink() really VFS
> only code? I see some specific functions in fs/*/, e.g. btrfs_unlink() or
> ext4_unlink(), which are used for struct inode_operations unlink member.
> Then, obviously also Andrea's check would be needed (otherwise is unlikely that
> somebody would have TMPDIR on vfat or exfat).

I would say that exfat or vfat is not uncommon in android world so I
would expect that actually having LTP TMPDIR on exfat is not as unlikely
as you may think.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2024-06-05  8:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04 13:44 [LTP] [PATCH] Fix unlink09 test Andrea Cervesato
2024-06-05  6:57 ` Petr Vorel
2024-06-05  7:38   ` Petr Vorel
2024-06-05  7:55     ` Andrea Cervesato via ltp
2024-06-05  8:04     ` Cyril Hrubis [this message]
2024-06-05 12:02     ` Martin Doucha
2024-06-05 12:11       ` Petr Vorel
2024-06-05 12:27         ` Petr Vorel
2024-06-05 12:34           ` Martin Doucha
2024-06-05 13:21             ` Petr Vorel
2024-06-05 13:44               ` Cyril Hrubis
2024-06-05 13:53                 ` Martin Doucha
2024-06-05 14:17                   ` Petr Vorel
2024-06-05 14:12                 ` Petr Vorel
2024-06-05 14:24   ` Konstantin Ryabitsev
2024-06-07  9:36     ` Petr Vorel
2024-06-05  8:11 ` Cyril Hrubis
2024-06-05 10:16   ` Andrea Cervesato via ltp
2024-06-05 11:30     ` Cyril Hrubis
2024-06-05 11:42       ` Andrea Cervesato via ltp
2024-06-05 11:53   ` Martin Doucha
2024-06-05 12:05 ` Martin Doucha
2024-06-05 12:22 ` Martin Doucha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZmAcKW42Hsi2Xnsm@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    --cc=schlad@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.