From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it, Sebastian Chlad <schlad@suse.de>
Subject: Re: [LTP] [PATCH] Fix unlink09 test
Date: Wed, 5 Jun 2024 15:44:03 +0200 [thread overview]
Message-ID: <ZmBro_t3U02xDNTe@yuki> (raw)
In-Reply-To: <20240605132134.GA393734@pevik>
Hi!
> > It would be useful and prepare_device() implements everything that's needed
> > for it but there's a bug in do_setup() which creates a conflict between the
> > two attributes. The .all_filesystems attribute forces .needs_device but a
> > few lines below that is a check that .needs_rofs and .needs_device are not
> > set at the same time. This can be fixed.
>
> Thanks for info, I'll have look into it.
It may not be needed. The counter argument is that if you mix a read
only filesystem tests and all_filesystems in one test you are combining
two unrelated things that are probably better to be done in a separate
tests.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-06-05 13:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 13:44 [LTP] [PATCH] Fix unlink09 test Andrea Cervesato
2024-06-05 6:57 ` Petr Vorel
2024-06-05 7:38 ` Petr Vorel
2024-06-05 7:55 ` Andrea Cervesato via ltp
2024-06-05 8:04 ` Cyril Hrubis
2024-06-05 12:02 ` Martin Doucha
2024-06-05 12:11 ` Petr Vorel
2024-06-05 12:27 ` Petr Vorel
2024-06-05 12:34 ` Martin Doucha
2024-06-05 13:21 ` Petr Vorel
2024-06-05 13:44 ` Cyril Hrubis [this message]
2024-06-05 13:53 ` Martin Doucha
2024-06-05 14:17 ` Petr Vorel
2024-06-05 14:12 ` Petr Vorel
2024-06-05 14:24 ` Konstantin Ryabitsev
2024-06-07 9:36 ` Petr Vorel
2024-06-05 8:11 ` Cyril Hrubis
2024-06-05 10:16 ` Andrea Cervesato via ltp
2024-06-05 11:30 ` Cyril Hrubis
2024-06-05 11:42 ` Andrea Cervesato via ltp
2024-06-05 11:53 ` Martin Doucha
2024-06-05 12:05 ` Martin Doucha
2024-06-05 12:22 ` Martin Doucha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmBro_t3U02xDNTe@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
--cc=schlad@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.