[PATCH] lib/Kconfig.debug: document panic= command line option for PANIC_TIMEOUT

[PATCH] lib/Kconfig.debug: document panic= command line option for PANIC_TIMEOUT

[Brian Masney]

PANIC_TIMEOUT can also be controlled with the panic= kernel command line
option, so let's reference it in the Kconfig help. This option is already
documented in kernel-parameters.txt.

Signed-off-by: Brian Masney <bmasney@redhat.com>
---
 lib/Kconfig.debug | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 59b6765d86b8..a6eb7425b888 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1043,7 +1043,8 @@ config PANIC_TIMEOUT
 	  Set the timeout value (in seconds) until a reboot occurs when
 	  the kernel panics. If n = 0, then we wait forever. A timeout
 	  value n > 0 will wait n seconds before rebooting, while a timeout
-	  value n < 0 will reboot immediately.
+	  value n < 0 will reboot immediately. The kernel command line
+	  option panic= may be used to override this option.
 
 config LOCKUP_DETECTOR
 	bool
-- 
2.45.1

Re: [PATCH] lib/Kconfig.debug: document panic= command line option for PANIC_TIMEOUT

[Javier Martinez Canillas]

Brian Masney <bmasney@redhat.com> writes:

Hello Brian,

> PANIC_TIMEOUT can also be controlled with the panic= kernel command line
> option, so let's reference it in the Kconfig help. This option is already
> documented in kernel-parameters.txt.
>
> Signed-off-by: Brian Masney <bmasney@redhat.com>
> ---
>  lib/Kconfig.debug | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 59b6765d86b8..a6eb7425b888 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1043,7 +1043,8 @@ config PANIC_TIMEOUT
>  	  Set the timeout value (in seconds) until a reboot occurs when
>  	  the kernel panics. If n = 0, then we wait forever. A timeout
>  	  value n > 0 will wait n seconds before rebooting, while a timeout
> -	  value n < 0 will reboot immediately.
> +	  value n < 0 will reboot immediately. The kernel command line
> +	  option panic= may be used to override this option.
>  

Thanks for adding this, I wasn't aware of that panic= cmdline before.

Maybe it could also be mentioned that the timeout can be overriden by
user-space using the /proc/sys/kernel/panic sysfs entry too ?

Regardless, the patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

Re: [PATCH] lib/Kconfig.debug: document panic= command line option for PANIC_TIMEOUT

[Brian Masney]

On Wed, Jun 05, 2024 at 08:05:23PM +0200, Javier Martinez Canillas wrote:
> Brian Masney <bmasney@redhat.com> writes:
> 
> Hello Brian,
> 
> > PANIC_TIMEOUT can also be controlled with the panic= kernel command line
> > option, so let's reference it in the Kconfig help. This option is already
> > documented in kernel-parameters.txt.
> >
> > Signed-off-by: Brian Masney <bmasney@redhat.com>
> > ---
> >  lib/Kconfig.debug | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > index 59b6765d86b8..a6eb7425b888 100644
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -1043,7 +1043,8 @@ config PANIC_TIMEOUT
> >  	  Set the timeout value (in seconds) until a reboot occurs when
> >  	  the kernel panics. If n = 0, then we wait forever. A timeout
> >  	  value n > 0 will wait n seconds before rebooting, while a timeout
> > -	  value n < 0 will reboot immediately.
> > +	  value n < 0 will reboot immediately. The kernel command line
> > +	  option panic= may be used to override this option.
> >  
> 
> Thanks for adding this, I wasn't aware of that panic= cmdline before.
> 
> Maybe it could also be mentioned that the timeout can be overriden by
> user-space using the /proc/sys/kernel/panic sysfs entry too ?
> 
> Regardless, the patch looks good to me.
> 
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

I can add that. I'll wait a few days send a v2 to see if there's any
other feedback.

Brian