All of lore.kernel.org
 help / color / mirror / Atom feed
From: Louis Chauvet <louis.chauvet@bootlin.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Brian Xu <brian.xu@amd.com>, Lizhi Hou <lizhi.hou@amd.com>,
	Michal Simek <michal.simek@amd.com>,
	Raj Kumar Rampelli <raj.kumar.rampelli@amd.com>,
	Vinod Koul <vkoul@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: xilinx: xdma: Fixes possible threading issue
Date: Fri, 7 Jun 2024 10:34:29 +0200	[thread overview]
Message-ID: <ZmLGFXPEP-FqgUdn@localhost.localdomain> (raw)
In-Reply-To: <f0eaf77b-eed9-4f8e-8009-983250fa56a8@web.de>

Le 27/05/24 - 20:32, Markus Elfring a écrit :
> > The current interrupt handler in xdma.c was using xdma->stop_request
> > before locking the vchan lock.
> 
> 1. Will an additional imperative wording become helpful here?
>    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc1#n94
> 
> 2. How do you think about to use the summary phrase “Fix data synchronisation in xdma_channel_isr()”?

I changed the commit message and summary in the v2.
 
> 3. Will development interests grow for the usage of a statement like “guard(spin)(&xchan->vchan.lock);”?
>    https://elixir.bootlin.com/linux/v6.10-rc1/source/include/linux/cleanup.h#L124

I don't feel comfortable switching `guard` as the rest of the driver is 
not using it yet. Since this is a fix, I prefer to maintain consistency 
with the style of the rest of the driver.

Thanks,
Louis Chauvet

> 
> Regards,
> Markus
> 

-- 
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: Louis Chauvet <louis.chauvet@bootlin.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Brian Xu <brian.xu@amd.com>, Lizhi Hou <lizhi.hou@amd.com>,
	Michal Simek <michal.simek@amd.com>,
	Raj Kumar Rampelli <raj.kumar.rampelli@amd.com>,
	Vinod Koul <vkoul@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: xilinx: xdma: Fixes possible threading issue
Date: Fri, 7 Jun 2024 10:34:29 +0200	[thread overview]
Message-ID: <ZmLGFXPEP-FqgUdn@localhost.localdomain> (raw)
In-Reply-To: <f0eaf77b-eed9-4f8e-8009-983250fa56a8@web.de>

Le 27/05/24 - 20:32, Markus Elfring a écrit :
> > The current interrupt handler in xdma.c was using xdma->stop_request
> > before locking the vchan lock.
> 
> 1. Will an additional imperative wording become helpful here?
>    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc1#n94
> 
> 2. How do you think about to use the summary phrase “Fix data synchronisation in xdma_channel_isr()”?

I changed the commit message and summary in the v2.
 
> 3. Will development interests grow for the usage of a statement like “guard(spin)(&xchan->vchan.lock);”?
>    https://elixir.bootlin.com/linux/v6.10-rc1/source/include/linux/cleanup.h#L124

I don't feel comfortable switching `guard` as the rest of the driver is 
not using it yet. Since this is a fix, I prefer to maintain consistency 
with the style of the rest of the driver.

Thanks,
Louis Chauvet

> 
> Regards,
> Markus
> 

-- 
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-06-07  8:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27 16:29 [PATCH] dmaengine: xilinx: xdma: Fixes possible threading issue Louis Chauvet
2024-05-27 16:29 ` Louis Chauvet
2024-05-27 18:32 ` Markus Elfring
2024-05-27 18:32   ` Markus Elfring
2024-06-07  8:34   ` Louis Chauvet [this message]
2024-06-07  8:34     ` Louis Chauvet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZmLGFXPEP-FqgUdn@localhost.localdomain \
    --to=louis.chauvet@bootlin.com \
    --cc=Markus.Elfring@web.de \
    --cc=brian.xu@amd.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizhi.hou@amd.com \
    --cc=michal.simek@amd.com \
    --cc=raj.kumar.rampelli@amd.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.