From: Vinod Koul <vkoul@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Peter Ujfalusi <peter.ujfalusi@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
MD Danish Anwar <danishanwar@ti.com>,
Roger Quadros <rogerq@kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Julien Panis <jpanis@baylibre.com>,
Chintan Vankar <c-vankar@ti.com>,
Diogo Ivo <diogo.ivo@siemens.com>,
Simon Horman <horms@kernel.org>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] dmaengine: ti: k3-udma-glue: clean up return in k3_udma_glue_rx_get_irq()
Date: Fri, 7 Jun 2024 22:45:49 +0530 [thread overview]
Message-ID: <ZmNARRlVwU6hLelB@matsya> (raw)
In-Reply-To: <2f28f769-6929-4fc2-b875-00bf1d8bf3c4@kili.mountain>
On 06-06-24, 17:23, Dan Carpenter wrote:
> Currently the k3_udma_glue_rx_get_irq() function returns either negative
> error codes or zero on error. Generally, in the kernel, zero means
> success so this be confusing and has caused bugs in the past. Also the
> "tx" version of this function only returns negative error codes. Let's
> clean this "rx" function so both functions match.
>
> This patch has no effect on runtime.
Acked-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Peter Ujfalusi <peter.ujfalusi@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
MD Danish Anwar <danishanwar@ti.com>,
Roger Quadros <rogerq@kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Julien Panis <jpanis@baylibre.com>,
Chintan Vankar <c-vankar@ti.com>,
Diogo Ivo <diogo.ivo@siemens.com>,
Simon Horman <horms@kernel.org>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] dmaengine: ti: k3-udma-glue: clean up return in k3_udma_glue_rx_get_irq()
Date: Fri, 7 Jun 2024 22:45:49 +0530 [thread overview]
Message-ID: <ZmNARRlVwU6hLelB@matsya> (raw)
In-Reply-To: <2f28f769-6929-4fc2-b875-00bf1d8bf3c4@kili.mountain>
On 06-06-24, 17:23, Dan Carpenter wrote:
> Currently the k3_udma_glue_rx_get_irq() function returns either negative
> error codes or zero on error. Generally, in the kernel, zero means
> success so this be confusing and has caused bugs in the past. Also the
> "tx" version of this function only returns negative error codes. Let's
> clean this "rx" function so both functions match.
>
> This patch has no effect on runtime.
Acked-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-06-07 17:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 14:23 [PATCH net-next] dmaengine: ti: k3-udma-glue: clean up return in k3_udma_glue_rx_get_irq() Dan Carpenter
2024-06-06 14:23 ` Dan Carpenter
2024-06-06 17:30 ` Péter Ujfalusi
2024-06-06 17:30 ` Péter Ujfalusi
2024-06-07 17:15 ` Vinod Koul [this message]
2024-06-07 17:15 ` Vinod Koul
2024-06-09 16:40 ` patchwork-bot+netdevbpf
2024-06-09 16:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmNARRlVwU6hLelB@matsya \
--to=vkoul@kernel.org \
--cc=c-vankar@ti.com \
--cc=dan.carpenter@linaro.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=diogo.ivo@siemens.com \
--cc=dmaengine@vger.kernel.org \
--cc=edumazet@google.com \
--cc=grygorii.strashko@ti.com \
--cc=horms@kernel.org \
--cc=jpanis@baylibre.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peter.ujfalusi@gmail.com \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.