All of lore.kernel.org
 help / color / mirror / Atom feed
From: Deepak Gupta <debug@rivosinc.com>
To: Samuel Holland <samuel.holland@sifive.com>
Cc: linux-riscv@lists.infradead.org,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Andrew Jones <ajones@ventanamicro.com>,
	Conor Dooley <conor@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] riscv: Per-thread envcfg CSR support
Date: Fri, 7 Jun 2024 15:01:43 -0700	[thread overview]
Message-ID: <ZmODR+EMn5zW2Iu1@debug.ba.rivosinc.com> (raw)
In-Reply-To: <20240605205658.184399-1-samuel.holland@sifive.com>

Hi Samuel,

Thanks for working on these.
Patches looks good to me. I've given some suggestion for patch organization
and squashing. You can take it or leave it.

Other than that.

Reviewed-By: Deepak Gupta <debug@rivosinc.com>

On Wed, Jun 05, 2024 at 01:56:44PM -0700, Samuel Holland wrote:
>This series (or equivalent) is a prerequisite for both user-mode pointer
>masking and CFI support, as those are per-thread features are controlled
>by fields in the envcfg CSR. These patches are based on v1 of the
>pointer masking series[1], with significant input from both Deepak and
>Andrew. By sending this as a separate series, hopefully we can converge
>on a single implementation of this functionality.
>
>[1]: https://lore.kernel.org/linux-riscv/20240319215915.832127-6-samuel.holland@sifive.com/
>
>
>Samuel Holland (3):
>  riscv: Enable cbo.zero only when all harts support Zicboz
>  riscv: Add support for per-thread envcfg CSR values
>  riscv: Call riscv_user_isa_enable() only on the boot hart
>
> arch/riscv/include/asm/cpufeature.h |  2 +-
> arch/riscv/include/asm/processor.h  |  1 +
> arch/riscv/include/asm/switch_to.h  |  8 ++++++++
> arch/riscv/kernel/cpufeature.c      | 13 +++++++++----
> arch/riscv/kernel/smpboot.c         |  2 --
> arch/riscv/kernel/suspend.c         |  4 ++--
> 6 files changed, 21 insertions(+), 9 deletions(-)
>
>-- 
>2.44.1
>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Deepak Gupta <debug@rivosinc.com>
To: Samuel Holland <samuel.holland@sifive.com>
Cc: linux-riscv@lists.infradead.org,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Andrew Jones <ajones@ventanamicro.com>,
	Conor Dooley <conor@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] riscv: Per-thread envcfg CSR support
Date: Fri, 7 Jun 2024 15:01:43 -0700	[thread overview]
Message-ID: <ZmODR+EMn5zW2Iu1@debug.ba.rivosinc.com> (raw)
In-Reply-To: <20240605205658.184399-1-samuel.holland@sifive.com>

Hi Samuel,

Thanks for working on these.
Patches looks good to me. I've given some suggestion for patch organization
and squashing. You can take it or leave it.

Other than that.

Reviewed-By: Deepak Gupta <debug@rivosinc.com>

On Wed, Jun 05, 2024 at 01:56:44PM -0700, Samuel Holland wrote:
>This series (or equivalent) is a prerequisite for both user-mode pointer
>masking and CFI support, as those are per-thread features are controlled
>by fields in the envcfg CSR. These patches are based on v1 of the
>pointer masking series[1], with significant input from both Deepak and
>Andrew. By sending this as a separate series, hopefully we can converge
>on a single implementation of this functionality.
>
>[1]: https://lore.kernel.org/linux-riscv/20240319215915.832127-6-samuel.holland@sifive.com/
>
>
>Samuel Holland (3):
>  riscv: Enable cbo.zero only when all harts support Zicboz
>  riscv: Add support for per-thread envcfg CSR values
>  riscv: Call riscv_user_isa_enable() only on the boot hart
>
> arch/riscv/include/asm/cpufeature.h |  2 +-
> arch/riscv/include/asm/processor.h  |  1 +
> arch/riscv/include/asm/switch_to.h  |  8 ++++++++
> arch/riscv/kernel/cpufeature.c      | 13 +++++++++----
> arch/riscv/kernel/smpboot.c         |  2 --
> arch/riscv/kernel/suspend.c         |  4 ++--
> 6 files changed, 21 insertions(+), 9 deletions(-)
>
>-- 
>2.44.1
>

  parent reply	other threads:[~2024-06-07 22:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05 20:56 [PATCH 0/3] riscv: Per-thread envcfg CSR support Samuel Holland
2024-06-05 20:56 ` Samuel Holland
2024-06-05 20:56 ` [PATCH 1/3] riscv: Enable cbo.zero only when all harts support Zicboz Samuel Holland
2024-06-05 20:56   ` Samuel Holland
2024-06-07 20:35   ` Deepak Gupta
2024-06-07 20:35     ` Deepak Gupta
2024-06-07 20:39     ` Conor Dooley
2024-06-07 20:39       ` Conor Dooley
2024-06-07 21:41       ` Deepak Gupta
2024-06-07 21:41         ` Deepak Gupta
2024-06-05 20:56 ` [PATCH 2/3] riscv: Add support for per-thread envcfg CSR values Samuel Holland
2024-06-05 20:56   ` Samuel Holland
2024-06-07 21:59   ` Deepak Gupta
2024-06-07 21:59     ` Deepak Gupta
2024-06-13 16:59     ` Samuel Holland
2024-06-13 16:59       ` Samuel Holland
2024-06-05 20:56 ` [PATCH 3/3] riscv: Call riscv_user_isa_enable() only on the boot hart Samuel Holland
2024-06-05 20:56   ` Samuel Holland
2024-06-07 21:59   ` Deepak Gupta
2024-06-07 21:59     ` Deepak Gupta
2024-06-07 22:01 ` Deepak Gupta [this message]
2024-06-07 22:01   ` [PATCH 0/3] riscv: Per-thread envcfg CSR support Deepak Gupta
2024-06-13 17:01   ` Samuel Holland
2024-06-13 17:01     ` Samuel Holland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZmODR+EMn5zW2Iu1@debug.ba.rivosinc.com \
    --to=debug@rivosinc.com \
    --cc=ajones@ventanamicro.com \
    --cc=conor@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=samuel.holland@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.