Re: [Buildroot] [PATCH 1/1] package/python3: fix config directory pattern

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Vincent Fazio <vfazio@gmail.com>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python3: fix config directory pattern
Date: Sun, 9 Jun 2024 07:47:13 +0200	[thread overview]
Message-ID: <ZmVB4bzpE22opuyS@landeda> (raw)
In-Reply-To: <20240609032509.8939-1-vfazio@gmail.com>

Vincent, All,

On 2024-06-08 22:25 -0500, Vincent Fazio spake thusly:
> If a platform triplet is not detected during the configure stage,

Could you share a defconfig that exhibits the issue, please?

Regards,
Yann E. MORIN.

> the
> config directory (LIBPL) defaults to `config-$LDVERSION`.
> 
> In this scenario, the `PYTHON3_REMOVE_USELESS_FILES` hook would fail due
> to `find` incorrectly expecting a second dash and then the triplet.
> 
> Now, we glob anything after the version which will match in both cases.
> 
> Fixes: 54d48c8cad ("package/python3: miscellaneous fixups")
> 
> Signed-off-by: Vincent Fazio <vfazio@gmail.com>
> ---
>  package/python3/python3.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/python3/python3.mk b/package/python3/python3.mk
> index a0b9ed4437..a82bc47a57 100644
> --- a/package/python3/python3.mk
> +++ b/package/python3/python3.mk
> @@ -204,7 +204,7 @@ PYTHON3_CONF_OPTS += \
>  define PYTHON3_REMOVE_USELESS_FILES
>  	rm -f $(TARGET_DIR)/usr/bin/python$(PYTHON3_VERSION_MAJOR)-config
>  	rm -f $(TARGET_DIR)/usr/bin/python3-config
> -	find $(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/config-$(PYTHON3_VERSION_MAJOR)-*/ \
> +	find $(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/config-$(PYTHON3_VERSION_MAJOR)*/ \
>  		-type f -not -name Makefile -exec rm -rf {} \;
>  	find $(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/ -type d \
>  		-name __pycache__ -exec rm -rf {} \;
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot