From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Vincent Fazio <vfazio@gmail.com>
Cc: James Hilliard <james.hilliard1@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Asaf Kahlon <asafka7@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python3: fix config directory pattern
Date: Sun, 9 Jun 2024 21:14:51 +0200 [thread overview]
Message-ID: <ZmX_K6rvysPJXl0p@landeda> (raw)
In-Reply-To: <20240609174048.31062-1-vfazio@gmail.com>
Vincent, All,
On 2024-06-09 12:40 -0500, Vincent Fazio spake thusly:
> Previously, when running `PYTHON3_REMOVE_USELESS_FILES`, the hook to
> clean up files from the python config directory assumed a pattern of
> "config-$(VERSION)m-$(PLATFORM_TRIPLET)".
>
> However, the "m" ABI suffix was dropped in python 3.8, so the hook would
> never actually find files to delete. No error was raised due to the use
> of a subshell to invoke find.
>
> Also, if a platform triplet is not detected during the configure stage,
> the config directory (LIBPL) defaults to `config-$VERSION`, and has no
> trailing `-$PLATFORM_TRIPLET`.
>
> Now, we glob anything after the version to ensure files get deleted.
>
> Signed-off-by: Vincent Fazio <vfazio@gmail.com>
Applied to master, thank you!
Regards,
Yann E. MORIN.
> ---
> package/python3/python3.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/python3/python3.mk b/package/python3/python3.mk
> index 5d9d77af50..950006698b 100644
> --- a/package/python3/python3.mk
> +++ b/package/python3/python3.mk
> @@ -204,7 +204,7 @@ define PYTHON3_REMOVE_USELESS_FILES
> rm -f $(TARGET_DIR)/usr/bin/python3-config
> rm -f $(TARGET_DIR)/usr/bin/smtpd.py.3
> rm -f $(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/distutils/command/wininst*.exe
> - for i in `find $(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/config-$(PYTHON3_VERSION_MAJOR)m-*/ \
> + for i in `find $(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/config-$(PYTHON3_VERSION_MAJOR)*/ \
> -type f -not -name Makefile` ; do \
> rm -f $$i ; \
> done
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-06-09 19:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-09 17:40 [Buildroot] [PATCH 1/1] package/python3: fix config directory pattern Vincent Fazio
2024-06-09 19:14 ` Yann E. MORIN [this message]
2024-06-16 10:22 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2024-06-09 3:25 Vincent Fazio
2024-06-09 5:47 ` Yann E. MORIN
2024-06-09 11:52 ` Vincent Fazio
2024-06-09 15:51 ` Yann E. MORIN
2024-06-09 17:45 ` Vincent Fazio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmX_K6rvysPJXl0p@landeda \
--to=yann.morin.1998@free.fr \
--cc=asafka7@gmail.com \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vfazio@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.