All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Hari Nagalla <hnagalla@ti.com>
Cc: andersson@kernel.org, robh+dt@kernel.org, devarsht@ti.com,
	s-anna@ti.com, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, linux-remoteproc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs
Date: Mon, 10 Jun 2024 11:26:19 -0600	[thread overview]
Message-ID: <Zmc3O+mAP8v9GVQl@p14s> (raw)
In-Reply-To: <20240604171450.2455-1-hnagalla@ti.com>

On Tue, Jun 04, 2024 at 12:14:50PM -0500, Hari Nagalla wrote:
> The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It
> does not have an addressable l1dram . So, remove this optional sram
> property from the bindings to fix device tree build warnings.
> 
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> ---
> Changes in v3:
> *) Use allOf keyword with separate ifs for each variant instead 
>    of nested if/else conditions.
> 
> v2: https://lore.kernel.org/all/20240530164816.1051-1-hnagalla@ti.com/
> 
>  .../bindings/remoteproc/ti,k3-dsp-rproc.yaml  | 89 +++++++++++--------
>  1 file changed, 51 insertions(+), 38 deletions(-)
>

Applied

Thanks,
Mathieu

> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> index 9768db8663eb..b51bb863d759 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> @@ -25,9 +25,6 @@ description: |
>    host processor (Arm CorePac) to perform the device management of the remote
>    processor and to communicate with the remote processor.
>  
> -allOf:
> -  - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#
> -
>  properties:
>    compatible:
>      enum:
> @@ -89,41 +86,57 @@ properties:
>        should be defined as per the generic bindings in,
>        Documentation/devicetree/bindings/sram/sram.yaml
>  
> -if:
> -  properties:
> -    compatible:
> -      enum:
> -        - ti,j721e-c66-dsp
> -then:
> -  properties:
> -    reg:
> -      items:
> -        - description: Address and Size of the L2 SRAM internal memory region
> -        - description: Address and Size of the L1 PRAM internal memory region
> -        - description: Address and Size of the L1 DRAM internal memory region
> -    reg-names:
> -      items:
> -        - const: l2sram
> -        - const: l1pram
> -        - const: l1dram
> -else:
> -  if:
> -    properties:
> -      compatible:
> -        enum:
> -          - ti,am62a-c7xv-dsp
> -          - ti,j721e-c71-dsp
> -          - ti,j721s2-c71-dsp
> -  then:
> -    properties:
> -      reg:
> -        items:
> -          - description: Address and Size of the L2 SRAM internal memory region
> -          - description: Address and Size of the L1 DRAM internal memory region
> -      reg-names:
> -        items:
> -          - const: l2sram
> -          - const: l1dram
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - ti,j721e-c66-dsp
> +    then:
> +      properties:
> +        reg:
> +          items:
> +            - description: Address and Size of the L2 SRAM internal memory region
> +            - description: Address and Size of the L1 PRAM internal memory region
> +            - description: Address and Size of the L1 DRAM internal memory region
> +        reg-names:
> +          items:
> +            - const: l2sram
> +            - const: l1pram
> +            - const: l1dram
> +
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - ti,j721e-c71-dsp
> +            - ti,j721s2-c71-dsp
> +    then:
> +      properties:
> +        reg:
> +          items:
> +            - description: Address and Size of the L2 SRAM internal memory region
> +            - description: Address and Size of the L1 DRAM internal memory region
> +        reg-names:
> +          items:
> +            - const: l2sram
> +            - const: l1dram
> +
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - ti,am62a-c7xv-dsp
> +    then:
> +      properties:
> +        reg:
> +          items:
> +            - description: Address and Size of the L2 SRAM internal memory region
> +        reg-names:
> +          items:
> +            - const: l2sram
> +
> +  - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#
>  
>  required:
>    - compatible
> -- 
> 2.34.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Hari Nagalla <hnagalla@ti.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, devarsht@ti.com,
	andersson@kernel.org, linux-remoteproc@vger.kernel.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs
Date: Mon, 10 Jun 2024 11:26:19 -0600	[thread overview]
Message-ID: <Zmc3O+mAP8v9GVQl@p14s> (raw)
In-Reply-To: <20240604171450.2455-1-hnagalla@ti.com>

On Tue, Jun 04, 2024 at 12:14:50PM -0500, Hari Nagalla wrote:
> The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It
> does not have an addressable l1dram . So, remove this optional sram
> property from the bindings to fix device tree build warnings.
> 
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> ---
> Changes in v3:
> *) Use allOf keyword with separate ifs for each variant instead 
>    of nested if/else conditions.
> 
> v2: https://lore.kernel.org/all/20240530164816.1051-1-hnagalla@ti.com/
> 
>  .../bindings/remoteproc/ti,k3-dsp-rproc.yaml  | 89 +++++++++++--------
>  1 file changed, 51 insertions(+), 38 deletions(-)
>

Applied

Thanks,
Mathieu

> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> index 9768db8663eb..b51bb863d759 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> @@ -25,9 +25,6 @@ description: |
>    host processor (Arm CorePac) to perform the device management of the remote
>    processor and to communicate with the remote processor.
>  
> -allOf:
> -  - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#
> -
>  properties:
>    compatible:
>      enum:
> @@ -89,41 +86,57 @@ properties:
>        should be defined as per the generic bindings in,
>        Documentation/devicetree/bindings/sram/sram.yaml
>  
> -if:
> -  properties:
> -    compatible:
> -      enum:
> -        - ti,j721e-c66-dsp
> -then:
> -  properties:
> -    reg:
> -      items:
> -        - description: Address and Size of the L2 SRAM internal memory region
> -        - description: Address and Size of the L1 PRAM internal memory region
> -        - description: Address and Size of the L1 DRAM internal memory region
> -    reg-names:
> -      items:
> -        - const: l2sram
> -        - const: l1pram
> -        - const: l1dram
> -else:
> -  if:
> -    properties:
> -      compatible:
> -        enum:
> -          - ti,am62a-c7xv-dsp
> -          - ti,j721e-c71-dsp
> -          - ti,j721s2-c71-dsp
> -  then:
> -    properties:
> -      reg:
> -        items:
> -          - description: Address and Size of the L2 SRAM internal memory region
> -          - description: Address and Size of the L1 DRAM internal memory region
> -      reg-names:
> -        items:
> -          - const: l2sram
> -          - const: l1dram
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - ti,j721e-c66-dsp
> +    then:
> +      properties:
> +        reg:
> +          items:
> +            - description: Address and Size of the L2 SRAM internal memory region
> +            - description: Address and Size of the L1 PRAM internal memory region
> +            - description: Address and Size of the L1 DRAM internal memory region
> +        reg-names:
> +          items:
> +            - const: l2sram
> +            - const: l1pram
> +            - const: l1dram
> +
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - ti,j721e-c71-dsp
> +            - ti,j721s2-c71-dsp
> +    then:
> +      properties:
> +        reg:
> +          items:
> +            - description: Address and Size of the L2 SRAM internal memory region
> +            - description: Address and Size of the L1 DRAM internal memory region
> +        reg-names:
> +          items:
> +            - const: l2sram
> +            - const: l1dram
> +
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - ti,am62a-c7xv-dsp
> +    then:
> +      properties:
> +        reg:
> +          items:
> +            - description: Address and Size of the L2 SRAM internal memory region
> +        reg-names:
> +          items:
> +            - const: l2sram
> +
> +  - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#
>  
>  required:
>    - compatible
> -- 
> 2.34.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-06-10 17:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04 17:14 [PATCH v3] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs Hari Nagalla
2024-06-04 17:14 ` Hari Nagalla
2024-06-05  7:20 ` Krzysztof Kozlowski
2024-06-05  7:20   ` Krzysztof Kozlowski
2024-06-10 17:26 ` Mathieu Poirier [this message]
2024-06-10 17:26   ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zmc3O+mAP8v9GVQl@p14s \
    --to=mathieu.poirier@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hnagalla@ti.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s-anna@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.