Re: [Buildroot] [PATCH v2 5/5] package/versal-firmware: remove package

From: Brandon Maier via buildroot <buildroot@buildroot.org>
To: Neal Frager via buildroot <buildroot@buildroot.org>
Cc: ibai.erkiaga-elorza@amd.com, luca.ceresoli@bootlin.com,
	thomas.petazzoni@bootlin.com, Neal Frager <neal.frager@amd.com>,
	michal.simek@amd.com, yann.morin.1998@free.fr
Subject: Re: [Buildroot] [PATCH v2 5/5] package/versal-firmware: remove package
Date: Thu, 13 Jun 2024 12:33:41 +0000	[thread overview]
Message-ID: <ZmrnJSnDKpdPsJxl@bspbox.kirk> (raw)
In-Reply-To: <20240613061423.1737631-5-neal.frager@amd.com>

On 2024.06.13 07:14, Neal Frager via buildroot wrote:
> This patch removes the package/versal-firmware as this package is replaced
> by the boot/xilinx-prebuilt target boot firmware package.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>

Reviewed-by: Brandon Maier <brandon.maier@collins.com>

> ---
> V1->V2:
>  - no changes
> ---
>  DEVELOPERS                                    |  1 -
>  .../versal-firmware/versal-firmware.hash      |  2 --
>  package/Config.in                             |  1 -
>  package/versal-firmware/Config.in             | 24 -------------------
>  package/versal-firmware/versal-firmware.mk    | 21 ----------------
>  5 files changed, 49 deletions(-)
>  delete mode 100644 board/xilinx/patches/versal-firmware/versal-firmware.hash
>  delete mode 100644 package/versal-firmware/Config.in
>  delete mode 100644 package/versal-firmware/versal-firmware.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 93627a0064..e5706e493b 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2352,7 +2352,6 @@ F:	package/binutils-bare-metal/
>  F:	package/bootgen/
>  F:	package/gcc-bare-metal/
>  F:	package/newlib-bare-metal/
> -F:	package/versal-firmware/
>  F:	toolchain/toolchain-bare-metal-buildroot/
>  
>  N:	Nicola Di Lieto <nicola.dilieto@gmail.com>
> diff --git a/board/xilinx/patches/versal-firmware/versal-firmware.hash b/board/xilinx/patches/versal-firmware/versal-firmware.hash
> deleted file mode 100644
> index c4d745f22c..0000000000
> --- a/board/xilinx/patches/versal-firmware/versal-firmware.hash
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -# Locally calculated
> -sha256  7abcba4e0e44e3a4adf9c1f971d918575226d7604dfd64a386baaa00c1c6c35f  versal-firmware-xilinx_v2024.1.tar.gz
> diff --git a/package/Config.in b/package/Config.in
> index 1b6a5b0dab..13af2978dd 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -460,7 +460,6 @@ menu "Firmware"
>  	source "package/sunxi-boards/Config.in"
>  	source "package/ts4900-fpga/Config.in"
>  	source "package/ux500-firmware/Config.in"
> -	source "package/versal-firmware/Config.in"
>  	source "package/wilc-firmware/Config.in"
>  	source "package/wilink-bt-firmware/Config.in"
>  	source "package/zd1211-firmware/Config.in"
> diff --git a/package/versal-firmware/Config.in b/package/versal-firmware/Config.in
> deleted file mode 100644
> index 01daefd204..0000000000
> --- a/package/versal-firmware/Config.in
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -config BR2_PACKAGE_VERSAL_FIRMWARE
> -	bool "versal-firmware"
> -	depends on BR2_aarch64
> -	help
> -	  Pre-built firmware files for Xilinx Versal boards.
> -
> -	  https://github.com/Xilinx/soc-prebuilt-firmware
> -
> -if BR2_PACKAGE_VERSAL_FIRMWARE
> -
> -config BR2_PACKAGE_VERSAL_FIRMWARE_VERSION
> -	string "firmware version"
> -	default "xilinx_v2023.1"
> -	help
> -	  Release version of Versal firmware.
> -
> -config BR2_PACKAGE_VERSAL_FIRMWARE_BOARD
> -	string "board name"
> -	default "vck190"
> -	help
> -	  Name of Versal target board.
> -	  Used for installing the appropriate firmware.
> -
> -endif # BR2_PACKAGE_VERSAL_FIRMWARE
> diff --git a/package/versal-firmware/versal-firmware.mk b/package/versal-firmware/versal-firmware.mk
> deleted file mode 100644
> index 1ced259be1..0000000000
> --- a/package/versal-firmware/versal-firmware.mk
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -################################################################################
> -#
> -# versal-firmware
> -#
> -################################################################################
> -
> -VERSAL_FIRMWARE_VERSION = $(call qstrip,$(BR2_PACKAGE_VERSAL_FIRMWARE_VERSION))
> -VERSAL_FIRMWARE_SITE = $(call github,Xilinx,soc-prebuilt-firmware,$(VERSAL_FIRMWARE_VERSION))
> -VERSAL_FIRMWARE_LICENSE = MIT
> -VERSAL_FIRMWARE_LICENSE_FILES = LICENSE
> -VERSAL_FIRMWARE_INSTALL_TARGET = NO
> -VERSAL_FIRMWARE_INSTALL_IMAGES = YES
> -
> -define VERSAL_FIRMWARE_INSTALL_IMAGES_CMDS
> -	$(foreach f,plm.elf psmfw.elf vpl_gen_fixed.pdi,\
> -		$(INSTALL) -D -m 0755 $(@D)/$(BR2_PACKAGE_VERSAL_FIRMWARE_BOARD)-versal/$(f) \
> -			$(BINARIES_DIR)/$(f)
> -	)
> -endef
> -
> -$(eval $(generic-package))
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot