From: Ido Schimmel <idosch@idosch.org>
To: Adrian Moreno <amorenoz@redhat.com>
Cc: netdev@vger.kernel.org, aconole@redhat.com, echaudro@redhat.com,
horms@kernel.org, i.maximets@ovn.org, dev@openvswitch.org,
Yotam Gigi <yotam.gi@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 03/10] net: psample: skip packet copy if no listeners
Date: Wed, 26 Jun 2024 10:18:46 +0300 [thread overview]
Message-ID: <ZnvA1l3dhtj9MP6X@shredder.mtl.com> (raw)
In-Reply-To: <20240625205204.3199050-4-amorenoz@redhat.com>
On Tue, Jun 25, 2024 at 10:51:46PM +0200, Adrian Moreno wrote:
> If nobody is listening on the multicast group, generating the sample,
> which involves copying packet data, seems completely unnecessary.
>
> Return fast in this case.
>
> Reviewed-by: Simon Horman <horms@kernel.org>
> Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2024-06-26 7:18 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 20:51 [PATCH net-next v5 00/10] net: openvswitch: Add sample multicasting Adrian Moreno
2024-06-25 20:51 ` [PATCH net-next v5 01/10] net: psample: add user cookie Adrian Moreno
2024-06-26 7:15 ` Ido Schimmel
2024-06-26 14:27 ` Eelco Chaudron
2024-06-25 20:51 ` [PATCH net-next v5 02/10] net: sched: act_sample: add action cookie to sample Adrian Moreno
2024-06-26 7:17 ` Ido Schimmel
2024-06-26 14:28 ` Eelco Chaudron
2024-06-26 20:06 ` Adrián Moreno
2024-06-27 7:13 ` Eelco Chaudron
2024-06-25 20:51 ` [PATCH net-next v5 03/10] net: psample: skip packet copy if no listeners Adrian Moreno
2024-06-26 7:18 ` Ido Schimmel [this message]
2024-06-26 14:28 ` Eelco Chaudron
2024-06-25 20:51 ` [PATCH net-next v5 04/10] net: psample: allow using rate as probability Adrian Moreno
2024-06-26 7:26 ` Ido Schimmel
2024-06-26 14:28 ` Eelco Chaudron
2024-06-25 20:51 ` [PATCH net-next v5 05/10] net: openvswitch: add emit_sample action Adrian Moreno
2024-06-26 10:51 ` Ilya Maximets
2024-06-26 20:07 ` Adrián Moreno
2024-06-27 7:44 ` Ilya Maximets
2024-06-26 14:28 ` Eelco Chaudron
2024-06-26 20:34 ` Adrián Moreno
2024-06-27 7:06 ` Eelco Chaudron
2024-06-27 7:52 ` Adrián Moreno
2024-06-27 8:36 ` Ilya Maximets
2024-06-27 9:14 ` Eelco Chaudron
2024-06-27 9:23 ` Ilya Maximets
2024-06-27 9:31 ` Eelco Chaudron
2024-06-27 10:15 ` Adrián Moreno
2024-06-27 10:52 ` Ilya Maximets
2024-06-27 13:30 ` Aaron Conole
2024-06-27 13:48 ` Adrián Moreno
2024-06-28 14:37 ` Aaron Conole
2024-06-27 13:30 ` Eelco Chaudron
2024-06-25 20:51 ` [PATCH net-next v5 06/10] net: openvswitch: store sampling probability in cb Adrian Moreno
2024-06-26 10:52 ` Ilya Maximets
2024-06-26 14:28 ` Eelco Chaudron
2024-06-25 20:51 ` [PATCH net-next v5 07/10] selftests: openvswitch: add emit_sample action Adrian Moreno
2024-06-26 14:31 ` Aaron Conole
2024-06-25 20:51 ` [PATCH net-next v5 08/10] selftests: openvswitch: add userspace parsing Adrian Moreno
2024-06-26 14:32 ` Aaron Conole
2024-06-25 20:51 ` [PATCH net-next v5 09/10] selftests: openvswitch: parse trunc action Adrian Moreno
2024-06-26 14:21 ` Aaron Conole
2024-06-25 20:51 ` [PATCH net-next v5 10/10] selftests: openvswitch: add emit_sample test Adrian Moreno
2024-06-26 11:15 ` Ilya Maximets
2024-06-27 7:58 ` Adrián Moreno
2024-06-26 14:27 ` [PATCH net-next v5 00/10] net: openvswitch: Add sample multicasting Eelco Chaudron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnvA1l3dhtj9MP6X@shredder.mtl.com \
--to=idosch@idosch.org \
--cc=aconole@redhat.com \
--cc=amorenoz@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yotam.gi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.