All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: linux@armlinux.org.uk, vgoyal@redhat.com, dyoung@redhat.com,
	paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, arnd@arndb.de, afd@ti.com,
	akpm@linux-foundation.org, rmk+kernel@armlinux.org.uk,
	linus.walleij@linaro.org, eric.devolder@oracle.com,
	gregkh@linuxfoundation.org, deller@gmx.de, javierm@redhat.com,
	robh@kernel.org, thunder.leizhen@huawei.com,
	austindh.kim@gmail.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kexec@lists.infradead.org
Subject: Re: [PATCH 0/3] ARM: Use generic interface to simplify crashkernel reservation
Date: Tue, 9 Jul 2024 17:29:45 +0800	[thread overview]
Message-ID: <Zo0DCVXvCryDr7WN@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20240708133348.3592667-1-ruanjinjie@huawei.com>

On 07/08/24 at 09:33pm, Jinjie Ruan wrote:
> Currently, x86, arm64, riscv and loongarch has been switched to generic
> crashkernel reservation. Also use generic interface to simplify crashkernel
> reservation for arm32, and fix two bugs by the way.

I am not sure if this is a good idea. I added the generic reservation
itnerfaces for ARCH which support crashkernel=,high|low and normal
crashkernel reservation, with this, the code can be simplified a lot.
However, arm32 doesn't support crashkernel=,high, I am not sure if it's
worth taking the change, most importantly, if it will cause
misunderstanding or misoperation.

Thanks
Baoquan


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: linux@armlinux.org.uk, vgoyal@redhat.com, dyoung@redhat.com,
	paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, arnd@arndb.de, afd@ti.com,
	akpm@linux-foundation.org, rmk+kernel@armlinux.org.uk,
	linus.walleij@linaro.org, eric.devolder@oracle.com,
	gregkh@linuxfoundation.org, deller@gmx.de, javierm@redhat.com,
	robh@kernel.org, thunder.leizhen@huawei.com,
	austindh.kim@gmail.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kexec@lists.infradead.org
Subject: Re: [PATCH 0/3] ARM: Use generic interface to simplify crashkernel reservation
Date: Tue, 9 Jul 2024 17:29:45 +0800	[thread overview]
Message-ID: <Zo0DCVXvCryDr7WN@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20240708133348.3592667-1-ruanjinjie@huawei.com>

On 07/08/24 at 09:33pm, Jinjie Ruan wrote:
> Currently, x86, arm64, riscv and loongarch has been switched to generic
> crashkernel reservation. Also use generic interface to simplify crashkernel
> reservation for arm32, and fix two bugs by the way.

I am not sure if this is a good idea. I added the generic reservation
itnerfaces for ARCH which support crashkernel=,high|low and normal
crashkernel reservation, with this, the code can be simplified a lot.
However, arm32 doesn't support crashkernel=,high, I am not sure if it's
worth taking the change, most importantly, if it will cause
misunderstanding or misoperation.

Thanks
Baoquan



  parent reply	other threads:[~2024-07-09  9:30 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-08 13:33 [PATCH 0/3] ARM: Use generic interface to simplify crashkernel reservation Jinjie Ruan
2024-07-08 13:33 ` Jinjie Ruan
2024-07-08 13:33 ` [PATCH 1/3] crash: Fix memory reserve dead loop bug in reserve_crashkernel_generic() Jinjie Ruan
2024-07-08 13:33   ` Jinjie Ruan
2024-08-05  7:15   ` Linus Walleij
2024-08-05  7:15     ` Linus Walleij
2024-07-08 13:33 ` [PATCH 2/3] ARM: Fix crash kenrel data type bug Jinjie Ruan
2024-07-08 13:33   ` Jinjie Ruan
2024-08-05  7:14   ` Linus Walleij
2024-08-05  7:14     ` Linus Walleij
2024-07-08 13:33 ` [PATCH 3/3] ARM: Use generic interface to simplify crashkernel reservation Jinjie Ruan
2024-07-08 13:33   ` Jinjie Ruan
2024-07-09  9:29 ` Baoquan He [this message]
2024-07-09  9:29   ` [PATCH 0/3] " Baoquan He
2024-07-09  9:50   ` Jinjie Ruan
2024-07-09  9:50     ` Jinjie Ruan
2024-07-09 10:39     ` Baoquan He
2024-07-09 10:39       ` Baoquan He
2024-07-09 11:06       ` Jinjie Ruan
2024-07-09 11:06         ` Jinjie Ruan
2024-07-09 14:06         ` Baoquan He
2024-07-09 14:06           ` Baoquan He
2024-07-10  1:52           ` Jinjie Ruan
2024-07-10  1:52             ` Jinjie Ruan
2024-07-10  3:40             ` Baoquan He
2024-07-10  3:40               ` Baoquan He
2024-07-11  6:30   ` Jinjie Ruan
2024-07-11  6:30     ` Jinjie Ruan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zo0DCVXvCryDr7WN@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=afd@ti.com \
    --cc=akpm@linux-foundation.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=arnd@arndb.de \
    --cc=austindh.kim@gmail.com \
    --cc=deller@gmx.de \
    --cc=dyoung@redhat.com \
    --cc=eric.devolder@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=javierm@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=robh@kernel.org \
    --cc=ruanjinjie@huawei.com \
    --cc=thunder.leizhen@huawei.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.