From: Sudeep Holla <sudeep.holla@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Huang Rui <ray.huang@amd.com>,
Sudeep Holla <sudeep.holla@arm.com>,
"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Perry Yuan <perry.yuan@amd.com>, Hector Martin <marcan@marcan.st>,
Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Markus Mayer <mmayer@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Len Brown <lenb@kernel.org>, Kevin Hilman <khilman@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Cristian Marussi <cristian.marussi@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Lizhe <sensor1010@163.com>,
linux-kernel@vger.kernel.org, asahi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-arm-msm@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void
Date: Thu, 4 Jul 2024 10:26:25 +0100 [thread overview]
Message-ID: <ZoZqwb8LdQQohQHM@bogus> (raw)
In-Reply-To: <3f73fda736818128558b61ad5fe2bed5dce3ddc4.1720075640.git.viresh.kumar@linaro.org>
On Thu, Jul 04, 2024 at 12:23:55PM +0530, Viresh Kumar wrote:
> From: Lizhe <sensor1010@163.com>
>
> The cpufreq core doesn't check the return type of the exit() callback
> and there is not much the core can do on failures at that point. Just
> drop the returned value and make it return void.
>
> Signed-off-by: Lizhe <sensor1010@163.com>
> [ Viresh: Reworked the patches to fix all missing changes together. ]
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
[...]
> drivers/cpufreq/scmi-cpufreq.c | 4 +---
> drivers/cpufreq/scpi-cpufreq.c | 4 +---
> drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++---
(For the above 3 files)
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
linux-tegra@vger.kernel.org, Perry Yuan <perry.yuan@amd.com>,
Huang Rui <ray.huang@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Vincent Guittot <vincent.guittot@linaro.org>,
Kevin Hilman <khilman@kernel.org>,
linux-pm@vger.kernel.org,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Jonathan Hunter <jonathanh@nvidia.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Len Brown <lenb@kernel.org>, Sven Peter <sven@svenpeter.dev>,
Lizhe <sensor1010@163.com>, Nicholas Piggin <npiggin@gmail.com>,
linux-mediatek@lists.infradead.org,
Markus Mayer <mmayer@broadcom.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-omap@vger.kernel.org,
Cristian Marussi <cristian.marussi@arm.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Hector Martin <marcan@marcan.st>,
linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
asahi@lists.linux.dev,
"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
Sudeep Holla <sudeep.holla@arm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void
Date: Thu, 4 Jul 2024 10:26:25 +0100 [thread overview]
Message-ID: <ZoZqwb8LdQQohQHM@bogus> (raw)
In-Reply-To: <3f73fda736818128558b61ad5fe2bed5dce3ddc4.1720075640.git.viresh.kumar@linaro.org>
On Thu, Jul 04, 2024 at 12:23:55PM +0530, Viresh Kumar wrote:
> From: Lizhe <sensor1010@163.com>
>
> The cpufreq core doesn't check the return type of the exit() callback
> and there is not much the core can do on failures at that point. Just
> drop the returned value and make it return void.
>
> Signed-off-by: Lizhe <sensor1010@163.com>
> [ Viresh: Reworked the patches to fix all missing changes together. ]
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
[...]
> drivers/cpufreq/scmi-cpufreq.c | 4 +---
> drivers/cpufreq/scpi-cpufreq.c | 4 +---
> drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++---
(For the above 3 files)
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
next prev parent reply other threads:[~2024-07-04 9:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 6:53 [PATCH 0/4] cpufreq: Make cpufreq_driver->exit() return void Viresh Kumar
2024-07-04 6:53 ` Viresh Kumar
2024-07-04 6:53 ` [PATCH 1/4] cpufreq: nforce2: Remove empty exit() callback Viresh Kumar
2024-07-04 6:53 ` [PATCH 2/4] cpufreq: loongson2: " Viresh Kumar
2024-07-04 9:36 ` Huacai Chen
2024-07-04 6:53 ` [PATCH 3/4] cpufreq: pcc: " Viresh Kumar
2024-07-04 6:53 ` [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void Viresh Kumar
2024-07-04 6:53 ` Viresh Kumar
2024-07-04 8:27 ` AngeloGioacchino Del Regno
2024-07-04 8:27 ` AngeloGioacchino Del Regno
2024-07-04 9:26 ` Sudeep Holla [this message]
2024-07-04 9:26 ` Sudeep Holla
2024-07-04 11:56 ` Mario Limonciello
2024-07-04 11:56 ` Mario Limonciello
2024-07-04 14:42 ` Florian Fainelli
2024-07-04 14:42 ` Florian Fainelli
2024-07-09 0:24 ` Kevin Hilman
2024-07-09 0:24 ` Kevin Hilman
2024-07-04 12:02 ` [PATCH 0/4] " Rafael J. Wysocki
2024-07-04 12:02 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoZqwb8LdQQohQHM@bogus \
--to=sudeep.holla@arm.com \
--cc=alyssa@rosenzweig.io \
--cc=angelogioacchino.delregno@collabora.com \
--cc=asahi@lists.linux.dev \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christophe.leroy@csgroup.eu \
--cc=cristian.marussi@arm.com \
--cc=gautham.shenoy@amd.com \
--cc=jonathanh@nvidia.com \
--cc=khilman@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=marcan@marcan.st \
--cc=mario.limonciello@amd.com \
--cc=matthias.bgg@gmail.com \
--cc=mmayer@broadcom.com \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=perry.yuan@amd.com \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=sensor1010@163.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=sven@svenpeter.dev \
--cc=thierry.reding@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.