From: Baoquan He <bhe@redhat.com>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org,
chenhuacai@kernel.org, kernel@xen0n.name,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
vgoyal@redhat.com, dyoung@redhat.com, arnd@arndb.de, afd@ti.com,
akpm@linux-foundation.org, linus.walleij@linaro.org,
eric.devolder@oracle.com, gregkh@linuxfoundation.org,
javierm@redhat.com, deller@gmx.de, robh@kernel.org,
thunder.leizhen@huawei.com, hbathini@linux.ibm.com,
tangyouling@kylinos.cn, chenjiahao16@huawei.com,
kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 3/3] ARM: Use generic interface to simplify crashkernel reservation
Date: Mon, 22 Jul 2024 09:38:19 +0800 [thread overview]
Message-ID: <Zp24C4ZkWI4g21FK@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20240719095735.1912878-4-ruanjinjie@huawei.com>
On 07/19/24 at 05:57pm, Jinjie Ruan wrote:
> Currently, x86, arm64, riscv and loongarch has been switched to generic
> crashkernel reservation, which is also ready for 32bit system.
> So with the help of function parse_crashkernel() and generic
> reserve_crashkernel_generic(), arm32 crashkernel reservation can also
> be simplified by steps:
>
> 1) Add a new header file <asm/crash_reserve.h>, and define CRASH_ALIGN,
> CRASH_ADDR_LOW_MAX, CRASH_ADDR_HIGH_MAX in it;
>
> 2) Add arch_reserve_crashkernel() to call parse_crashkernel() and
> reserve_crashkernel_generic();
>
> 3) Add ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION Kconfig in
> arch/arm/Kconfig.
>
> The old reserve_crashkernel() can be removed.
>
> Following test cases have been performed as expected on QEMU vexpress-a9
> (1GB system memory):
>
> 1) crashkernel=4G,high // invalid
> 2) crashkernel=1G,high // invalid
> 3) crashkernel=1G,high crashkernel=0M,low // invalid
> 4) crashkernel=256M,high // invalid
> 5) crashkernel=256M,low // invalid
> 6) crashkernel=256M crashkernel=256M,high // high is ignored, ok
> 7) crashkernel=256M crashkernel=256M,low // low is ignored, ok
> 8) crashkernel=256M,high crashkernel=256M,low // invalid
> 9) crashkernel=256M,high crashkernel=4G,low // invalid
> 10) crashkernel=256M // ok
> 11) crashkernel=512M // ok
> 12) crashkernel=256M@0x88000000 // ok
> 13) crashkernel=256M@0x78000000 // ok
> 14) crashkernel=512M@0x78000000 // ok
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> v4:
> - Remove the Tested-by as suggested.
> v3:
> - Update the commit message.
> ---
> arch/arm/Kconfig | 3 ++
> arch/arm/include/asm/crash_reserve.h | 24 +++++++++++
> arch/arm/kernel/setup.c | 63 ++++------------------------
> 3 files changed, 36 insertions(+), 54 deletions(-)
> create mode 100644 arch/arm/include/asm/crash_reserve.h
LGTM,
Acked-by: Baoquan He <bhe@redhat.com>
By the way, you may need respost the parsed crashkernel value limitation
checking patch for arm32 and i386.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org,
chenhuacai@kernel.org, kernel@xen0n.name,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
vgoyal@redhat.com, dyoung@redhat.com, arnd@arndb.de, afd@ti.com,
akpm@linux-foundation.org, linus.walleij@linaro.org,
eric.devolder@oracle.com, gregkh@linuxfoundation.org,
javierm@redhat.com, deller@gmx.de, robh@kernel.org,
thunder.leizhen@huawei.com, hbathini@linux.ibm.com,
tangyouling@kylinos.cn, chenjiahao16@huawei.com,
kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 3/3] ARM: Use generic interface to simplify crashkernel reservation
Date: Mon, 22 Jul 2024 09:38:19 +0800 [thread overview]
Message-ID: <Zp24C4ZkWI4g21FK@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20240719095735.1912878-4-ruanjinjie@huawei.com>
On 07/19/24 at 05:57pm, Jinjie Ruan wrote:
> Currently, x86, arm64, riscv and loongarch has been switched to generic
> crashkernel reservation, which is also ready for 32bit system.
> So with the help of function parse_crashkernel() and generic
> reserve_crashkernel_generic(), arm32 crashkernel reservation can also
> be simplified by steps:
>
> 1) Add a new header file <asm/crash_reserve.h>, and define CRASH_ALIGN,
> CRASH_ADDR_LOW_MAX, CRASH_ADDR_HIGH_MAX in it;
>
> 2) Add arch_reserve_crashkernel() to call parse_crashkernel() and
> reserve_crashkernel_generic();
>
> 3) Add ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION Kconfig in
> arch/arm/Kconfig.
>
> The old reserve_crashkernel() can be removed.
>
> Following test cases have been performed as expected on QEMU vexpress-a9
> (1GB system memory):
>
> 1) crashkernel=4G,high // invalid
> 2) crashkernel=1G,high // invalid
> 3) crashkernel=1G,high crashkernel=0M,low // invalid
> 4) crashkernel=256M,high // invalid
> 5) crashkernel=256M,low // invalid
> 6) crashkernel=256M crashkernel=256M,high // high is ignored, ok
> 7) crashkernel=256M crashkernel=256M,low // low is ignored, ok
> 8) crashkernel=256M,high crashkernel=256M,low // invalid
> 9) crashkernel=256M,high crashkernel=4G,low // invalid
> 10) crashkernel=256M // ok
> 11) crashkernel=512M // ok
> 12) crashkernel=256M@0x88000000 // ok
> 13) crashkernel=256M@0x78000000 // ok
> 14) crashkernel=512M@0x78000000 // ok
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> v4:
> - Remove the Tested-by as suggested.
> v3:
> - Update the commit message.
> ---
> arch/arm/Kconfig | 3 ++
> arch/arm/include/asm/crash_reserve.h | 24 +++++++++++
> arch/arm/kernel/setup.c | 63 ++++------------------------
> 3 files changed, 36 insertions(+), 54 deletions(-)
> create mode 100644 arch/arm/include/asm/crash_reserve.h
LGTM,
Acked-by: Baoquan He <bhe@redhat.com>
By the way, you may need respost the parsed crashkernel value limitation
checking patch for arm32 and i386.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org,
chenhuacai@kernel.org, kernel@xen0n.name,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
vgoyal@redhat.com, dyoung@redhat.com, arnd@arndb.de, afd@ti.com,
akpm@linux-foundation.org, linus.walleij@linaro.org,
eric.devolder@oracle.com, gregkh@linuxfoundation.org,
javierm@redhat.com, deller@gmx.de, robh@kernel.org,
thunder.leizhen@huawei.com, hbathini@linux.ibm.com,
tangyouling@kylinos.cn, chenjiahao16@huawei.com,
kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 3/3] ARM: Use generic interface to simplify crashkernel reservation
Date: Mon, 22 Jul 2024 09:38:19 +0800 [thread overview]
Message-ID: <Zp24C4ZkWI4g21FK@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20240719095735.1912878-4-ruanjinjie@huawei.com>
On 07/19/24 at 05:57pm, Jinjie Ruan wrote:
> Currently, x86, arm64, riscv and loongarch has been switched to generic
> crashkernel reservation, which is also ready for 32bit system.
> So with the help of function parse_crashkernel() and generic
> reserve_crashkernel_generic(), arm32 crashkernel reservation can also
> be simplified by steps:
>
> 1) Add a new header file <asm/crash_reserve.h>, and define CRASH_ALIGN,
> CRASH_ADDR_LOW_MAX, CRASH_ADDR_HIGH_MAX in it;
>
> 2) Add arch_reserve_crashkernel() to call parse_crashkernel() and
> reserve_crashkernel_generic();
>
> 3) Add ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION Kconfig in
> arch/arm/Kconfig.
>
> The old reserve_crashkernel() can be removed.
>
> Following test cases have been performed as expected on QEMU vexpress-a9
> (1GB system memory):
>
> 1) crashkernel=4G,high // invalid
> 2) crashkernel=1G,high // invalid
> 3) crashkernel=1G,high crashkernel=0M,low // invalid
> 4) crashkernel=256M,high // invalid
> 5) crashkernel=256M,low // invalid
> 6) crashkernel=256M crashkernel=256M,high // high is ignored, ok
> 7) crashkernel=256M crashkernel=256M,low // low is ignored, ok
> 8) crashkernel=256M,high crashkernel=256M,low // invalid
> 9) crashkernel=256M,high crashkernel=4G,low // invalid
> 10) crashkernel=256M // ok
> 11) crashkernel=512M // ok
> 12) crashkernel=256M@0x88000000 // ok
> 13) crashkernel=256M@0x78000000 // ok
> 14) crashkernel=512M@0x78000000 // ok
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> v4:
> - Remove the Tested-by as suggested.
> v3:
> - Update the commit message.
> ---
> arch/arm/Kconfig | 3 ++
> arch/arm/include/asm/crash_reserve.h | 24 +++++++++++
> arch/arm/kernel/setup.c | 63 ++++------------------------
> 3 files changed, 36 insertions(+), 54 deletions(-)
> create mode 100644 arch/arm/include/asm/crash_reserve.h
LGTM,
Acked-by: Baoquan He <bhe@redhat.com>
By the way, you may need respost the parsed crashkernel value limitation
checking patch for arm32 and i386.
next prev parent reply other threads:[~2024-07-22 1:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 9:57 [PATCH v4 0/3] crash: Fix x86_32 memory reserve dead loop bug Jinjie Ruan
2024-07-19 9:57 ` Jinjie Ruan
2024-07-19 9:57 ` Jinjie Ruan
2024-07-19 9:57 ` [PATCH v4 1/3] crash: Fix x86_32 crash " Jinjie Ruan
2024-07-19 9:57 ` Jinjie Ruan
2024-07-19 9:57 ` Jinjie Ruan
2024-07-19 9:57 ` [PATCH v4 2/3] crash: Fix x86_32 crash memory reserve dead loop Jinjie Ruan
2024-07-19 9:57 ` Jinjie Ruan
2024-07-19 9:57 ` Jinjie Ruan
2024-07-19 12:29 ` Baoquan He
2024-07-19 12:29 ` Baoquan He
2024-07-19 12:29 ` Baoquan He
2024-07-19 9:57 ` [PATCH v4 3/3] ARM: Use generic interface to simplify crashkernel reservation Jinjie Ruan
2024-07-19 9:57 ` Jinjie Ruan
2024-07-19 9:57 ` Jinjie Ruan
2024-07-22 1:38 ` Baoquan He [this message]
2024-07-22 1:38 ` Baoquan He
2024-07-22 1:38 ` Baoquan He
2024-07-22 1:52 ` Jinjie Ruan
2024-07-22 1:52 ` Jinjie Ruan
2024-07-22 1:52 ` Jinjie Ruan
2024-07-25 1:25 ` [PATCH v4 0/3] crash: Fix x86_32 memory reserve dead loop bug Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zp24C4ZkWI4g21FK@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=afd@ti.com \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chenjiahao16@huawei.com \
--cc=dave.hansen@linux.intel.com \
--cc=deller@gmx.de \
--cc=dyoung@redhat.com \
--cc=eric.devolder@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=hbathini@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=javierm@redhat.com \
--cc=kernel@xen0n.name \
--cc=kexec@lists.infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=tangyouling@kylinos.cn \
--cc=tglx@linutronix.de \
--cc=thunder.leizhen@huawei.com \
--cc=vgoyal@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.