All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: lee@kernel.org, jdelvare@suse.com, linux@roeck-us.net,
	pavel@ucw.cz, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, ukleinek@debian.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-hwmon@vger.kernel.org,
	linux-input@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v3 4/7] Input: add driver for the input part of qnap-mcu devices
Date: Fri, 2 Aug 2024 22:26:18 -0700	[thread overview]
Message-ID: <Zq2_evktLN3MZaGF@google.com> (raw)
In-Reply-To: <20240731212430.2677900-5-heiko@sntech.de>

On Wed, Jul 31, 2024 at 11:24:27PM +0200, Heiko Stuebner wrote:
> The MCU controls the power-button and beeper, so expose them as input
> device. There is of course no interrupt line, so the status of the
> power-button needs to be polled. To generate an event the power-button
> also needs to be held for 1-2 seconds, so the polling interval does
> not need to be overly fast.
> 
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Feel free to merge with the rest of the patches.

Thanks.

-- 
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: lee@kernel.org, jdelvare@suse.com, linux@roeck-us.net,
	pavel@ucw.cz, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, ukleinek@debian.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-hwmon@vger.kernel.org,
	linux-input@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v3 4/7] Input: add driver for the input part of qnap-mcu devices
Date: Fri, 2 Aug 2024 22:26:18 -0700	[thread overview]
Message-ID: <Zq2_evktLN3MZaGF@google.com> (raw)
In-Reply-To: <20240731212430.2677900-5-heiko@sntech.de>

On Wed, Jul 31, 2024 at 11:24:27PM +0200, Heiko Stuebner wrote:
> The MCU controls the power-button and beeper, so expose them as input
> device. There is of course no interrupt line, so the status of the
> power-button needs to be polled. To generate an event the power-button
> also needs to be held for 1-2 seconds, so the polling interval does
> not need to be overly fast.
> 
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Feel free to merge with the rest of the patches.

Thanks.

-- 
Dmitry

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2024-08-03  5:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31 21:24 [PATCH v3 0/7] Drivers to support the MCU on QNAP NAS devices Heiko Stuebner
2024-07-31 21:24 ` Heiko Stuebner
2024-07-31 21:24 ` [PATCH v3 1/7] dt-bindings: mfd: add binding for qnap,ts433-mcu devices Heiko Stuebner
2024-07-31 21:24   ` Heiko Stuebner
2024-08-05 19:17   ` Rob Herring
2024-08-05 19:17     ` Rob Herring
2024-08-07  9:34     ` Heiko Stübner
2024-08-07  9:34       ` Heiko Stübner
2024-07-31 21:24 ` [PATCH v3 2/7] mfd: add base driver for qnap-mcu devices Heiko Stuebner
2024-07-31 21:24   ` Heiko Stuebner
2024-08-02 17:16   ` kernel test robot
2024-08-02 17:16     ` kernel test robot
2024-08-04  1:21   ` kernel test robot
2024-08-04  1:21     ` kernel test robot
2024-07-31 21:24 ` [PATCH v3 3/7] leds: add driver for LEDs from " Heiko Stuebner
2024-07-31 21:24   ` Heiko Stuebner
2024-07-31 21:24 ` [PATCH v3 4/7] Input: add driver for the input part of " Heiko Stuebner
2024-07-31 21:24   ` Heiko Stuebner
2024-08-03  5:26   ` Dmitry Torokhov [this message]
2024-08-03  5:26     ` Dmitry Torokhov
2024-07-31 21:24 ` [PATCH v3 5/7] hwmon: add driver for the hwmon parts " Heiko Stuebner
2024-07-31 21:24   ` Heiko Stuebner
2024-07-31 21:24 ` [PATCH v3 6/7] arm64: dts: rockchip: hook up the MCU on the QNAP TS433 Heiko Stuebner
2024-07-31 21:24   ` Heiko Stuebner
2024-07-31 21:24 ` [PATCH v3 7/7] arm64: dts: rockchip: set hdd led labels on qnap-ts433 Heiko Stuebner
2024-07-31 21:24   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zq2_evktLN3MZaGF@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=jdelvare@suse.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=pavel@ucw.cz \
    --cc=robh@kernel.org \
    --cc=ukleinek@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.