mach-crag6410.c staying or going?

mach-crag6410.c staying or going?

[Dmitry Torokhov]

Hi,

I would like to remove platform data suppirt from samsung-keypad driver;
mach-crag6410.c is the only user of samsung_keypad_platdata structure.

I started converting it to software nodes, but I noticed the following
message:

../arch/arm/mach-s3c/s3c64xx.c:423:9: note: '#pragma message: The
platform is deprecated and scheduled for removal. Please reach to the
maintainers of the platform and linux-samsung-soc@vger.kernel.org if you
still use it.Without such feedback, the platform will be removed after
2024.'

So is this board/platform being dropped? If so when?

Thanks.

-- 
Dmitry

Re: mach-crag6410.c staying or going?

[Krzysztof Kozlowski]

On 31/07/2024 04:42, Dmitry Torokhov wrote:
> Hi,
> 
> I would like to remove platform data suppirt from samsung-keypad driver;
> mach-crag6410.c is the only user of samsung_keypad_platdata structure.
> 
> I started converting it to software nodes, but I noticed the following
> message:
> 
> ../arch/arm/mach-s3c/s3c64xx.c:423:9: note: '#pragma message: The
> platform is deprecated and scheduled for removal. Please reach to the
> maintainers of the platform and linux-samsung-soc@vger.kernel.org if you
> still use it.Without such feedback, the platform will be removed after
> 2024.'
> 
> So is this board/platform being dropped? If so when?

get_maintainers.pl would tell you whom to Cc... yeah, platform will go
away some day. Maybe when last board @Mark get broken? We do not have
specific deadline, but I don't think it is worth keeping it past 2025.


Best regards,
Krzysztof

Re: mach-crag6410.c staying or going?

[Arnd Bergmann]

On Wed, Jul 31, 2024, at 04:42, Dmitry Torokhov wrote:
> Hi,
>
> I would like to remove platform data suppirt from samsung-keypad driver;
> mach-crag6410.c is the only user of samsung_keypad_platdata structure.
>
> I started converting it to software nodes, but I noticed the following
> message:
>
> ../arch/arm/mach-s3c/s3c64xx.c:423:9: note: '#pragma message: The
> platform is deprecated and scheduled for removal. Please reach to the
> maintainers of the platform and linux-samsung-soc@vger.kernel.org if you
> still use it.Without such feedback, the platform will be removed after
> 2024.'
>
> So is this board/platform being dropped? If so when?

Unfortunately we are a bit stuck here and there is no good answer
for it. I think this board file is holding up more cleanups than
any other and I'd love to get rid of it, but Mark is still using
the machine, and probably relies on it more than anyone else
needs the other board files.

My personal impression is that yes, we will drop the board, just
not at the current timeline but following a later LTS kernel (
early 2026 or early 2027).

I have a list of all the other board file categories and how
long I expect them to be needed for, and should send that out
for further discussion now that rc1 is out.

My best estimate is that we can try to drop about 30 of the
remaining 40 board files in linux-6.13, and then keep chipping
away at the rest in the following years.

     Arnd

Re: mach-crag6410.c staying or going?

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

On Wed, Jul 31, 2024 at 02:06:00PM +0200, Arnd Bergmann wrote:
> On Wed, Jul 31, 2024, at 04:42, Dmitry Torokhov wrote:

> > I would like to remove platform data suppirt from samsung-keypad driver;
> > mach-crag6410.c is the only user of samsung_keypad_platdata structure.

> Unfortunately we are a bit stuck here and there is no good answer
> for it. I think this board file is holding up more cleanups than
> any other and I'd love to get rid of it, but Mark is still using
> the machine, and probably relies on it more than anyone else
> needs the other board files.

While I am using the device I don't care at all about the keypad driver,
I don't use the keypad at all so that could just be removed as far as
I'm concerned.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: mach-crag6410.c staying or going?

[Dmitry Torokhov]

On Wed, Jul 31, 2024 at 01:10:25PM +0100, Mark Brown wrote:
> On Wed, Jul 31, 2024 at 02:06:00PM +0200, Arnd Bergmann wrote:
> > On Wed, Jul 31, 2024, at 04:42, Dmitry Torokhov wrote:
> 
> > > I would like to remove platform data suppirt from samsung-keypad driver;
> > > mach-crag6410.c is the only user of samsung_keypad_platdata structure.
> 
> > Unfortunately we are a bit stuck here and there is no good answer
> > for it. I think this board file is holding up more cleanups than
> > any other and I'd love to get rid of it, but Mark is still using
> > the machine, and probably relies on it more than anyone else
> > needs the other board files.
> 
> While I am using the device I don't care at all about the keypad driver,
> I don't use the keypad at all so that could just be removed as far as
> I'm concerned.

Nah, if it is still used I can convert properly, especially if you can
try my patches.

Should the warning about removal after '24 be removed then?

Thanks.

-- 
Dmitry

Re: mach-crag6410.c staying or going?

[Arnd Bergmann]

On Wed, Jul 31, 2024, at 19:23, Dmitry Torokhov wrote:
> On Wed, Jul 31, 2024 at 01:10:25PM +0100, Mark Brown wrote:
>> On Wed, Jul 31, 2024 at 02:06:00PM +0200, Arnd Bergmann wrote:
>> > On Wed, Jul 31, 2024, at 04:42, Dmitry Torokhov wrote:
>> 
>> > > I would like to remove platform data suppirt from samsung-keypad driver;
>> > > mach-crag6410.c is the only user of samsung_keypad_platdata structure.
>> 
>> > Unfortunately we are a bit stuck here and there is no good answer
>> > for it. I think this board file is holding up more cleanups than
>> > any other and I'd love to get rid of it, but Mark is still using
>> > the machine, and probably relies on it more than anyone else
>> > needs the other board files.
>> 
>> While I am using the device I don't care at all about the keypad driver,
>> I don't use the keypad at all so that could just be removed as far as
>> I'm concerned.
>
> Nah, if it is still used I can convert properly, especially if you can
> try my patches.
>
> Should the warning about removal after '24 be removed then?

As promised, I have now sent my email about the wider board
deprecation timeline, see

https://lore.kernel.org/linux-arm-kernel/2831c5a6-cfbf-4fe0-b51c-0396e5b0aeb7@app.fastmail.com/T/#u

Let's see if we can agree on a plan for removing more of the
other boards first, and then add consistent warnings to the
ones that are on the way out.

     arnd