From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Diogo Jahchan Koike <djahchankoike@gmail.com>
Cc: syzbot+733300ca0a9baca7e245@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix unreleased reader lock on return
Date: Thu, 15 Aug 2024 15:29:47 +0000 [thread overview]
Message-ID: <Zr4e6zsKOotTLVTp@google.com> (raw)
In-Reply-To: <CAJwTMzrXOBrZ2XSG4GykDhjeTAztO8j1h8zoAFGZeZBqZF5brQ@mail.gmail.com>
On 08/15, Diogo Jahchan Koike wrote:
> No problem whatsoever.
Thanks. I removed the original patch from -next. Chao, please post a fixed
version.
>
> Thanks,
>
> Em qua., 14 de ago. de 2024, 21:51, Chao Yu <chao@kernel.org> escreveu:
>
> > On 2024/8/15 5:16, Diogo Jahchan Koike wrote:
> > > fix reader lock unreleased in error path.
> >
> > Thank you for catching this, if you don't mind, I'd like to merge it to
> > original patch, since it is still in dev-test branch.
> >
> > Thanks,
> >
> > >
> > > Fixes: 374a8881ce4c ("f2fs: atomic: fix to forbid dio in atomic_file")
> > > Reported-by: syzbot+733300ca0a9baca7e245@syzkaller.appspotmail.com
> > > Closes: https://syzkaller.appspot.com/bug?extid=733300ca0a9baca7e245
> > > Signed-off-by: Diogo Jahchan Koike <djahchankoike@gmail.com>
> > > ---
> > > fs/f2fs/file.c | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > > index 51f6ffd5f4e2..c9eda5dbd11f 100644
> > > --- a/fs/f2fs/file.c
> > > +++ b/fs/f2fs/file.c
> > > @@ -2172,6 +2172,7 @@ static int f2fs_ioc_start_atomic_write(struct file
> > *filp, bool truncate)
> > > ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX);
> > > if (ret) {
> > > f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
> > > + f2fs_up_write(&fi->i_gc_rwsem[READ]);
> > > goto out;
> > > }
> > >
> > > @@ -2181,6 +2182,7 @@ static int f2fs_ioc_start_atomic_write(struct file
> > *filp, bool truncate)
> > > pinode = f2fs_iget(inode->i_sb, fi->i_pino);
> > > if (IS_ERR(pinode)) {
> > > f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
> > > + f2fs_up_write(&fi->i_gc_rwsem[READ]);
> > > ret = PTR_ERR(pinode);
> > > goto out;
> > > }
> > > @@ -2189,6 +2191,7 @@ static int f2fs_ioc_start_atomic_write(struct file
> > *filp, bool truncate)
> > > iput(pinode);
> > > if (ret) {
> > > f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
> > > + f2fs_up_write(&fi->i_gc_rwsem[READ]);
> > > goto out;
> > > }
> > >
> > > @@ -2202,6 +2205,7 @@ static int f2fs_ioc_start_atomic_write(struct file
> > *filp, bool truncate)
> > > ret = f2fs_do_truncate_blocks(fi->cow_inode, 0, true);
> > > if (ret) {
> > > f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
> > > + f2fs_up_write(&fi->i_gc_rwsem[READ]);
> > > goto out;
> > > }
> > > }
> >
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Diogo Jahchan Koike <djahchankoike@gmail.com>
Cc: Chao Yu <chao@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
syzbot+733300ca0a9baca7e245@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] f2fs: fix unreleased reader lock on return
Date: Thu, 15 Aug 2024 15:29:47 +0000 [thread overview]
Message-ID: <Zr4e6zsKOotTLVTp@google.com> (raw)
In-Reply-To: <CAJwTMzrXOBrZ2XSG4GykDhjeTAztO8j1h8zoAFGZeZBqZF5brQ@mail.gmail.com>
On 08/15, Diogo Jahchan Koike wrote:
> No problem whatsoever.
Thanks. I removed the original patch from -next. Chao, please post a fixed
version.
>
> Thanks,
>
> Em qua., 14 de ago. de 2024, 21:51, Chao Yu <chao@kernel.org> escreveu:
>
> > On 2024/8/15 5:16, Diogo Jahchan Koike wrote:
> > > fix reader lock unreleased in error path.
> >
> > Thank you for catching this, if you don't mind, I'd like to merge it to
> > original patch, since it is still in dev-test branch.
> >
> > Thanks,
> >
> > >
> > > Fixes: 374a8881ce4c ("f2fs: atomic: fix to forbid dio in atomic_file")
> > > Reported-by: syzbot+733300ca0a9baca7e245@syzkaller.appspotmail.com
> > > Closes: https://syzkaller.appspot.com/bug?extid=733300ca0a9baca7e245
> > > Signed-off-by: Diogo Jahchan Koike <djahchankoike@gmail.com>
> > > ---
> > > fs/f2fs/file.c | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > > index 51f6ffd5f4e2..c9eda5dbd11f 100644
> > > --- a/fs/f2fs/file.c
> > > +++ b/fs/f2fs/file.c
> > > @@ -2172,6 +2172,7 @@ static int f2fs_ioc_start_atomic_write(struct file
> > *filp, bool truncate)
> > > ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX);
> > > if (ret) {
> > > f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
> > > + f2fs_up_write(&fi->i_gc_rwsem[READ]);
> > > goto out;
> > > }
> > >
> > > @@ -2181,6 +2182,7 @@ static int f2fs_ioc_start_atomic_write(struct file
> > *filp, bool truncate)
> > > pinode = f2fs_iget(inode->i_sb, fi->i_pino);
> > > if (IS_ERR(pinode)) {
> > > f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
> > > + f2fs_up_write(&fi->i_gc_rwsem[READ]);
> > > ret = PTR_ERR(pinode);
> > > goto out;
> > > }
> > > @@ -2189,6 +2191,7 @@ static int f2fs_ioc_start_atomic_write(struct file
> > *filp, bool truncate)
> > > iput(pinode);
> > > if (ret) {
> > > f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
> > > + f2fs_up_write(&fi->i_gc_rwsem[READ]);
> > > goto out;
> > > }
> > >
> > > @@ -2202,6 +2205,7 @@ static int f2fs_ioc_start_atomic_write(struct file
> > *filp, bool truncate)
> > > ret = f2fs_do_truncate_blocks(fi->cow_inode, 0, true);
> > > if (ret) {
> > > f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
> > > + f2fs_up_write(&fi->i_gc_rwsem[READ]);
> > > goto out;
> > > }
> > > }
> >
> >
next prev parent reply other threads:[~2024-08-15 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 21:16 [f2fs-dev] [PATCH] f2fs: fix unreleased reader lock on return Diogo Jahchan Koike
2024-08-14 21:16 ` Diogo Jahchan Koike
2024-08-15 0:51 ` [f2fs-dev] " Chao Yu
2024-08-15 0:51 ` Chao Yu
[not found] ` <CAJwTMzrXOBrZ2XSG4GykDhjeTAztO8j1h8zoAFGZeZBqZF5brQ@mail.gmail.com>
2024-08-15 15:29 ` Jaegeuk Kim [this message]
2024-08-15 15:29 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zr4e6zsKOotTLVTp@google.com \
--to=jaegeuk@kernel.org \
--cc=djahchankoike@gmail.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+733300ca0a9baca7e245@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.