* [PATCH v5] drm/i915/hwmon: expose fan speed
@ 2024-08-12 8:15 Raag Jadav
2024-08-12 10:14 ` ✓ Fi.CI.BAT: success for drm/i915/hwmon: expose fan speed (rev5) Patchwork
` (5 more replies)
0 siblings, 6 replies; 12+ messages in thread
From: Raag Jadav @ 2024-08-12 8:15 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, tursulin, airlied,
daniel, linux, andi.shyti, andriy.shevchenko
Cc: intel-gfx, dri-devel, linux-hwmon, linux-kernel, anshuman.gupta,
badal.nilawar, riana.tauro, ashutosh.dixit, karthik.poosa,
Raag Jadav
Add hwmon support for fan1_input attribute, which will expose fan speed
in RPM. With this in place we can monitor fan speed using lm-sensors tool.
$ sensors
i915-pci-0300
Adapter: PCI adapter
in0: 653.00 mV
fan1: 3833 RPM
power1: N/A (max = 43.00 W)
energy1: 32.02 kJ
v2: Handle overflow, add mutex protection and ABI documentation
Aesthetic adjustments (Riana)
v3: Declare rotations as "long", change ABI date and version
Add commenter name in changelog (Riana)
v4: Fix wakeref leak
Drop switch case and simplify hwm_fan_xx() (Andi)
v5: Rework time calculation, aesthetic adjustments (Andy)
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Reviewed-by: Riana Tauro <riana.tauro@intel.com>
---
.../ABI/testing/sysfs-driver-intel-i915-hwmon | 8 ++
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2 +
drivers/gpu/drm/i915/i915_hwmon.c | 85 +++++++++++++++++++
3 files changed, 95 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
index 92fe7c5c5ac1..be4141a7522f 100644
--- a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
+++ b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
@@ -75,3 +75,11 @@ Description: RO. Energy input of device or gt in microjoules.
for the gt.
Only supported for particular Intel i915 graphics platforms.
+
+What: /sys/bus/pci/drivers/i915/.../hwmon/hwmon<i>/fan1_input
+Date: November 2024
+KernelVersion: 6.12
+Contact: intel-gfx@lists.freedesktop.org
+Description: RO. Fan speed of device in RPM.
+
+ Only supported for particular Intel i915 graphics platforms.
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
index e42b3a5d4e63..57a3c83d3655 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
+++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
@@ -1553,6 +1553,8 @@
#define VLV_RENDER_C0_COUNT _MMIO(0x138118)
#define VLV_MEDIA_C0_COUNT _MMIO(0x13811c)
+#define PCU_PWM_FAN_SPEED _MMIO(0x138140)
+
#define GEN12_RPSTAT1 _MMIO(0x1381b4)
#define GEN12_VOLTAGE_MASK REG_GENMASK(10, 0)
#define GEN12_CAGF_MASK REG_GENMASK(19, 11)
diff --git a/drivers/gpu/drm/i915/i915_hwmon.c b/drivers/gpu/drm/i915/i915_hwmon.c
index 49db3e09826c..a867b81a0900 100644
--- a/drivers/gpu/drm/i915/i915_hwmon.c
+++ b/drivers/gpu/drm/i915/i915_hwmon.c
@@ -5,6 +5,7 @@
#include <linux/hwmon.h>
#include <linux/hwmon-sysfs.h>
+#include <linux/jiffies.h>
#include <linux/types.h>
#include "i915_drv.h"
@@ -36,6 +37,7 @@ struct hwm_reg {
i915_reg_t pkg_rapl_limit;
i915_reg_t energy_status_all;
i915_reg_t energy_status_tile;
+ i915_reg_t fan_speed;
};
struct hwm_energy_info {
@@ -43,11 +45,17 @@ struct hwm_energy_info {
long accum_energy; /* Accumulated energy for energy1_input */
};
+struct hwm_fan_info {
+ u32 reg_val_prev;
+ u64 time_prev;
+};
+
struct hwm_drvdata {
struct i915_hwmon *hwmon;
struct intel_uncore *uncore;
struct device *hwmon_dev;
struct hwm_energy_info ei; /* Energy info for energy1_input */
+ struct hwm_fan_info fi; /* Fan info for fan1_input */
char name[12];
int gt_n;
bool reset_in_progress;
@@ -276,6 +284,7 @@ static const struct hwmon_channel_info * const hwm_info[] = {
HWMON_CHANNEL_INFO(power, HWMON_P_MAX | HWMON_P_RATED_MAX | HWMON_P_CRIT),
HWMON_CHANNEL_INFO(energy, HWMON_E_INPUT),
HWMON_CHANNEL_INFO(curr, HWMON_C_CRIT),
+ HWMON_CHANNEL_INFO(fan, HWMON_F_INPUT),
NULL
};
@@ -613,6 +622,66 @@ hwm_curr_write(struct hwm_drvdata *ddat, u32 attr, long val)
}
}
+static umode_t
+hwm_fan_is_visible(const struct hwm_drvdata *ddat, u32 attr)
+{
+ struct i915_hwmon *hwmon = ddat->hwmon;
+
+ return attr == hwmon_fan_input &&
+ i915_mmio_reg_valid(hwmon->rg.fan_speed) ? 0444 : 0;
+}
+
+static int
+hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val)
+{
+ struct i915_hwmon *hwmon = ddat->hwmon;
+ struct hwm_fan_info *fi = &ddat->fi;
+ u64 rotations, time_now, time;
+ intel_wakeref_t wakeref;
+ u32 reg_val, pulses;
+ int ret = 0;
+
+ if (attr != hwmon_fan_input)
+ return -EOPNOTSUPP;
+
+ wakeref = intel_runtime_pm_get(ddat->uncore->rpm);
+ mutex_lock(&hwmon->hwmon_lock);
+
+ reg_val = intel_uncore_read(ddat->uncore, hwmon->rg.fan_speed);
+ time_now = get_jiffies_64();
+
+ /* Handle HW register overflow */
+ if (reg_val >= fi->reg_val_prev)
+ pulses = reg_val - fi->reg_val_prev;
+ else
+ pulses = UINT_MAX - fi->reg_val_prev + reg_val;
+
+ /*
+ * HW register value is accumulated count of pulses from
+ * PWM fan with the scale of 2 pulses per rotation.
+ */
+ rotations = pulses / 2;
+
+ time = jiffies_delta_to_msecs(time_now - fi->time_prev);
+ if (unlikely(!time)) {
+ ret = -EAGAIN;
+ goto exit;
+ }
+
+ /*
+ * Convert to minutes for calculating RPM.
+ * RPM = number of rotations * msecs per minute / time in msecs
+ */
+ *val = DIV_ROUND_UP(rotations * (MSEC_PER_SEC * 60), time);
+
+ fi->reg_val_prev = reg_val;
+ fi->time_prev = time_now;
+exit:
+ mutex_unlock(&hwmon->hwmon_lock);
+ intel_runtime_pm_put(ddat->uncore->rpm, wakeref);
+ return ret;
+}
+
static umode_t
hwm_is_visible(const void *drvdata, enum hwmon_sensor_types type,
u32 attr, int channel)
@@ -628,6 +697,8 @@ hwm_is_visible(const void *drvdata, enum hwmon_sensor_types type,
return hwm_energy_is_visible(ddat, attr);
case hwmon_curr:
return hwm_curr_is_visible(ddat, attr);
+ case hwmon_fan:
+ return hwm_fan_is_visible(ddat, attr);
default:
return 0;
}
@@ -648,6 +719,8 @@ hwm_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
return hwm_energy_read(ddat, attr, val);
case hwmon_curr:
return hwm_curr_read(ddat, attr, val);
+ case hwmon_fan:
+ return hwm_fan_read(ddat, attr, val);
default:
return -EOPNOTSUPP;
}
@@ -739,12 +812,14 @@ hwm_get_preregistration_info(struct drm_i915_private *i915)
hwmon->rg.pkg_rapl_limit = PCU_PACKAGE_RAPL_LIMIT;
hwmon->rg.energy_status_all = PCU_PACKAGE_ENERGY_STATUS;
hwmon->rg.energy_status_tile = INVALID_MMIO_REG;
+ hwmon->rg.fan_speed = PCU_PWM_FAN_SPEED;
} else {
hwmon->rg.pkg_power_sku_unit = INVALID_MMIO_REG;
hwmon->rg.pkg_power_sku = INVALID_MMIO_REG;
hwmon->rg.pkg_rapl_limit = INVALID_MMIO_REG;
hwmon->rg.energy_status_all = INVALID_MMIO_REG;
hwmon->rg.energy_status_tile = INVALID_MMIO_REG;
+ hwmon->rg.fan_speed = INVALID_MMIO_REG;
}
with_intel_runtime_pm(uncore->rpm, wakeref) {
@@ -755,6 +830,16 @@ hwm_get_preregistration_info(struct drm_i915_private *i915)
if (i915_mmio_reg_valid(hwmon->rg.pkg_power_sku_unit))
val_sku_unit = intel_uncore_read(uncore,
hwmon->rg.pkg_power_sku_unit);
+
+ /*
+ * Store the initial fan register value, so that we can use it for
+ * initial fan speed calculation.
+ */
+ if (i915_mmio_reg_valid(hwmon->rg.fan_speed)) {
+ ddat->fi.reg_val_prev = intel_uncore_read(uncore,
+ hwmon->rg.fan_speed);
+ ddat->fi.time_prev = get_jiffies_64();
+ }
}
hwmon->scl_shift_power = REG_FIELD_GET(PKG_PWR_UNIT, val_sku_unit);
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/hwmon: expose fan speed (rev5)
2024-08-12 8:15 [PATCH v5] drm/i915/hwmon: expose fan speed Raag Jadav
@ 2024-08-12 10:14 ` Patchwork
2024-08-12 13:15 ` [PATCH v5] drm/i915/hwmon: expose fan speed Andy Shevchenko
` (4 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2024-08-12 10:14 UTC (permalink / raw)
To: Raag Jadav; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10592 bytes --]
== Series Details ==
Series: drm/i915/hwmon: expose fan speed (rev5)
URL : https://patchwork.freedesktop.org/series/136036/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15215 -> Patchwork_136036v5
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/index.html
Participating hosts (38 -> 40)
------------------------------
Additional (5): fi-kbl-7567u bat-arls-2 fi-elk-e7500 fi-kbl-8809g bat-jsl-1
Missing (3): bat-dg2-11 bat-arlh-3 fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_136036v5 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-jsl-1: NOTRUN -> [SKIP][1] ([i915#9318])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-jsl-1/igt@debugfs_test@basic-hwmon.html
- bat-arls-2: NOTRUN -> [SKIP][2] ([i915#9318])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@debugfs_test@basic-hwmon.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-7567u: NOTRUN -> [SKIP][3] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/fi-kbl-7567u/igt@gem_huc_copy@huc-copy.html
- fi-kbl-8809g: NOTRUN -> [SKIP][4] ([i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/fi-kbl-8809g/igt@gem_huc_copy@huc-copy.html
- bat-jsl-1: NOTRUN -> [SKIP][5] ([i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-jsl-1/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-7567u: NOTRUN -> [SKIP][6] ([i915#4613]) +3 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/fi-kbl-7567u/igt@gem_lmem_swapping@basic.html
- fi-kbl-8809g: NOTRUN -> [SKIP][7] ([i915#4613]) +3 other tests skip
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/fi-kbl-8809g/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@verify-random:
- bat-arls-2: NOTRUN -> [SKIP][8] ([i915#10213]) +3 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@gem_lmem_swapping@verify-random.html
- bat-jsl-1: NOTRUN -> [SKIP][9] ([i915#4613]) +3 other tests skip
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-jsl-1/igt@gem_lmem_swapping@verify-random.html
* igt@gem_mmap@basic:
- bat-arls-2: NOTRUN -> [SKIP][10] ([i915#11343] / [i915#4083])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@gem_mmap@basic.html
* igt@gem_mmap_gtt@basic:
- bat-arls-2: NOTRUN -> [SKIP][11] ([i915#10196] / [i915#4077]) +2 other tests skip
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@gem_mmap_gtt@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-arls-2: NOTRUN -> [SKIP][12] ([i915#10197] / [i915#10211] / [i915#4079])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-arls-2: NOTRUN -> [SKIP][13] ([i915#10206] / [i915#4079])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@gem_tiled_pread_basic.html
* igt@i915_pm_rps@basic-api:
- bat-arls-2: NOTRUN -> [SKIP][14] ([i915#10209])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@workarounds:
- bat-dg2-9: [PASS][15] -> [DMESG-FAIL][16] ([i915#9500])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/bat-dg2-9/igt@i915_selftest@live@workarounds.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-dg2-9/igt@i915_selftest@live@workarounds.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-arls-2: NOTRUN -> [SKIP][17] ([i915#10200]) +9 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-arls-2: NOTRUN -> [SKIP][18] ([i915#10202] / [i915#11346]) +1 other test skip
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
- bat-jsl-1: NOTRUN -> [SKIP][19] ([i915#4103]) +1 other test skip
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-jsl-1/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_dsc@dsc-basic:
- bat-arls-2: NOTRUN -> [SKIP][20] ([i915#11346] / [i915#9886])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@kms_dsc@dsc-basic.html
- bat-jsl-1: NOTRUN -> [SKIP][21] ([i915#3555] / [i915#9886])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-jsl-1/igt@kms_dsc@dsc-basic.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-kbl-7567u: NOTRUN -> [SKIP][22] +11 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/fi-kbl-7567u/igt@kms_force_connector_basic@force-load-detect.html
- fi-kbl-8809g: NOTRUN -> [SKIP][23] +30 other tests skip
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/fi-kbl-8809g/igt@kms_force_connector_basic@force-load-detect.html
- bat-arls-2: NOTRUN -> [SKIP][24] ([i915#10207] / [i915#11346])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@kms_force_connector_basic@force-load-detect.html
- bat-jsl-1: NOTRUN -> [SKIP][25]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-jsl-1/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pm_rpm@basic-pci-d3-state:
- fi-elk-e7500: NOTRUN -> [SKIP][26] +24 other tests skip
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/fi-elk-e7500/igt@kms_pm_rpm@basic-pci-d3-state.html
* igt@kms_psr@psr-primary-mmap-gtt@edp-1:
- bat-arls-2: NOTRUN -> [SKIP][27] ([i915#10196] / [i915#4077] / [i915#9688])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@kms_psr@psr-primary-mmap-gtt@edp-1.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-arls-2: NOTRUN -> [SKIP][28] ([i915#10208] / [i915#8809])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@kms_setmode@basic-clone-single-crtc.html
- bat-jsl-1: NOTRUN -> [SKIP][29] ([i915#3555])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-jsl-1/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-mmap:
- bat-arls-2: NOTRUN -> [SKIP][30] ([i915#10196] / [i915#3708] / [i915#4077]) +1 other test skip
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-fence-read:
- bat-arls-2: NOTRUN -> [SKIP][31] ([i915#10212] / [i915#3708])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-read:
- bat-arls-2: NOTRUN -> [SKIP][32] ([i915#10214] / [i915#3708])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-write:
- bat-arls-2: NOTRUN -> [SKIP][33] ([i915#10216] / [i915#3708])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/bat-arls-2/igt@prime_vgem@basic-write.html
[i915#10196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10196
[i915#10197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10197
[i915#10200]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10200
[i915#10202]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10202
[i915#10206]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10206
[i915#10207]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10207
[i915#10208]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10208
[i915#10209]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10209
[i915#10211]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10211
[i915#10212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10212
[i915#10213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10213
[i915#10214]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10214
[i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
[i915#11343]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11343
[i915#11346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11346
[i915#2190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2190
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
[i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318
[i915#9500]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9500
[i915#9688]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9688
[i915#9886]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9886
Build changes
-------------
* Linux: CI_DRM_15215 -> Patchwork_136036v5
CI-20190529: 20190529
CI_DRM_15215: fbd5dee4a651d4c70b3d2ee5052fb20eab02a317 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7966: f16c5f500adc5fa41bd52a3ef2a84165da4fb596 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_136036v5: fbd5dee4a651d4c70b3d2ee5052fb20eab02a317 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/index.html
[-- Attachment #2: Type: text/html, Size: 12991 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v5] drm/i915/hwmon: expose fan speed
2024-08-12 8:15 [PATCH v5] drm/i915/hwmon: expose fan speed Raag Jadav
2024-08-12 10:14 ` ✓ Fi.CI.BAT: success for drm/i915/hwmon: expose fan speed (rev5) Patchwork
@ 2024-08-12 13:15 ` Andy Shevchenko
2024-08-13 5:45 ` Raag Jadav
2024-08-12 13:50 ` Andi Shyti
` (3 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Andy Shevchenko @ 2024-08-12 13:15 UTC (permalink / raw)
To: Raag Jadav
Cc: jani.nikula, joonas.lahtinen, rodrigo.vivi, tursulin, airlied,
daniel, linux, andi.shyti, intel-gfx, dri-devel, linux-hwmon,
linux-kernel, anshuman.gupta, badal.nilawar, riana.tauro,
ashutosh.dixit, karthik.poosa
On Mon, Aug 12, 2024 at 01:45:38PM +0530, Raag Jadav wrote:
> Add hwmon support for fan1_input attribute, which will expose fan speed
> in RPM. With this in place we can monitor fan speed using lm-sensors tool.
>
> $ sensors
> i915-pci-0300
> Adapter: PCI adapter
> in0: 653.00 mV
> fan1: 3833 RPM
> power1: N/A (max = 43.00 W)
> energy1: 32.02 kJ
...
> +static int
> +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val)
> +{
> + struct i915_hwmon *hwmon = ddat->hwmon;
> + struct hwm_fan_info *fi = &ddat->fi;
> + u64 rotations, time_now, time;
> + intel_wakeref_t wakeref;
> + u32 reg_val, pulses;
> + int ret = 0;
> +
> + if (attr != hwmon_fan_input)
> + return -EOPNOTSUPP;
> +
> + wakeref = intel_runtime_pm_get(ddat->uncore->rpm);
> + mutex_lock(&hwmon->hwmon_lock);
> +
> + reg_val = intel_uncore_read(ddat->uncore, hwmon->rg.fan_speed);
> + time_now = get_jiffies_64();
> + /* Handle HW register overflow */
> + if (reg_val >= fi->reg_val_prev)
> + pulses = reg_val - fi->reg_val_prev;
> + else
> + pulses = UINT_MAX - fi->reg_val_prev + reg_val;
Isn't it the abs_diff() reimplementation?
> + /*
> + * HW register value is accumulated count of pulses from
> + * PWM fan with the scale of 2 pulses per rotation.
> + */
> + rotations = pulses / 2;
> +
> + time = jiffies_delta_to_msecs(time_now - fi->time_prev);
> + if (unlikely(!time)) {
> + ret = -EAGAIN;
> + goto exit;
> + }
> +
> + /*
> + * Convert to minutes for calculating RPM.
> + * RPM = number of rotations * msecs per minute / time in msecs
> + */
> + *val = DIV_ROUND_UP(rotations * (MSEC_PER_SEC * 60), time);
> +
> + fi->reg_val_prev = reg_val;
> + fi->time_prev = time_now;
> +exit:
> + mutex_unlock(&hwmon->hwmon_lock);
> + intel_runtime_pm_put(ddat->uncore->rpm, wakeref);
> + return ret;
> +}
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v5] drm/i915/hwmon: expose fan speed
2024-08-12 8:15 [PATCH v5] drm/i915/hwmon: expose fan speed Raag Jadav
2024-08-12 10:14 ` ✓ Fi.CI.BAT: success for drm/i915/hwmon: expose fan speed (rev5) Patchwork
2024-08-12 13:15 ` [PATCH v5] drm/i915/hwmon: expose fan speed Andy Shevchenko
@ 2024-08-12 13:50 ` Andi Shyti
2024-08-13 6:30 ` Raag Jadav
2024-08-12 21:36 ` kernel test robot
` (2 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Andi Shyti @ 2024-08-12 13:50 UTC (permalink / raw)
To: Raag Jadav
Cc: jani.nikula, joonas.lahtinen, rodrigo.vivi, tursulin, airlied,
daniel, linux, andi.shyti, andriy.shevchenko, intel-gfx,
dri-devel, linux-hwmon, linux-kernel, anshuman.gupta,
badal.nilawar, riana.tauro, ashutosh.dixit, karthik.poosa
Hi Raag,
> +static int
> +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val)
> +{
> + struct i915_hwmon *hwmon = ddat->hwmon;
> + struct hwm_fan_info *fi = &ddat->fi;
> + u64 rotations, time_now, time;
> + intel_wakeref_t wakeref;
> + u32 reg_val, pulses;
> + int ret = 0;
> +
> + if (attr != hwmon_fan_input)
> + return -EOPNOTSUPP;
> +
> + wakeref = intel_runtime_pm_get(ddat->uncore->rpm);
> + mutex_lock(&hwmon->hwmon_lock);
> +
> + reg_val = intel_uncore_read(ddat->uncore, hwmon->rg.fan_speed);
> + time_now = get_jiffies_64();
> +
> + /* Handle HW register overflow */
> + if (reg_val >= fi->reg_val_prev)
> + pulses = reg_val - fi->reg_val_prev;
> + else
> + pulses = UINT_MAX - fi->reg_val_prev + reg_val;
> +
> + /*
> + * HW register value is accumulated count of pulses from
> + * PWM fan with the scale of 2 pulses per rotation.
> + */
> + rotations = pulses / 2;
> +
> + time = jiffies_delta_to_msecs(time_now - fi->time_prev);
> + if (unlikely(!time)) {
> + ret = -EAGAIN;
> + goto exit;
> + }
Can you please add a comment describing how you obtain the speed
calculation?
Basically at every read you store the values. Is it possible that
we don't have reads for a long time and the register resets more
than once?
Thanks,
Andi
> + /*
> + * Convert to minutes for calculating RPM.
> + * RPM = number of rotations * msecs per minute / time in msecs
> + */
> + *val = DIV_ROUND_UP(rotations * (MSEC_PER_SEC * 60), time);
> +
> + fi->reg_val_prev = reg_val;
> + fi->time_prev = time_now;
> +exit:
> + mutex_unlock(&hwmon->hwmon_lock);
> + intel_runtime_pm_put(ddat->uncore->rpm, wakeref);
> + return ret;
> +}
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v5] drm/i915/hwmon: expose fan speed
2024-08-12 8:15 [PATCH v5] drm/i915/hwmon: expose fan speed Raag Jadav
` (2 preceding siblings ...)
2024-08-12 13:50 ` Andi Shyti
@ 2024-08-12 21:36 ` kernel test robot
2024-08-12 22:43 ` ✓ Fi.CI.IGT: success for drm/i915/hwmon: expose fan speed (rev5) Patchwork
2024-08-13 0:38 ` [PATCH v5] drm/i915/hwmon: expose fan speed kernel test robot
5 siblings, 0 replies; 12+ messages in thread
From: kernel test robot @ 2024-08-12 21:36 UTC (permalink / raw)
To: Raag Jadav, jani.nikula, joonas.lahtinen, rodrigo.vivi, tursulin,
airlied, daniel, linux, andi.shyti, andriy.shevchenko
Cc: oe-kbuild-all, intel-gfx, dri-devel, linux-hwmon, linux-kernel,
anshuman.gupta, badal.nilawar, riana.tauro, ashutosh.dixit,
karthik.poosa, Raag Jadav
Hi Raag,
kernel test robot noticed the following build errors:
[auto build test ERROR on groeck-staging/hwmon-next]
[also build test ERROR on linus/master v6.11-rc3 next-20240812]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Raag-Jadav/drm-i915-hwmon-expose-fan-speed/20240812-161645
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
patch link: https://lore.kernel.org/r/20240812081538.1457396-1-raag.jadav%40intel.com
patch subject: [PATCH v5] drm/i915/hwmon: expose fan speed
config: i386-randconfig-012-20240813 (https://download.01.org/0day-ci/archive/20240813/202408130500.SgCVoR2D-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240813/202408130500.SgCVoR2D-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408130500.SgCVoR2D-lkp@intel.com/
All errors (new ones prefixed by >>):
ld: drivers/gpu/drm/i915/i915_hwmon.o: in function `hwm_fan_read':
>> drivers/gpu/drm/i915/i915_hwmon.c:675: undefined reference to `__udivdi3'
vim +675 drivers/gpu/drm/i915/i915_hwmon.c
633
634 static int
635 hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val)
636 {
637 struct i915_hwmon *hwmon = ddat->hwmon;
638 struct hwm_fan_info *fi = &ddat->fi;
639 u64 rotations, time_now, time;
640 intel_wakeref_t wakeref;
641 u32 reg_val, pulses;
642 int ret = 0;
643
644 if (attr != hwmon_fan_input)
645 return -EOPNOTSUPP;
646
647 wakeref = intel_runtime_pm_get(ddat->uncore->rpm);
648 mutex_lock(&hwmon->hwmon_lock);
649
650 reg_val = intel_uncore_read(ddat->uncore, hwmon->rg.fan_speed);
651 time_now = get_jiffies_64();
652
653 /* Handle HW register overflow */
654 if (reg_val >= fi->reg_val_prev)
655 pulses = reg_val - fi->reg_val_prev;
656 else
657 pulses = UINT_MAX - fi->reg_val_prev + reg_val;
658
659 /*
660 * HW register value is accumulated count of pulses from
661 * PWM fan with the scale of 2 pulses per rotation.
662 */
663 rotations = pulses / 2;
664
665 time = jiffies_delta_to_msecs(time_now - fi->time_prev);
666 if (unlikely(!time)) {
667 ret = -EAGAIN;
668 goto exit;
669 }
670
671 /*
672 * Convert to minutes for calculating RPM.
673 * RPM = number of rotations * msecs per minute / time in msecs
674 */
> 675 *val = DIV_ROUND_UP(rotations * (MSEC_PER_SEC * 60), time);
676
677 fi->reg_val_prev = reg_val;
678 fi->time_prev = time_now;
679 exit:
680 mutex_unlock(&hwmon->hwmon_lock);
681 intel_runtime_pm_put(ddat->uncore->rpm, wakeref);
682 return ret;
683 }
684
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 12+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/hwmon: expose fan speed (rev5)
2024-08-12 8:15 [PATCH v5] drm/i915/hwmon: expose fan speed Raag Jadav
` (3 preceding siblings ...)
2024-08-12 21:36 ` kernel test robot
@ 2024-08-12 22:43 ` Patchwork
2024-08-13 0:38 ` [PATCH v5] drm/i915/hwmon: expose fan speed kernel test robot
5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2024-08-12 22:43 UTC (permalink / raw)
To: Raag Jadav; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 51832 bytes --]
== Series Details ==
Series: drm/i915/hwmon: expose fan speed (rev5)
URL : https://patchwork.freedesktop.org/series/136036/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15215_full -> Patchwork_136036v5_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_136036v5_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_136036v5_full, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_136036v5_full:
### IGT changes ###
#### Warnings ####
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-pwrite:
- shard-snb: [SKIP][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-snb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-pwrite.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-snb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-pwrite.html
Known issues
------------
Here are the changes found in Patchwork_136036v5_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_fdinfo@idle@rcs0:
- shard-rkl: NOTRUN -> [FAIL][3] ([i915#7742])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-3/igt@drm_fdinfo@idle@rcs0.html
* igt@gem_bad_reloc@negative-reloc-bltcopy:
- shard-dg1: NOTRUN -> [SKIP][4] ([i915#3281])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@gem_bad_reloc@negative-reloc-bltcopy.html
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-rkl: NOTRUN -> [SKIP][5] ([i915#4525])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@gem_exec_balancer@parallel-keep-submit-fence.html
* igt@gem_exec_balancer@sliced:
- shard-dg1: NOTRUN -> [SKIP][6] ([i915#4812])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@gem_exec_balancer@sliced.html
* igt@gem_exec_capture@capture-invisible@smem0:
- shard-rkl: NOTRUN -> [SKIP][7] ([i915#6334])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-3/igt@gem_exec_capture@capture-invisible@smem0.html
* igt@gem_exec_endless@dispatch@vcs1:
- shard-tglu: [PASS][8] -> [TIMEOUT][9] ([i915#3778])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-tglu-8/igt@gem_exec_endless@dispatch@vcs1.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-tglu-5/igt@gem_exec_endless@dispatch@vcs1.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-rkl: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-rkl-4/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
- shard-glk: NOTRUN -> [FAIL][14] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-glk8/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_flush@basic-wb-set-default:
- shard-dg2: NOTRUN -> [SKIP][15] ([i915#3539] / [i915#4852])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-8/igt@gem_exec_flush@basic-wb-set-default.html
* igt@gem_exec_reloc@basic-gtt-cpu-active:
- shard-rkl: NOTRUN -> [SKIP][16] ([i915#3281]) +7 other tests skip
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-cpu-active.html
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-rkl: NOTRUN -> [SKIP][17] ([i915#4613]) +2 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@gem_lmem_swapping@heavy-verify-random.html
* igt@gem_lmem_swapping@verify-random-ccs:
- shard-glk: NOTRUN -> [SKIP][18] ([i915#4613]) +2 other tests skip
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-glk1/igt@gem_lmem_swapping@verify-random-ccs.html
- shard-mtlp: NOTRUN -> [SKIP][19] ([i915#4613])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-mtlp-5/igt@gem_lmem_swapping@verify-random-ccs.html
* igt@gem_madvise@dontneed-before-exec:
- shard-dg1: NOTRUN -> [SKIP][20] ([i915#3282])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@gem_madvise@dontneed-before-exec.html
* igt@gem_madvise@dontneed-before-pwrite:
- shard-dg2: NOTRUN -> [SKIP][21] ([i915#3282])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-8/igt@gem_madvise@dontneed-before-pwrite.html
- shard-mtlp: NOTRUN -> [SKIP][22] ([i915#3282])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-mtlp-5/igt@gem_madvise@dontneed-before-pwrite.html
* igt@gem_mmap@short-mmap:
- shard-dg1: NOTRUN -> [SKIP][23] ([i915#4083])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@gem_mmap@short-mmap.html
* igt@gem_partial_pwrite_pread@write-uncached:
- shard-rkl: NOTRUN -> [SKIP][24] ([i915#3282]) +3 other tests skip
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-3/igt@gem_partial_pwrite_pread@write-uncached.html
* igt@gem_pread@exhaustion:
- shard-glk: NOTRUN -> [WARN][25] ([i915#2658])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-glk8/igt@gem_pread@exhaustion.html
* igt@gem_pxp@create-protected-buffer:
- shard-rkl: NOTRUN -> [SKIP][26] ([i915#4270]) +3 other tests skip
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@gem_pxp@create-protected-buffer.html
- shard-dg1: NOTRUN -> [SKIP][27] ([i915#4270])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@gem_pxp@create-protected-buffer.html
* igt@gem_pxp@reject-modify-context-protection-off-1:
- shard-tglu: NOTRUN -> [SKIP][28] ([i915#4270])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-tglu-3/igt@gem_pxp@reject-modify-context-protection-off-1.html
* igt@gem_set_tiling_vs_blt@untiled-to-tiled:
- shard-dg1: NOTRUN -> [SKIP][29] ([i915#4079]) +1 other test skip
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@gem_set_tiling_vs_blt@untiled-to-tiled.html
- shard-rkl: NOTRUN -> [SKIP][30] ([i915#8411])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@gem_set_tiling_vs_blt@untiled-to-tiled.html
* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-dg1: NOTRUN -> [SKIP][31] ([i915#3297])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@gem_userptr_blits@readonly-pwrite-unsync.html
* igt@gem_userptr_blits@unsync-unmap-after-close:
- shard-rkl: NOTRUN -> [SKIP][32] ([i915#3297]) +3 other tests skip
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-3/igt@gem_userptr_blits@unsync-unmap-after-close.html
* igt@gen9_exec_parse@secure-batches:
- shard-rkl: NOTRUN -> [SKIP][33] ([i915#2527]) +1 other test skip
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@gen9_exec_parse@secure-batches.html
- shard-dg1: NOTRUN -> [SKIP][34] ([i915#2527])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@gen9_exec_parse@secure-batches.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-rkl: [PASS][35] -> [ABORT][36] ([i915#9820])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-rkl-4/igt@i915_module_load@reload-with-fault-injection.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-3/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_freq_api@freq-basic-api:
- shard-rkl: NOTRUN -> [SKIP][37] ([i915#8399])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@i915_pm_freq_api@freq-basic-api.html
* igt@i915_power@sanity:
- shard-mtlp: [PASS][38] -> [SKIP][39] ([i915#7984])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-mtlp-2/igt@i915_power@sanity.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-mtlp-5/igt@i915_power@sanity.html
* igt@i915_query@hwconfig_table:
- shard-tglu: NOTRUN -> [SKIP][40] ([i915#6245])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-tglu-3/igt@i915_query@hwconfig_table.html
* igt@i915_selftest@mock@memory_region:
- shard-rkl: NOTRUN -> [DMESG-WARN][41] ([i915#9311])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-3/igt@i915_selftest@mock@memory_region.html
* igt@i915_suspend@basic-s2idle-without-i915:
- shard-dg1: [PASS][42] -> [DMESG-WARN][43] ([i915#1982] / [i915#4391] / [i915#4423])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-dg1-18/igt@i915_suspend@basic-s2idle-without-i915.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-16/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@intel_hwmon@hwmon-write:
- shard-rkl: NOTRUN -> [SKIP][44] ([i915#7707])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@intel_hwmon@hwmon-write.html
* igt@kms_atomic_transition@modeset-transition-nonblocking-fencing@2x-outputs:
- shard-glk: [PASS][45] -> [FAIL][46] ([i915#11859])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-glk5/igt@kms_atomic_transition@modeset-transition-nonblocking-fencing@2x-outputs.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-glk8/igt@kms_atomic_transition@modeset-transition-nonblocking-fencing@2x-outputs.html
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels:
- shard-glk: NOTRUN -> [SKIP][47] ([i915#1769])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-glk8/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels.html
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-rkl: NOTRUN -> [SKIP][48] ([i915#1769] / [i915#3555])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-3/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels@pipe-a-edp-1:
- shard-mtlp: [PASS][49] -> [FAIL][50] ([i915#11808] / [i915#5956])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-mtlp-1/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels@pipe-a-edp-1.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-mtlp-3/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels@pipe-a-edp-1.html
* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-3:
- shard-dg2: NOTRUN -> [FAIL][51] ([i915#5956])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-6/igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-3.html
* igt@kms_big_fb@4-tiled-8bpp-rotate-0:
- shard-rkl: NOTRUN -> [SKIP][52] ([i915#5286]) +4 other tests skip
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-3/igt@kms_big_fb@4-tiled-8bpp-rotate-0.html
* igt@kms_big_fb@4-tiled-addfb-size-overflow:
- shard-dg1: NOTRUN -> [SKIP][53] ([i915#5286])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@kms_big_fb@4-tiled-addfb-size-overflow.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180:
- shard-tglu: NOTRUN -> [SKIP][54] ([i915#5286])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-tglu-3/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180.html
* igt@kms_big_fb@y-tiled-8bpp-rotate-270:
- shard-rkl: NOTRUN -> [SKIP][55] ([i915#3638]) +4 other tests skip
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@kms_big_fb@y-tiled-8bpp-rotate-270.html
- shard-dg1: NOTRUN -> [SKIP][56] ([i915#3638]) +1 other test skip
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@kms_big_fb@y-tiled-8bpp-rotate-270.html
* igt@kms_ccs@crc-primary-rotation-180-4-tiled-dg2-mc-ccs@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][57] ([i915#6095]) +55 other tests skip
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-4/igt@kms_ccs@crc-primary-rotation-180-4-tiled-dg2-mc-ccs@pipe-b-hdmi-a-1.html
* igt@kms_ccs@crc-primary-rotation-180-yf-tiled-ccs@pipe-d-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][58] ([i915#6095]) +51 other tests skip
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-13/igt@kms_ccs@crc-primary-rotation-180-yf-tiled-ccs@pipe-d-hdmi-a-3.html
* igt@kms_ccs@crc-sprite-planes-basic-y-tiled-ccs@pipe-b-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][59] ([i915#6095]) +3 other tests skip
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-tglu-3/igt@kms_ccs@crc-sprite-planes-basic-y-tiled-ccs@pipe-b-hdmi-a-1.html
* igt@kms_ccs@crc-sprite-planes-basic-y-tiled-gen12-mc-ccs@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][60] ([i915#10307] / [i915#6095]) +160 other tests skip
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-8/igt@kms_ccs@crc-sprite-planes-basic-y-tiled-gen12-mc-ccs@pipe-d-hdmi-a-1.html
* igt@kms_ccs@missing-ccs-buffer-y-tiled-ccs@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][61] ([i915#10307] / [i915#10434] / [i915#6095]) +6 other tests skip
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-2/igt@kms_ccs@missing-ccs-buffer-y-tiled-ccs@pipe-d-hdmi-a-1.html
* igt@kms_chamelium_audio@hdmi-audio:
- shard-dg2: NOTRUN -> [SKIP][62] ([i915#7828]) +1 other test skip
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-8/igt@kms_chamelium_audio@hdmi-audio.html
* igt@kms_chamelium_hpd@dp-hpd:
- shard-rkl: NOTRUN -> [SKIP][63] ([i915#7828]) +7 other tests skip
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@kms_chamelium_hpd@dp-hpd.html
* igt@kms_chamelium_hpd@dp-hpd-storm:
- shard-dg1: NOTRUN -> [SKIP][64] ([i915#7828])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@kms_chamelium_hpd@dp-hpd-storm.html
* igt@kms_chamelium_hpd@hdmi-hpd-storm:
- shard-mtlp: NOTRUN -> [SKIP][65] ([i915#7828]) +1 other test skip
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-mtlp-5/igt@kms_chamelium_hpd@hdmi-hpd-storm.html
* igt@kms_content_protection@srm:
- shard-tglu: NOTRUN -> [SKIP][66] ([i915#6944] / [i915#7116] / [i915#7118])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-tglu-3/igt@kms_content_protection@srm.html
* igt@kms_content_protection@srm@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][67] ([i915#7173])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-11/igt@kms_content_protection@srm@pipe-a-dp-4.html
* igt@kms_content_protection@type1:
- shard-rkl: NOTRUN -> [SKIP][68] ([i915#7118] / [i915#9424])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@kms_content_protection@type1.html
- shard-dg1: NOTRUN -> [SKIP][69] ([i915#7116] / [i915#9424])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@kms_content_protection@type1.html
* igt@kms_cursor_crc@cursor-onscreen-512x512:
- shard-rkl: NOTRUN -> [SKIP][70] ([i915#11453])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-3/igt@kms_cursor_crc@cursor-onscreen-512x512.html
* igt@kms_cursor_crc@cursor-random-512x512:
- shard-tglu: NOTRUN -> [SKIP][71] ([i915#11453])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-tglu-3/igt@kms_cursor_crc@cursor-random-512x512.html
* igt@kms_cursor_crc@cursor-rapid-movement-32x10:
- shard-rkl: NOTRUN -> [SKIP][72] ([i915#3555]) +7 other tests skip
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@kms_cursor_crc@cursor-rapid-movement-32x10.html
* igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy:
- shard-rkl: NOTRUN -> [SKIP][73] +21 other tests skip
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size:
- shard-rkl: NOTRUN -> [SKIP][74] ([i915#4103])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][75] ([i915#3804])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-2.html
* igt@kms_dsc@dsc-fractional-bpp-with-bpc:
- shard-tglu: NOTRUN -> [SKIP][76] ([i915#3840])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-tglu-3/igt@kms_dsc@dsc-fractional-bpp-with-bpc.html
* igt@kms_flip@2x-plain-flip-fb-recreate@ab-vga1-hdmi-a1:
- shard-snb: [PASS][77] -> [FAIL][78] ([i915#2122])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-snb2/igt@kms_flip@2x-plain-flip-fb-recreate@ab-vga1-hdmi-a1.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-snb7/igt@kms_flip@2x-plain-flip-fb-recreate@ab-vga1-hdmi-a1.html
* igt@kms_flip@2x-plain-flip-interruptible:
- shard-tglu: NOTRUN -> [SKIP][79] ([i915#3637]) +1 other test skip
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-tglu-3/igt@kms_flip@2x-plain-flip-interruptible.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-rkl: NOTRUN -> [SKIP][80] ([i915#2672]) +5 other tests skip
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-valid-mode.html
- shard-dg1: NOTRUN -> [SKIP][81] ([i915#2587] / [i915#2672]) +1 other test skip
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-dg1: NOTRUN -> [SKIP][82] ([i915#8708]) +4 other tests skip
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-cpu:
- shard-dg2: NOTRUN -> [SKIP][83] ([i915#5354])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-8/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-wc:
- shard-mtlp: NOTRUN -> [SKIP][84] ([i915#1825]) +1 other test skip
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-mtlp-5/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-wc.html
- shard-dg2: NOTRUN -> [SKIP][85] ([i915#8708])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-8/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt:
- shard-rkl: NOTRUN -> [SKIP][86] ([i915#1825]) +31 other tests skip
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-3/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-wc:
- shard-tglu: NOTRUN -> [SKIP][87] +1 other test skip
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-tglu-3/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-plflip-blt:
- shard-dg1: NOTRUN -> [SKIP][88] +8 other tests skip
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-modesetfrombusy:
- shard-rkl: NOTRUN -> [SKIP][89] ([i915#3023]) +21 other tests skip
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-3/igt@kms_frontbuffer_tracking@psr-modesetfrombusy.html
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-pwrite:
- shard-dg1: NOTRUN -> [SKIP][90] ([i915#3458]) +5 other tests skip
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@kms_frontbuffer_tracking@psr-rgb565-draw-pwrite.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-rkl: NOTRUN -> [SKIP][91] ([i915#3555] / [i915#8228]) +2 other tests skip
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-dg1: NOTRUN -> [SKIP][92] ([i915#3555] / [i915#8228])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_hdr@invalid-metadata-sizes:
- shard-dg2: NOTRUN -> [SKIP][93] ([i915#3555] / [i915#8228]) +1 other test skip
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-2/igt@kms_hdr@invalid-metadata-sizes.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-rkl: NOTRUN -> [SKIP][94] ([i915#4070] / [i915#4816])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-rotation@pipe-a-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][95] ([i915#9423]) +3 other tests skip
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-tglu-3/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-rotation@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][96] ([i915#9423]) +9 other tests skip
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-3/igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-a-hdmi-a-2.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][97] ([i915#9728]) +7 other tests skip
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-c-hdmi-a-2:
- shard-dg2: NOTRUN -> [SKIP][98] ([i915#5235] / [i915#9423]) +2 other tests skip
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-3/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-c-hdmi-a-2.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-c-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][99] ([i915#9728]) +7 other tests skip
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-13/igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-c-hdmi-a-3.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-c-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][100] ([i915#9423]) +24 other tests skip
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-4/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-c-hdmi-a-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][101] +202 other tests skip
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-glk8/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-1.html
* igt@kms_pm_backlight@fade:
- shard-rkl: NOTRUN -> [SKIP][102] ([i915#5354])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@kms_pm_backlight@fade.html
* igt@kms_pm_lpsp@screens-disabled:
- shard-rkl: NOTRUN -> [SKIP][103] ([i915#8430])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-3/igt@kms_pm_lpsp@screens-disabled.html
* igt@kms_pm_rpm@dpms-lpsp:
- shard-rkl: [PASS][104] -> [SKIP][105] ([i915#9519])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-rkl-2/igt@kms_pm_rpm@dpms-lpsp.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@kms_pm_rpm@dpms-lpsp.html
* igt@kms_pm_rpm@dpms-mode-unset-lpsp:
- shard-dg2: [PASS][106] -> [SKIP][107] ([i915#9519])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-dg2-8/igt@kms_pm_rpm@dpms-mode-unset-lpsp.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-6/igt@kms_pm_rpm@dpms-mode-unset-lpsp.html
* igt@kms_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-rkl: NOTRUN -> [SKIP][108] ([i915#9519])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@kms_pm_rpm@modeset-lpsp-stress-no-wait.html
* igt@kms_pm_rpm@pm-tiling:
- shard-dg1: NOTRUN -> [SKIP][109] ([i915#4077]) +2 other tests skip
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@kms_pm_rpm@pm-tiling.html
* igt@kms_prime@basic-modeset-hybrid:
- shard-rkl: NOTRUN -> [SKIP][110] ([i915#6524])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@kms_prime@basic-modeset-hybrid.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-dg1: NOTRUN -> [SKIP][111] ([i915#11520])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
* igt@kms_psr2_sf@fbc-overlay-plane-update-sf-dmg-area:
- shard-rkl: NOTRUN -> [SKIP][112] ([i915#11520]) +3 other tests skip
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-3/igt@kms_psr2_sf@fbc-overlay-plane-update-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-rkl: NOTRUN -> [SKIP][113] ([i915#9683])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@fbc-psr2-cursor-blt:
- shard-dg2: NOTRUN -> [SKIP][114] ([i915#1072] / [i915#9732])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-8/igt@kms_psr@fbc-psr2-cursor-blt.html
* igt@kms_psr@psr-sprite-plane-onoff:
- shard-dg1: NOTRUN -> [SKIP][115] ([i915#1072] / [i915#9732]) +5 other tests skip
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@kms_psr@psr-sprite-plane-onoff.html
* igt@kms_psr@psr2-cursor-mmap-gtt:
- shard-rkl: NOTRUN -> [SKIP][116] ([i915#1072] / [i915#9732]) +19 other tests skip
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@kms_psr@psr2-cursor-mmap-gtt.html
* igt@kms_psr@psr2-cursor-plane-onoff:
- shard-tglu: NOTRUN -> [SKIP][117] ([i915#9732]) +1 other test skip
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-tglu-3/igt@kms_psr@psr2-cursor-plane-onoff.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0:
- shard-rkl: NOTRUN -> [SKIP][118] ([i915#5289])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0.html
- shard-dg1: NOTRUN -> [SKIP][119] ([i915#5289])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0.html
* igt@kms_vrr@lobf:
- shard-rkl: NOTRUN -> [SKIP][120] ([i915#11920])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@kms_vrr@lobf.html
- shard-dg1: NOTRUN -> [SKIP][121] ([i915#11920])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@kms_vrr@lobf.html
* igt@kms_vrr@negative-basic:
- shard-rkl: NOTRUN -> [SKIP][122] ([i915#3555] / [i915#9906])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@kms_vrr@negative-basic.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-dg1: NOTRUN -> [SKIP][123] ([i915#2437])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@kms_writeback@writeback-invalid-parameters.html
- shard-rkl: NOTRUN -> [SKIP][124] ([i915#2437])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@kms_writeback@writeback-invalid-parameters.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-glk: NOTRUN -> [SKIP][125] ([i915#2437]) +1 other test skip
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-glk8/igt@kms_writeback@writeback-pixel-formats.html
* igt@perf_pmu@cpu-hotplug:
- shard-rkl: NOTRUN -> [SKIP][126] ([i915#8850])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@perf_pmu@cpu-hotplug.html
- shard-dg1: NOTRUN -> [SKIP][127] ([i915#8850])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-18/igt@perf_pmu@cpu-hotplug.html
* igt@prime_vgem@basic-fence-read:
- shard-rkl: NOTRUN -> [SKIP][128] ([i915#3291] / [i915#3708]) +1 other test skip
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@fence-write-hang:
- shard-rkl: NOTRUN -> [SKIP][129] ([i915#3708])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-3/igt@prime_vgem@fence-write-hang.html
* igt@sriov_basic@enable-vfs-bind-unbind-each-numvfs-all:
- shard-rkl: NOTRUN -> [SKIP][130] ([i915#9917])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@sriov_basic@enable-vfs-bind-unbind-each-numvfs-all.html
* igt@syncobj_timeline@invalid-wait-zero-handles:
- shard-rkl: NOTRUN -> [FAIL][131] ([i915#9781]) +1 other test fail
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@syncobj_timeline@invalid-wait-zero-handles.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- shard-rkl: [FAIL][132] ([i915#7742]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-rkl-6/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-5/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
* igt@gem_exec_create@forked@smem:
- shard-glk: [INCOMPLETE][134] -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-glk5/igt@gem_exec_create@forked@smem.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-glk8/igt@gem_exec_create@forked@smem.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-rkl: [FAIL][136] ([i915#2842]) -> [PASS][137] +1 other test pass
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-rkl-5/igt@gem_exec_fair@basic-pace@rcs0.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@kms_atomic_transition@plane-toggle-modeset-transition@pipe-a-hdmi-a-1:
- shard-tglu: [FAIL][138] ([i915#11808]) -> [PASS][139]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-tglu-8/igt@kms_atomic_transition@plane-toggle-modeset-transition@pipe-a-hdmi-a-1.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-tglu-5/igt@kms_atomic_transition@plane-toggle-modeset-transition@pipe-a-hdmi-a-1.html
* igt@kms_atomic_transition@plane-toggle-modeset-transition@pipe-a-vga-1:
- shard-snb: [FAIL][140] ([i915#5956]) -> [PASS][141]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-snb7/igt@kms_atomic_transition@plane-toggle-modeset-transition@pipe-a-vga-1.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-snb7/igt@kms_atomic_transition@plane-toggle-modeset-transition@pipe-a-vga-1.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][142] ([i915#2346]) -> [PASS][143]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@torture-bo@pipe-a:
- shard-snb: [DMESG-WARN][144] ([i915#10166]) -> [PASS][145]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-snb5/igt@kms_cursor_legacy@torture-bo@pipe-a.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-snb4/igt@kms_cursor_legacy@torture-bo@pipe-a.html
* igt@kms_plane@pixel-format-source-clamping@pipe-a-plane-0:
- shard-tglu: [ABORT][146] -> [PASS][147]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-tglu-9/igt@kms_plane@pixel-format-source-clamping@pipe-a-plane-0.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-tglu-3/igt@kms_plane@pixel-format-source-clamping@pipe-a-plane-0.html
* igt@kms_pm_dc@dc6-dpms:
- shard-tglu: [FAIL][148] ([i915#9295]) -> [PASS][149]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-tglu-9/igt@kms_pm_dc@dc6-dpms.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-tglu-3/igt@kms_pm_dc@dc6-dpms.html
* igt@kms_pm_rpm@modeset-non-lpsp-stress:
- shard-dg2: [SKIP][150] ([i915#9519]) -> [PASS][151] +1 other test pass
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-dg2-4/igt@kms_pm_rpm@modeset-non-lpsp-stress.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-11/igt@kms_pm_rpm@modeset-non-lpsp-stress.html
* igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-rkl: [SKIP][152] ([i915#9519]) -> [PASS][153] +1 other test pass
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-rkl-2/igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@kms_sequence@queue-busy@pipe-c-edp-1:
- shard-mtlp: [INCOMPLETE][154] -> [PASS][155]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-mtlp-6/igt@kms_sequence@queue-busy@pipe-c-edp-1.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-mtlp-5/igt@kms_sequence@queue-busy@pipe-c-edp-1.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1:
- shard-snb: [FAIL][156] ([i915#9196]) -> [PASS][157]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-snb5/igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-snb6/igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1.html
* igt@perf@blocking@0-rcs0:
- shard-rkl: [FAIL][158] ([i915#10538]) -> [PASS][159]
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-rkl-5/igt@perf@blocking@0-rcs0.html
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-rkl-6/igt@perf@blocking@0-rcs0.html
#### Warnings ####
* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg2: [TIMEOUT][160] ([i915#5493]) -> [DMESG-WARN][161] ([i915#4936] / [i915#5493])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-dg2-2/igt@gem_lmem_swapping@smem-oom@lmem0.html
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-4/igt@gem_lmem_swapping@smem-oom@lmem0.html
- shard-dg1: [TIMEOUT][162] ([i915#5493]) -> [DMESG-WARN][163] ([i915#1982] / [i915#4936] / [i915#5493])
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-dg1-18/igt@gem_lmem_swapping@smem-oom@lmem0.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg1-16/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-tglu: [ABORT][164] ([i915#10887] / [i915#9820]) -> [ABORT][165] ([i915#9820])
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-tglu-5/igt@i915_module_load@reload-with-fault-injection.html
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-tglu-3/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_cursor_crc@cursor-random-512x170:
- shard-dg2: [SKIP][166] ([i915#11453] / [i915#3359]) -> [SKIP][167] ([i915#11453]) +3 other tests skip
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-dg2-11/igt@kms_cursor_crc@cursor-random-512x170.html
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-2/igt@kms_cursor_crc@cursor-random-512x170.html
* igt@kms_cursor_crc@cursor-random-512x512:
- shard-dg2: [SKIP][168] ([i915#11453]) -> [SKIP][169] ([i915#11453] / [i915#3359]) +1 other test skip
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-dg2-1/igt@kms_cursor_crc@cursor-random-512x512.html
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-11/igt@kms_cursor_crc@cursor-random-512x512.html
* igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-vga1-hdmi-a1:
- shard-snb: [FAIL][170] ([i915#2122]) -> [FAIL][171] ([i915#10826])
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-snb7/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-vga1-hdmi-a1.html
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-snb7/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-vga1-hdmi-a1.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-pwrite:
- shard-dg2: [SKIP][172] ([i915#10433] / [i915#3458]) -> [SKIP][173] ([i915#3458]) +3 other tests skip
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-dg2-4/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-pwrite.html
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-dg2: [SKIP][174] ([i915#3458]) -> [SKIP][175] ([i915#10433] / [i915#3458])
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-dg2-5/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-4/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
* igt@kms_psr@psr-cursor-render:
- shard-dg2: [SKIP][176] ([i915#1072] / [i915#9732]) -> [SKIP][177] ([i915#1072] / [i915#9673] / [i915#9732]) +13 other tests skip
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-dg2-4/igt@kms_psr@psr-cursor-render.html
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-11/igt@kms_psr@psr-cursor-render.html
* igt@kms_psr@psr2-primary-page-flip:
- shard-dg2: [SKIP][178] ([i915#1072] / [i915#9673] / [i915#9732]) -> [SKIP][179] ([i915#1072] / [i915#9732]) +14 other tests skip
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-dg2-11/igt@kms_psr@psr2-primary-page-flip.html
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-2/igt@kms_psr@psr2-primary-page-flip.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270:
- shard-dg2: [SKIP][180] ([i915#11131] / [i915#5190]) -> [SKIP][181] ([i915#11131] / [i915#4235] / [i915#5190])
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-dg2-1/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270.html
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-11/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90:
- shard-dg2: [SKIP][182] ([i915#11131] / [i915#4235] / [i915#5190]) -> [SKIP][183] ([i915#11131] / [i915#5190])
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-dg2-11/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90.html
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-3/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90.html
* igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
- shard-dg2: [SKIP][184] ([i915#11131]) -> [SKIP][185] ([i915#11131] / [i915#4235]) +3 other tests skip
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-dg2-1/igt@kms_rotation_crc@sprite-rotation-90-pos-100-0.html
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-11/igt@kms_rotation_crc@sprite-rotation-90-pos-100-0.html
* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: [FAIL][186] ([i915#7484]) -> [FAIL][187] ([i915#9100])
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15215/shard-dg2-7/igt@perf@non-zero-reason@0-rcs0.html
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/shard-dg2-11/igt@perf@non-zero-reason@0-rcs0.html
[i915#10166]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10166
[i915#10307]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10307
[i915#10433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10433
[i915#10434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10434
[i915#10538]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10538
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#10826]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10826
[i915#10887]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10887
[i915#11131]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11131
[i915#11453]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11453
[i915#11520]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11520
[i915#11808]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11808
[i915#11859]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11859
[i915#11920]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11920
[i915#1769]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1825
[i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2527
[i915#2587]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2842
[i915#3023]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#3778]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3778
[i915#3804]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3804
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#4070]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4235
[i915#4270]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4270
[i915#4391]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4391
[i915#4423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4423
[i915#4525]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4816
[i915#4852]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4852
[i915#4936]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4936
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5493
[i915#5956]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5956
[i915#6095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6095
[i915#6245]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6245
[i915#6334]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6334
[i915#6524]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6524
[i915#6944]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6944
[i915#7116]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7118
[i915#7173]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7173
[i915#7484]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7484
[i915#7707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7707
[i915#7742]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7828
[i915#7984]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7984
[i915#8228]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8228
[i915#8399]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8399
[i915#8411]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8411
[i915#8430]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8430
[i915#8708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8708
[i915#8850]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8850
[i915#9100]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9100
[i915#9196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9196
[i915#9295]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9295
[i915#9311]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9311
[i915#9423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9423
[i915#9424]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9424
[i915#9519]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9519
[i915#9673]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9673
[i915#9683]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9683
[i915#9728]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9728
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9781]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9781
[i915#9820]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9820
[i915#9906]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9906
[i915#9917]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9917
Build changes
-------------
* Linux: CI_DRM_15215 -> Patchwork_136036v5
CI-20190529: 20190529
CI_DRM_15215: fbd5dee4a651d4c70b3d2ee5052fb20eab02a317 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7966: f16c5f500adc5fa41bd52a3ef2a84165da4fb596 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_136036v5: fbd5dee4a651d4c70b3d2ee5052fb20eab02a317 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136036v5/index.html
[-- Attachment #2: Type: text/html, Size: 63209 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v5] drm/i915/hwmon: expose fan speed
2024-08-12 8:15 [PATCH v5] drm/i915/hwmon: expose fan speed Raag Jadav
` (4 preceding siblings ...)
2024-08-12 22:43 ` ✓ Fi.CI.IGT: success for drm/i915/hwmon: expose fan speed (rev5) Patchwork
@ 2024-08-13 0:38 ` kernel test robot
5 siblings, 0 replies; 12+ messages in thread
From: kernel test robot @ 2024-08-13 0:38 UTC (permalink / raw)
To: Raag Jadav, jani.nikula, joonas.lahtinen, rodrigo.vivi, tursulin,
airlied, daniel, linux, andi.shyti, andriy.shevchenko
Cc: oe-kbuild-all, intel-gfx, dri-devel, linux-hwmon, linux-kernel,
anshuman.gupta, badal.nilawar, riana.tauro, ashutosh.dixit,
karthik.poosa, Raag Jadav
Hi Raag,
kernel test robot noticed the following build errors:
[auto build test ERROR on groeck-staging/hwmon-next]
[also build test ERROR on linus/master v6.11-rc3 next-20240812]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Raag-Jadav/drm-i915-hwmon-expose-fan-speed/20240812-161645
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
patch link: https://lore.kernel.org/r/20240812081538.1457396-1-raag.jadav%40intel.com
patch subject: [PATCH v5] drm/i915/hwmon: expose fan speed
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20240813/202408130800.XtY6XxQ5-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240813/202408130800.XtY6XxQ5-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408130800.XtY6XxQ5-lkp@intel.com/
All errors (new ones prefixed by >>):
ld: drivers/gpu/drm/i915/i915_hwmon.o: in function `hwm_read':
>> i915_hwmon.c:(.text+0xe60): undefined reference to `__udivdi3'
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v5] drm/i915/hwmon: expose fan speed
2024-08-12 13:15 ` [PATCH v5] drm/i915/hwmon: expose fan speed Andy Shevchenko
@ 2024-08-13 5:45 ` Raag Jadav
2024-08-13 8:27 ` Andy Shevchenko
0 siblings, 1 reply; 12+ messages in thread
From: Raag Jadav @ 2024-08-13 5:45 UTC (permalink / raw)
To: Andy Shevchenko
Cc: jani.nikula, joonas.lahtinen, rodrigo.vivi, tursulin, airlied,
daniel, linux, andi.shyti, intel-gfx, dri-devel, linux-hwmon,
linux-kernel, anshuman.gupta, badal.nilawar, riana.tauro,
ashutosh.dixit, karthik.poosa
On Mon, Aug 12, 2024 at 04:15:14PM +0300, Andy Shevchenko wrote:
> On Mon, Aug 12, 2024 at 01:45:38PM +0530, Raag Jadav wrote:
> > Add hwmon support for fan1_input attribute, which will expose fan speed
> > in RPM. With this in place we can monitor fan speed using lm-sensors tool.
> >
> > $ sensors
> > i915-pci-0300
> > Adapter: PCI adapter
> > in0: 653.00 mV
> > fan1: 3833 RPM
> > power1: N/A (max = 43.00 W)
> > energy1: 32.02 kJ
>
> ...
>
> > +static int
> > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val)
> > +{
> > + struct i915_hwmon *hwmon = ddat->hwmon;
> > + struct hwm_fan_info *fi = &ddat->fi;
> > + u64 rotations, time_now, time;
> > + intel_wakeref_t wakeref;
> > + u32 reg_val, pulses;
> > + int ret = 0;
> > +
> > + if (attr != hwmon_fan_input)
> > + return -EOPNOTSUPP;
> > +
> > + wakeref = intel_runtime_pm_get(ddat->uncore->rpm);
> > + mutex_lock(&hwmon->hwmon_lock);
> > +
> > + reg_val = intel_uncore_read(ddat->uncore, hwmon->rg.fan_speed);
> > + time_now = get_jiffies_64();
>
> > + /* Handle HW register overflow */
> > + if (reg_val >= fi->reg_val_prev)
> > + pulses = reg_val - fi->reg_val_prev;
> > + else
> > + pulses = UINT_MAX - fi->reg_val_prev + reg_val;
>
> Isn't it the abs_diff() reimplementation?
Not exactly. This is specific to 32 bit register overflow, so we count
from max value.
Raag
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v5] drm/i915/hwmon: expose fan speed
2024-08-12 13:50 ` Andi Shyti
@ 2024-08-13 6:30 ` Raag Jadav
2024-08-21 14:58 ` Andi Shyti
0 siblings, 1 reply; 12+ messages in thread
From: Raag Jadav @ 2024-08-13 6:30 UTC (permalink / raw)
To: Andi Shyti
Cc: jani.nikula, joonas.lahtinen, rodrigo.vivi, tursulin, airlied,
daniel, linux, andriy.shevchenko, intel-gfx, dri-devel,
linux-hwmon, linux-kernel, anshuman.gupta, badal.nilawar,
riana.tauro, ashutosh.dixit, karthik.poosa
On Mon, Aug 12, 2024 at 03:50:47PM +0200, Andi Shyti wrote:
> Hi Raag,
>
> > +static int
> > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val)
> > +{
> > + struct i915_hwmon *hwmon = ddat->hwmon;
> > + struct hwm_fan_info *fi = &ddat->fi;
> > + u64 rotations, time_now, time;
> > + intel_wakeref_t wakeref;
> > + u32 reg_val, pulses;
> > + int ret = 0;
> > +
> > + if (attr != hwmon_fan_input)
> > + return -EOPNOTSUPP;
> > +
> > + wakeref = intel_runtime_pm_get(ddat->uncore->rpm);
> > + mutex_lock(&hwmon->hwmon_lock);
> > +
> > + reg_val = intel_uncore_read(ddat->uncore, hwmon->rg.fan_speed);
> > + time_now = get_jiffies_64();
> > +
> > + /* Handle HW register overflow */
> > + if (reg_val >= fi->reg_val_prev)
> > + pulses = reg_val - fi->reg_val_prev;
> > + else
> > + pulses = UINT_MAX - fi->reg_val_prev + reg_val;
> > +
> > + /*
> > + * HW register value is accumulated count of pulses from
> > + * PWM fan with the scale of 2 pulses per rotation.
> > + */
> > + rotations = pulses / 2;
> > +
> > + time = jiffies_delta_to_msecs(time_now - fi->time_prev);
> > + if (unlikely(!time)) {
> > + ret = -EAGAIN;
> > + goto exit;
> > + }
>
> Can you please add a comment describing how you obtain the speed
> calculation?
That's what I initially tried but ended up dropping it in favour of RPM
formula below, which I found to be doing a better job of explaining than
a few lines of description.
> Basically at every read you store the values. Is it possible that
> we don't have reads for a long time and the register resets more
> than once?
Considering a fan continuously running at higher speeds (for example 4000 RPM
which is quite optimistic), with the scale of 2 pulses per rotation, a 32 bit
register will take around a year to overflow, which is more than most usecases
I could think of.
Raag
> > + /*
> > + * Convert to minutes for calculating RPM.
> > + * RPM = number of rotations * msecs per minute / time in msecs
> > + */
> > + *val = DIV_ROUND_UP(rotations * (MSEC_PER_SEC * 60), time);
> > +
> > + fi->reg_val_prev = reg_val;
> > + fi->time_prev = time_now;
> > +exit:
> > + mutex_unlock(&hwmon->hwmon_lock);
> > + intel_runtime_pm_put(ddat->uncore->rpm, wakeref);
> > + return ret;
> > +}
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v5] drm/i915/hwmon: expose fan speed
2024-08-13 5:45 ` Raag Jadav
@ 2024-08-13 8:27 ` Andy Shevchenko
2024-08-13 10:03 ` Raag Jadav
0 siblings, 1 reply; 12+ messages in thread
From: Andy Shevchenko @ 2024-08-13 8:27 UTC (permalink / raw)
To: Raag Jadav
Cc: jani.nikula, joonas.lahtinen, rodrigo.vivi, tursulin, airlied,
daniel, linux, andi.shyti, intel-gfx, dri-devel, linux-hwmon,
linux-kernel, anshuman.gupta, badal.nilawar, riana.tauro,
ashutosh.dixit, karthik.poosa
On Tue, Aug 13, 2024 at 08:45:19AM +0300, Raag Jadav wrote:
> On Mon, Aug 12, 2024 at 04:15:14PM +0300, Andy Shevchenko wrote:
> > On Mon, Aug 12, 2024 at 01:45:38PM +0530, Raag Jadav wrote:
...
> > > +static int
> > > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val)
> > > +{
> > > + struct i915_hwmon *hwmon = ddat->hwmon;
> > > + struct hwm_fan_info *fi = &ddat->fi;
> > > + u64 rotations, time_now, time;
> > > + intel_wakeref_t wakeref;
> > > + u32 reg_val, pulses;
> > > + int ret = 0;
> > > +
> > > + if (attr != hwmon_fan_input)
> > > + return -EOPNOTSUPP;
> > > +
> > > + wakeref = intel_runtime_pm_get(ddat->uncore->rpm);
> > > + mutex_lock(&hwmon->hwmon_lock);
> > > +
> > > + reg_val = intel_uncore_read(ddat->uncore, hwmon->rg.fan_speed);
> > > + time_now = get_jiffies_64();
> >
> > > + /* Handle HW register overflow */
> > > + if (reg_val >= fi->reg_val_prev)
> > > + pulses = reg_val - fi->reg_val_prev;
> > > + else
> > > + pulses = UINT_MAX - fi->reg_val_prev + reg_val;
> >
> > Isn't it the abs_diff() reimplementation?
>
> Not exactly. This is specific to 32 bit register overflow, so we count
> from max value.
I see. But since you have the both variables of u32, why:
1) UINT_MAX?
2) Not simply using
pulses = reg_val - fi->reg_val_prev;
which will wrap over correctly?
Note, in your case (in comparison to the wrap over variant) the off-by-one is
present. Is it on purpose?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v5] drm/i915/hwmon: expose fan speed
2024-08-13 8:27 ` Andy Shevchenko
@ 2024-08-13 10:03 ` Raag Jadav
0 siblings, 0 replies; 12+ messages in thread
From: Raag Jadav @ 2024-08-13 10:03 UTC (permalink / raw)
To: Andy Shevchenko
Cc: jani.nikula, joonas.lahtinen, rodrigo.vivi, tursulin, airlied,
daniel, linux, andi.shyti, intel-gfx, dri-devel, linux-hwmon,
linux-kernel, anshuman.gupta, badal.nilawar, riana.tauro,
ashutosh.dixit, karthik.poosa
On Tue, Aug 13, 2024 at 11:27:22AM +0300, Andy Shevchenko wrote:
> On Tue, Aug 13, 2024 at 08:45:19AM +0300, Raag Jadav wrote:
> > On Mon, Aug 12, 2024 at 04:15:14PM +0300, Andy Shevchenko wrote:
> > > On Mon, Aug 12, 2024 at 01:45:38PM +0530, Raag Jadav wrote:
>
> ...
>
> > > > +static int
> > > > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val)
> > > > +{
> > > > + struct i915_hwmon *hwmon = ddat->hwmon;
> > > > + struct hwm_fan_info *fi = &ddat->fi;
> > > > + u64 rotations, time_now, time;
> > > > + intel_wakeref_t wakeref;
> > > > + u32 reg_val, pulses;
> > > > + int ret = 0;
> > > > +
> > > > + if (attr != hwmon_fan_input)
> > > > + return -EOPNOTSUPP;
> > > > +
> > > > + wakeref = intel_runtime_pm_get(ddat->uncore->rpm);
> > > > + mutex_lock(&hwmon->hwmon_lock);
> > > > +
> > > > + reg_val = intel_uncore_read(ddat->uncore, hwmon->rg.fan_speed);
> > > > + time_now = get_jiffies_64();
> > >
> > > > + /* Handle HW register overflow */
> > > > + if (reg_val >= fi->reg_val_prev)
> > > > + pulses = reg_val - fi->reg_val_prev;
> > > > + else
> > > > + pulses = UINT_MAX - fi->reg_val_prev + reg_val;
> > >
> > > Isn't it the abs_diff() reimplementation?
> >
> > Not exactly. This is specific to 32 bit register overflow, so we count
> > from max value.
>
> I see. But since you have the both variables of u32, why:
> 1) UINT_MAX?
> 2) Not simply using
>
> pulses = reg_val - fi->reg_val_prev;
>
> which will wrap over correctly?
Agree. Will update.
Raag
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v5] drm/i915/hwmon: expose fan speed
2024-08-13 6:30 ` Raag Jadav
@ 2024-08-21 14:58 ` Andi Shyti
0 siblings, 0 replies; 12+ messages in thread
From: Andi Shyti @ 2024-08-21 14:58 UTC (permalink / raw)
To: Raag Jadav
Cc: Andi Shyti, jani.nikula, joonas.lahtinen, rodrigo.vivi, tursulin,
airlied, daniel, linux, andriy.shevchenko, intel-gfx, dri-devel,
linux-hwmon, linux-kernel, anshuman.gupta, badal.nilawar,
riana.tauro, ashutosh.dixit, karthik.poosa
> > > + /*
> > > + * HW register value is accumulated count of pulses from
> > > + * PWM fan with the scale of 2 pulses per rotation.
> > > + */
> > > + rotations = pulses / 2;
> > > +
> > > + time = jiffies_delta_to_msecs(time_now - fi->time_prev);
> > > + if (unlikely(!time)) {
> > > + ret = -EAGAIN;
> > > + goto exit;
> > > + }
> >
> > Can you please add a comment describing how you obtain the speed
> > calculation?
>
> That's what I initially tried but ended up dropping it in favour of RPM
> formula below, which I found to be doing a better job of explaining than
> a few lines of description.
>
> > Basically at every read you store the values. Is it possible that
> > we don't have reads for a long time and the register resets more
> > than once?
>
> Considering a fan continuously running at higher speeds (for example 4000 RPM
> which is quite optimistic), with the scale of 2 pulses per rotation, a 32 bit
> register will take around a year to overflow, which is more than most usecases
> I could think of.
Which can be considered as a worse case scenario. I would have
preferred here a runtime calculation, which means read now, wait
a bit, read again and calculate. The read might be slow, but
efficient.
Anyway, your argument makes sense, so that I'm not going to push
on this, I already r-b'ed it.
Thanks,
Andi
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2024-08-21 14:58 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-12 8:15 [PATCH v5] drm/i915/hwmon: expose fan speed Raag Jadav
2024-08-12 10:14 ` ✓ Fi.CI.BAT: success for drm/i915/hwmon: expose fan speed (rev5) Patchwork
2024-08-12 13:15 ` [PATCH v5] drm/i915/hwmon: expose fan speed Andy Shevchenko
2024-08-13 5:45 ` Raag Jadav
2024-08-13 8:27 ` Andy Shevchenko
2024-08-13 10:03 ` Raag Jadav
2024-08-12 13:50 ` Andi Shyti
2024-08-13 6:30 ` Raag Jadav
2024-08-21 14:58 ` Andi Shyti
2024-08-12 21:36 ` kernel test robot
2024-08-12 22:43 ` ✓ Fi.CI.IGT: success for drm/i915/hwmon: expose fan speed (rev5) Patchwork
2024-08-13 0:38 ` [PATCH v5] drm/i915/hwmon: expose fan speed kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.