* [PATCH] libxl/disk: avoid aliasing of abs()
@ 2024-08-06 8:40 Jan Beulich
2024-08-06 10:29 ` Jürgen Groß
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Jan Beulich @ 2024-08-06 8:40 UTC (permalink / raw)
To: xen-devel@lists.xenproject.org
Cc: Anthony PERARD, Juergen Gross, Jason Andryuk
Tool chains with -Wshadow enabled by default won't like the function
parameter name "abs", for aliasing stdlib.h's abs(). Rename the
parameter to what other similar functions use.
Fixes: a18b50614d97 ("libxl: Enable stubdom cdrom changing")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/tools/libs/light/libxl_disk.c
+++ b/tools/libs/light/libxl_disk.c
@@ -935,7 +935,7 @@ static void cdrom_insert_stubdom_disk_ad
libxl__ao_device *aodev);
static void cdrom_insert_stubdom_query_fdset(libxl__egc *egc,
libxl__ev_time *ev,
- const struct timeval *abs,
+ const struct timeval *requested_abs,
int rc);
static void cdrom_insert_stubdom_parse_fdset(libxl__egc *egc,
libxl__ev_qmp *qmp,
@@ -1259,7 +1259,7 @@ static void cdrom_insert_stubdom_disk_ad
static void cdrom_insert_stubdom_query_fdset(libxl__egc *egc,
libxl__ev_time *ev,
- const struct timeval *abs,
+ const struct timeval *requested_abs,
int rc)
{
EGC_GC;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libxl/disk: avoid aliasing of abs()
2024-08-06 8:40 [PATCH] libxl/disk: avoid aliasing of abs() Jan Beulich
@ 2024-08-06 10:29 ` Jürgen Groß
2024-08-06 17:43 ` Stefano Stabellini
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Jürgen Groß @ 2024-08-06 10:29 UTC (permalink / raw)
To: Jan Beulich, xen-devel@lists.xenproject.org; +Cc: Anthony PERARD, Jason Andryuk
On 06.08.24 10:40, Jan Beulich wrote:
> Tool chains with -Wshadow enabled by default won't like the function
> parameter name "abs", for aliasing stdlib.h's abs(). Rename the
> parameter to what other similar functions use.
>
> Fixes: a18b50614d97 ("libxl: Enable stubdom cdrom changing")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libxl/disk: avoid aliasing of abs()
2024-08-06 8:40 [PATCH] libxl/disk: avoid aliasing of abs() Jan Beulich
2024-08-06 10:29 ` Jürgen Groß
@ 2024-08-06 17:43 ` Stefano Stabellini
2024-08-07 13:40 ` Jason Andryuk
2024-08-13 16:58 ` Anthony PERARD
3 siblings, 0 replies; 5+ messages in thread
From: Stefano Stabellini @ 2024-08-06 17:43 UTC (permalink / raw)
To: Jan Beulich
Cc: xen-devel@lists.xenproject.org, Anthony PERARD, Juergen Gross,
Jason Andryuk
On Tue, 5 Aug 2024, Jan Beulich wrote:
> Tool chains with -Wshadow enabled by default won't like the function
> parameter name "abs", for aliasing stdlib.h's abs(). Rename the
> parameter to what other similar functions use.
>
> Fixes: a18b50614d97 ("libxl: Enable stubdom cdrom changing")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> --- a/tools/libs/light/libxl_disk.c
> +++ b/tools/libs/light/libxl_disk.c
> @@ -935,7 +935,7 @@ static void cdrom_insert_stubdom_disk_ad
> libxl__ao_device *aodev);
> static void cdrom_insert_stubdom_query_fdset(libxl__egc *egc,
> libxl__ev_time *ev,
> - const struct timeval *abs,
> + const struct timeval *requested_abs,
> int rc);
> static void cdrom_insert_stubdom_parse_fdset(libxl__egc *egc,
> libxl__ev_qmp *qmp,
> @@ -1259,7 +1259,7 @@ static void cdrom_insert_stubdom_disk_ad
>
> static void cdrom_insert_stubdom_query_fdset(libxl__egc *egc,
> libxl__ev_time *ev,
> - const struct timeval *abs,
> + const struct timeval *requested_abs,
> int rc)
> {
> EGC_GC;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libxl/disk: avoid aliasing of abs()
2024-08-06 8:40 [PATCH] libxl/disk: avoid aliasing of abs() Jan Beulich
2024-08-06 10:29 ` Jürgen Groß
2024-08-06 17:43 ` Stefano Stabellini
@ 2024-08-07 13:40 ` Jason Andryuk
2024-08-13 16:58 ` Anthony PERARD
3 siblings, 0 replies; 5+ messages in thread
From: Jason Andryuk @ 2024-08-07 13:40 UTC (permalink / raw)
To: Jan Beulich, xen-devel@lists.xenproject.org; +Cc: Anthony PERARD, Juergen Gross
On 2024-08-06 04:40, Jan Beulich wrote:
> Tool chains with -Wshadow enabled by default won't like the function
> parameter name "abs", for aliasing stdlib.h's abs(). Rename the
> parameter to what other similar functions use.
>
> Fixes: a18b50614d97 ("libxl: Enable stubdom cdrom changing")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>
Thanks,
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libxl/disk: avoid aliasing of abs()
2024-08-06 8:40 [PATCH] libxl/disk: avoid aliasing of abs() Jan Beulich
` (2 preceding siblings ...)
2024-08-07 13:40 ` Jason Andryuk
@ 2024-08-13 16:58 ` Anthony PERARD
3 siblings, 0 replies; 5+ messages in thread
From: Anthony PERARD @ 2024-08-13 16:58 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, Juergen Gross, Jason Andryuk
On Tue, Aug 06, 2024 at 10:40:14AM +0200, Jan Beulich wrote:
> Tool chains with -Wshadow enabled by default won't like the function
> parameter name "abs", for aliasing stdlib.h's abs(). Rename the
> parameter to what other similar functions use.
>
> Fixes: a18b50614d97 ("libxl: Enable stubdom cdrom changing")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Anthony PERARD <anthony.perard@vates.tech>
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-08-13 16:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-06 8:40 [PATCH] libxl/disk: avoid aliasing of abs() Jan Beulich
2024-08-06 10:29 ` Jürgen Groß
2024-08-06 17:43 ` Stefano Stabellini
2024-08-07 13:40 ` Jason Andryuk
2024-08-13 16:58 ` Anthony PERARD
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.