All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@linaro.org>
Cc: linux-perf-users@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	"Liang, Kan" <kan.liang@linux.intel.com>,
	Howard Chu <howardchu95@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf test trace_btf_enum: Fix shellcheck warning
Date: Wed, 28 Aug 2024 18:19:04 -0300	[thread overview]
Message-ID: <Zs-USNvG5gfxCM2h@x1> (raw)
In-Reply-To: <20240809095426.3065163-1-james.clark@linaro.org>

On Fri, Aug 09, 2024 at 10:54:22AM +0100, James Clark wrote:
> Shellcheck versions < v0.7.2 can't follow this path so add the helper to
> fix the following warning:
> 
>   In tests/shell/trace_btf_enum.sh line 13:
>   . "$(dirname $0)"/lib/probe.sh
>   ^--------------------------^ SC1090: Can't follow non-constant source.
>   Use a directive to specify location.

Thanks, applied to perf-tools-next,

- Arnaldo
 
> Fixes: d66763fed30f ("perf test trace_btf_enum: Add regression test for the BTF augmentation of enums in 'perf trace'")
> Signed-off-by: James Clark <james.clark@linaro.org>
> ---
>  tools/perf/tests/shell/trace_btf_enum.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/tests/shell/trace_btf_enum.sh b/tools/perf/tests/shell/trace_btf_enum.sh
> index 7d407b52bea5..5a3b8a5a9b5c 100755
> --- a/tools/perf/tests/shell/trace_btf_enum.sh
> +++ b/tools/perf/tests/shell/trace_btf_enum.sh
> @@ -10,6 +10,7 @@ non_syscall="timer:hrtimer_init,timer:hrtimer_start"
>  
>  TESTPROG="perf test -w landlock"
>  
> +# shellcheck source=lib/probe.sh
>  . "$(dirname $0)"/lib/probe.sh
>  skip_if_no_perf_trace || exit 2
>  
> -- 
> 2.34.1

      reply	other threads:[~2024-08-28 21:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09  9:54 [PATCH] perf test trace_btf_enum: Fix shellcheck warning James Clark
2024-08-28 21:19 ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zs-USNvG5gfxCM2h@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=howardchu95@gmail.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.