* [PATCH] perf test trace_btf_enum: Fix shellcheck warning
@ 2024-08-09 9:54 James Clark
2024-08-28 21:19 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: James Clark @ 2024-08-09 9:54 UTC (permalink / raw)
To: linux-perf-users
Cc: James Clark, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
Liang, Kan, Howard Chu, linux-kernel
Shellcheck versions < v0.7.2 can't follow this path so add the helper to
fix the following warning:
In tests/shell/trace_btf_enum.sh line 13:
. "$(dirname $0)"/lib/probe.sh
^--------------------------^ SC1090: Can't follow non-constant source.
Use a directive to specify location.
Fixes: d66763fed30f ("perf test trace_btf_enum: Add regression test for the BTF augmentation of enums in 'perf trace'")
Signed-off-by: James Clark <james.clark@linaro.org>
---
tools/perf/tests/shell/trace_btf_enum.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/tests/shell/trace_btf_enum.sh b/tools/perf/tests/shell/trace_btf_enum.sh
index 7d407b52bea5..5a3b8a5a9b5c 100755
--- a/tools/perf/tests/shell/trace_btf_enum.sh
+++ b/tools/perf/tests/shell/trace_btf_enum.sh
@@ -10,6 +10,7 @@ non_syscall="timer:hrtimer_init,timer:hrtimer_start"
TESTPROG="perf test -w landlock"
+# shellcheck source=lib/probe.sh
. "$(dirname $0)"/lib/probe.sh
skip_if_no_perf_trace || exit 2
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf test trace_btf_enum: Fix shellcheck warning
2024-08-09 9:54 [PATCH] perf test trace_btf_enum: Fix shellcheck warning James Clark
@ 2024-08-28 21:19 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2024-08-28 21:19 UTC (permalink / raw)
To: James Clark
Cc: linux-perf-users, Peter Zijlstra, Ingo Molnar, Namhyung Kim,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Ian Rogers,
Adrian Hunter, Liang, Kan, Howard Chu, linux-kernel
On Fri, Aug 09, 2024 at 10:54:22AM +0100, James Clark wrote:
> Shellcheck versions < v0.7.2 can't follow this path so add the helper to
> fix the following warning:
>
> In tests/shell/trace_btf_enum.sh line 13:
> . "$(dirname $0)"/lib/probe.sh
> ^--------------------------^ SC1090: Can't follow non-constant source.
> Use a directive to specify location.
Thanks, applied to perf-tools-next,
- Arnaldo
> Fixes: d66763fed30f ("perf test trace_btf_enum: Add regression test for the BTF augmentation of enums in 'perf trace'")
> Signed-off-by: James Clark <james.clark@linaro.org>
> ---
> tools/perf/tests/shell/trace_btf_enum.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/tests/shell/trace_btf_enum.sh b/tools/perf/tests/shell/trace_btf_enum.sh
> index 7d407b52bea5..5a3b8a5a9b5c 100755
> --- a/tools/perf/tests/shell/trace_btf_enum.sh
> +++ b/tools/perf/tests/shell/trace_btf_enum.sh
> @@ -10,6 +10,7 @@ non_syscall="timer:hrtimer_init,timer:hrtimer_start"
>
> TESTPROG="perf test -w landlock"
>
> +# shellcheck source=lib/probe.sh
> . "$(dirname $0)"/lib/probe.sh
> skip_if_no_perf_trace || exit 2
>
> --
> 2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-28 21:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-09 9:54 [PATCH] perf test trace_btf_enum: Fix shellcheck warning James Clark
2024-08-28 21:19 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.