* [PATCH] net: ftgmac100: Fixed NC-SI PHY device cannot get
@ 2024-06-28 7:14 Jacky Chou
2024-09-09 7:49 ` Leo Liang
0 siblings, 1 reply; 2+ messages in thread
From: Jacky Chou @ 2024-06-28 7:14 UTC (permalink / raw)
To: ryan_chen, chiawei_wang, BMC-SW, joel, joe.hershberger,
rfried.dev, trini, sjg, kobedylan, jacky_chou, u-boot
The NC-SI interface does not need the MDIO bus and the
NC-SI PHY device cannot get from dm_eth_phy_connect.
Therefore, use phy_connect directly here.
Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
---
drivers/net/ftgmac100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ftgmac100.c b/drivers/net/ftgmac100.c
index 9b536fd5ab..256a519020 100644
--- a/drivers/net/ftgmac100.c
+++ b/drivers/net/ftgmac100.c
@@ -223,7 +223,7 @@ static int ftgmac100_phy_init(struct udevice *dev)
struct phy_device *phydev;
int ret;
- if (IS_ENABLED(CONFIG_DM_MDIO))
+ if (IS_ENABLED(CONFIG_DM_MDIO) && priv->phy_mode != PHY_INTERFACE_MODE_NCSI)
phydev = dm_eth_phy_connect(dev);
else
phydev = phy_connect(priv->bus, priv->phy_addr, dev, priv->phy_mode);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ftgmac100: Fixed NC-SI PHY device cannot get
2024-06-28 7:14 [PATCH] net: ftgmac100: Fixed NC-SI PHY device cannot get Jacky Chou
@ 2024-09-09 7:49 ` Leo Liang
0 siblings, 0 replies; 2+ messages in thread
From: Leo Liang @ 2024-09-09 7:49 UTC (permalink / raw)
To: Jacky Chou
Cc: ryan_chen, chiawei_wang, BMC-SW, joel, joe.hershberger,
rfried.dev, trini, sjg, kobedylan, u-boot
On Fri, Jun 28, 2024 at 03:14:45PM +0800, Jacky Chou wrote:
> The NC-SI interface does not need the MDIO bus and the
> NC-SI PHY device cannot get from dm_eth_phy_connect.
> Therefore, use phy_connect directly here.
>
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> ---
> drivers/net/ftgmac100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Leo Yu-Chi Liang <ycliang@andestech.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-09 7:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-28 7:14 [PATCH] net: ftgmac100: Fixed NC-SI PHY device cannot get Jacky Chou
2024-09-09 7:49 ` Leo Liang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.