Re: How to contribute to the linux kernel

[Qianqiang Liu <qianqiang.liu@163.com>]

Hi Greg,

Thanks a lot.

Best,
Qianqiang Liu

On Sat, Aug 31, 2024 at 07:32:04PM +0200, Greg KH wrote:
> On Sat, Aug 31, 2024 at 04:17:35PM +0800, Qianqiang Liu wrote:
> > 
> > Hi all,
> > 
> > I am an embedded software engineer. I use Linux every day, and I appreciate its neatness and simplicity.
> > 
> > One day, I watched a video from Greg: https://youtu.be/LLBrBBImJt4, and I started wondering if maybe I could contribute to the Linux kernel. So, I sent a very simple (and maybe stupid) patch to the community:
> > 
> > > On Fri, Aug 30, 2024 at 04:54:38PM +0800, Qianqiang Liu wrote:
> > > There is no need to add parentheses around 'devcode != 0x0000' and
> > > 'devcode != 0x9320'
> > > 
> > > Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com>
> > > ---
> > > drivers/staging/fbtft/fb_ili9320.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbtft/fb_ili9320.c
> > > index 0be7c2d51548..409b54cc562e 100644
> > > --- a/drivers/staging/fbtft/fb_ili9320.c
> > > +++ b/drivers/staging/fbtft/fb_ili9320.c
> > > @@ -37,7 +37,7 @@ static int init_display(struct fbtft_par *par)
> > >    devcode = read_devicecode(par);
> > >    fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "Device code: 0x%04X\n",
> > >              devcode);
> > > -    if ((devcode != 0x0000) && (devcode != 0x9320))
> > > +    if (devcode != 0x0000 && devcode != 0x9320)
> > >        dev_warn(par->info->device,
> > >             "Unrecognized Device code: 0x%04X (expected 0x9320)\n",
> > >            devcode);
> > > -- 
> > > 2.39.2
> > 
> > 
> > It turns out that the patch was rejected.
> 
> That's just because it's something that I don't think should be changed,
> not because it was "stupid" or anything like that.  It's been discussed
> many times in the past, not a big deal.
> 
> > So, my question is: how can I start contributing to the Linux kernel?
> > Maybe I could start by fixing some small bugs?
> 
> Sure, try reading this:
> 	https://lists.kernelnewbies.org/pipermail/kernelnewbies/2017-April/017765.html
> 
> Good luck!
> 
> greg k-h
> 
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies